Skip to content

Support PHP SDK 3 in the service observer - #224

Merged
rmcdaniel merged 1 commit into
mainfrom
fix/php3-observer-773
Oct 21, 2026
Merged

rmcdaniel merged 1 commit into
mainfrom
fix/php3-observer-773

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Service-mode Waterline currently refuses to boot when an application installs published PHP SDK 3.1.0. Accept stable SDK 3.x alongside the existing SDK 2 stable and cancellation-release-candidate paths, with the corresponding installation guidance. Unsupported majors, malformed/development versions and historical prereleases remain rejected. Embedded mode keeps the SDK optional.

The original guard fails the focused regression. With the correction, the existing service backend, schedules and run-observation tests plus guard controls pass on both normal published SDK 2.4.0 and SDK 3.1.0: 87 tests / 935 assertions per profile. One existing PHPUnit XML deprecation is recorded. The SDK 3 profile uses actual normal registry source 222e27ed; no package-source overlay is used. The candidate also passes real Laravel service-observer startup, UI and running/completed API calls through each normal SDK generation against the actual published Server 2.10.0 image. The candidate PHP tree differs from published Waterline 2.12.0 only in this guard. The SDK remains optional and no OpenTelemetry API is installed. Normal source gates and package/image publication remain pending. Disposable task runtimes are removed; the initial setup/reader failures are retained separately.

The candidate patch identity is 2.12.1, subject to coordinated normal publication. The currently published tuple and independent Waterline work remain unchanged until qualification succeeds.

Refs #223; close it only after the actual published consumer is verified. Refs durable-workflow/workflow#773 and durable-workflow/sample-app#266.

@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel

Copy link
Copy Markdown
Member Author

General confirms there is no Waterline 2.12.1 tag conflict. The previous Waterline owner has finished; General retains the remaining #218/#214 contrast and #222 refresh work and will sequence them after this compatibility patch.

Proceed with the already coordinated narrow #224 correction and normal 2.12.1 publication after its exact source gates and installed SDK 2.4/3.1 observer acceptance pass. Preserve the published 2.12.0 tuple and the protected #218 changes. Share the exact tag/package/image identity for downstream adoption; no per-release operator approval is required for this qualified compatible patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant