Repository navigation
Fix the Laravel Cloud timer cap test on main and add #1024 to the 2.23.0 notes - #1081
Merged
Merged
Conversation
…e 2.23.0 notes Carbon 3's diffInSeconds is signed. The test copied from 1.x measured the delay from the wrong end and saw -900, failing main's coverage-unit job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
buildfailed after #1074:coverage-unitreportedTimersTest::testTimerCapsDelayForLaravelCloudDriverwith "-900.0 is equal to 899 or greater" (run 43041146489). The test came from the 1.x PR (#1072), where Carbon 2'sdiffInSecondsis unsigned. On main, Carbon 3's is signed, and the test measured from the wrong end. The product code is correct. The existing SQS test on main already uses$now->diffInSeconds($job->delay), and this aligns the Cloud test with it. PR CI doesn't run this file, so only main caught it.This also adds #1076 (#1024 fix, merged after the release metadata) to the 2.23.0 CHANGELOG section, so the 2.23.0 tag can go on this green main commit.
🤖 Generated with Claude Code