Repository navigation
Run the full unit suite on pull requests - #1082
Merged
Merged
Conversation
coverage-unit runs the unit suite only after merge, so a unit test that fails there could merge green. #1074's Laravel Cloud timer test did exactly that. A new pr-unit job runs the same suite without coverage, with the same SQLite and Redis setup, and the build gate requires it on pull requests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Measured on this PR: |
|
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
coverage-unitruns the whole unit suite only after merge. PRs ran a fixed list of database-independent unit contracts, so a unit test that only fails in the full suite could merge green. #1074's Laravel Cloud timer test did exactly that, and main has been red since (fix: #1081).Change
pr-unitjob, on pull requests only. It runsvendor/bin/phpunit --testsuite unitwithout coverage, with the same SQLite-file database, Redis service and environment ascoverage-unit. It depends only onpreflight, so it runs in parallel with the other PR jobs.buildgate now requirespr-unitto succeed on PRs and be skipped on pushes.test-build-routing.pygains a test for that contract. All 22 routing tests pass locally.Cost: one more runner per PR. The unit suite without coverage took about 6 minutes in a container, against about 22 minutes for
coverage-unitwith PCOV, and PR builds already take about 7.5 minutes. I'll confirm the actual duration from this PR's run.pr-unit-contractsstays as it is, since it covers special environments such as file-backed SQLite concurrency and continuation profiles.This PR's own
pr-unitwill fail on the knownTimersTestuntil #1081 merges. I'll update the branch then.🤖 Generated with Claude Code