Repository navigation
docs(analytics): plugins: [] installs follow the admin language from EmDash 1.0.1 - #23
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e2c9565 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmDash 1.0.1 includes emdash-cms/emdash#3322: a plugin registered in
plugins: []now receives the admin locale on its Block Kit pages and widgets. The analytics README still said such an install stays English on the dashboard and its pages, which is no longer true from 1.0.1 on.Docs only; the plugin already reads
routeCtx.ui?.localeand falls back to English. The patch changeset brings the corrected README to npm.Changes
plugins: []installs before EmDash 1.0.1 only.routeCtx.uinote says the widget and pages get it in both install modes from 1.0.1.Verified
On a create-emdash site with
emdash@1.0.1and the published analytics 0.2.1 inplugins: [analytics], the widget and the Analytics page answer in English with theemdash-locale=encookie and in German withemdash-locale=de("Besuche, letzte 7 Tage", "1.186", "7 Tage").