Skip to content

docs(analytics): plugins: [] installs follow the admin language from EmDash 1.0.1 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmlr merged 1 commit into from
Sep 29, 2026
Merged

docs(analytics): plugins: [] installs follow the admin language from EmDash 1.0.1 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/analytics-admin-language-1-0-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@eisbachcode/emdash-plugin-analytics": patch
---

The README now says that a plugin registered in `plugins: []` follows the admin language on the dashboard and its pages from EmDash 1.0.1; before 1.0.1 it stays English there. The plugin code is unchanged.
10 changes: 5 additions & 5 deletions packages/analytics/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ at the workspace root is enough.
after any change that adds a `ctx` call.
- **Block Kit keys are snake_case.** Use the constructors in
`src/ui/blocks.ts`; the renderer silently ignores camelCase.
- `routeCtx.ui` (locale, direction) reaches the widget and the pages only
when the plugin runs sandboxed. Registered in `plugins: []` it is
undefined there, so read `routeCtx.ui?.locale` and fall back to English;
never return empty blocks when it is missing. The editor panel gets it in
both modes, with `ui.entry`.
- `routeCtx.ui` (locale, direction) reaches the widget and the pages in
both install modes from EmDash 1.0.1; before that, a `plugins: []`
install gets it undefined there. Read `routeCtx.ui?.locale` and fall back
to English; never return empty blocks when it is missing. The editor panel
gets it in both modes on every version, with `ui.entry`.
- **MCP schemas never reach the runtime.** `emdash-plugin build` strips
the `mcp` property of `src/plugin.ts` from the bundle and writes the zod
schemas into the manifest as JSON Schema. `src/tools/declare.ts` is
Expand Down
9 changes: 5 additions & 4 deletions packages/analytics/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,11 @@ language, so a German admin reads "1.234", "18.09.2026" and "Deutschland".

Two limits come from EmDash, not from this plugin:

- **Registered in `plugins: []`, the plugin stays English** on the
dashboard and its pages. EmDash 0.39 tells a plugin the admin language
there only when it runs sandboxed from the registry. The editor panel
gets it either way.
- **Before EmDash 1.0.1, the widget and the pages stay English in a
`plugins: []` install**, because EmDash passes such a plugin the admin
language there only from 1.0.1 on. Installed from the registry, the
plugin gets it on earlier versions too. The editor panel gets it either
way.
- **Labels declared in the manifest stay English everywhere:** the sidebar
entry, the widget title and the settings form. EmDash renders those
itself and does not read plugin translations.
Expand Down
Loading