Repository navigation
fix(analytics): npm publish no longer triggers a registry publish - #5
Merged
Merged
Conversation
`emdash-plugin init` generated a script named `publish`. npm and pnpm run a script with that name after every publish, so the first `npm publish` would also have started `emdash-plugin publish` against the EmDash registry; a dry run did exactly that and stopped at "Not logged in". The registry commands are now `registry:publish` and `registry:login`, and `prepublishOnly` builds first so a stale dist cannot be published. AGENTS.md says why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in the dry run before the first npm publish.
emdash-plugin initgenerates"publish": "emdash-plugin publish". npm and pnpm run a script namedpublishautomatically after every publish, sonpm publishwould also have pushed the plugin to the EmDash registry.pnpm publish --dry-rundid exactly that and stopped at "Not logged in. Run: emdash-plugin login".publish→registry:publish,login→registry:login(the registry publish stays a deliberate step).prepublishOnly: pnpm run build, so a publish always ships a freshdist/.publish,versionorprepare, and why.Checked: the dry run now builds and stops at npm without touching the registry;
pnpm packgives 11 files, 40 KB (dist, manifest, README, LICENSE), peeremdash: >=0.39.0.No changeset: the package is unreleased.