Skip to content

fix(analytics): npm publish no longer triggers a registry publish #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmlr merged 1 commit into from
Sep 25, 2026
Merged

fix(analytics): npm publish no longer triggers a registry publish #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ pnpm build
## Releases

Versions come from changesets: add one with `pnpm changeset` for every
change to a published package, written for someone upgrading. The workspace
change to a published package, written for someone upgrading.

Never name a package script `publish`, `version` or `prepare`: npm and pnpm
run scripts with those names on their own during a publish or a version
bump. `emdash-plugin init` generates `"publish": "emdash-plugin publish"`,
which would push to the EmDash registry after every `npm publish`; here it
is `registry:publish`, and `prepublishOnly` builds before any publish. The workspace
installs with pnpm 11; `allowBuilds` in `pnpm-workspace.yaml` lets esbuild
and workerd run their install scripts, which the test host needs.
5 changes: 3 additions & 2 deletions packages/analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@
"typecheck": "tsc --noEmit",
"test": "emdash-plugin validate && vitest run",
"bundle": "emdash-plugin bundle",
"login": "emdash-plugin login",
"publish": "emdash-plugin publish",
"registry:login": "emdash-plugin login",
"registry:publish": "emdash-plugin publish",
"release:setup": "emdash-plugin release setup",
"prepublishOnly": "pnpm run build",
"build:astro": "tsdown"
},
"engines": {
Expand Down
Loading