Repository navigation
Community room sessions end with the person's session - #536
Conversation
|
Bounded SOURCE PASS for the reviewed candidate. I traced room-session creation, renewal and the eleven use paths through grant/principal binding, expiry and both validators, including legacy-record refusal. The shared token-expiry changes retain the recovery path that prepares tokens before committing the grant. |
|
okey, I will take a look |
Independent security review — PR #536 (Community room sessions end with the person's session)Two-model independent review (DeepSeek + Claude Opus 5.5), each finding re-checked against the merged tree Verdict: PASS. Both findings are closed; no new issue was introduced. Confirmed closures
Items raised in cross-check, resolved against the tree
Follow-ups (post-merge, non-blocking)
Neither follow-up is exploitable; both fail closed. |
|
@andersalm both issues have already 1 PR each related to them. |
|
@irzhywau gentle reminder: your review of this change (room sessions end with the person's session, your S5/S6 finding) is a gate before 2.0.1 stable, planned for this weekend. 2.0.1-rc.1 is about to go to the test channel with it; if you find anything, it can still go into the stable build. |
|
Correction to my reminder above: @irzhywau's independent security review already passed this change on 5 Nov (comment 6665818315, on the merged tree 344284e). The seven files it reviewed are byte-identical in the 2.0.1-rc.1 source (30b166b), so that PASS carries to the release candidate. Sorry for the noise. |
Deepen notes
room_service.rsSESSION_TTL_SECS and the session validators,gateway_room.rssession start and every room route,auth.rsload_active_session_grant.Problem
A Community room session was minted for 12 hours and checked only against its own expiry, so after sign-out or a revoked sign-in it kept working until it expired. Found in an independent security review of #532.
Change
/session/start.Tests
10 new room and token regressions (6 failed before, a normal 12-hour session still lasts 12 hours); legacy record refusal and lapsed-grant 401; room tests 157, home-token 20, Chat online 13, behaviour suite 2,180, full Linux check PASS.