Repository navigation
Browser on Linux is turned on with elastos setup --browser, not by install.sh - #551
Conversation
Add elastos setup --browser for signed host helpers, confirmed administrator setup and verified image preparation. Default Linux install/setup leave Browser preparation to that choice; Marketplace and Browser explain the command. Preserve Apple Silicon setup and move retired pool cleanup to explicit opt-in. Deepen notes: gate every preparation entry path; start at 577bb01 install.sh:1117, setup/browser_config.rs:359 and api/gateway_browser_engine.rs:32; use fake Linux/process fixtures and existing signed admission; pinned installer/UI regressions fail before and current installer/behavior checks pass. Opus development/adversarial PASS covers tree d02f1da. Checks: installer 97 (4 optional publisher-fixture skips), product-data tests 105, behavior 2181, source gate, both fmt checks and server all-target Clippy PASS. Focused Browser Rust tests pending a serial retry after the disk guard stopped parallel compilation before tests ran. No push.
Register Browser in the fixture's active component manifest and resolve the macOS temporary base before testing strict no-link pool removal. The first Browser library run passed 414 tests, failed these two new fixtures and ignored two; the current all-target gate will verify both repairs. Runtime behavior is unchanged.
Use the Home owner's stored Browser selection to refresh changed Linux helpers on setup and open. Offer Browser on supported Linux Homes with setup and restart guidance. Keep the installer hint for fresh Homes with accessible or ACL-repairable KVM, and verify the exact managed network script through its manifest checksum. Verification: - cargo fmt --all -- --check; chain-provider fmt check - cargo clippy -p elastos-server --all-targets -- -D warnings - cargo test -p elastos-server --all-targets browser (438 passed, 2 ignored) - Home summary and installed verifier tests (5 passed) - Browser Node tests (85 passed) - scripts/test-source-gate.sh; scripts/test-behaviour.sh (2181 passed) - python3 scripts/install-bootstrap-test.py (95 passed, 4 skipped) - git diff --check
Keep Browser opt-in changes with the reviewed installer permission and process-age repairs. The combined tree retains all 17 incoming installer tests and all candidate test cases. Verified combined tree 723a810: workspace and chain-provider formatting, server all-targets Clippy with -D warnings, 443 focused Rust tests, 85 Browser Node tests, source gate, 2181 behaviour tests, and installer suite (112 passed, 4 publisher-fixture skips).
# Conflicts: # elastos/CHANGELOG.md
Keep the signed release digest with the captured helper bytes. Install and reverify an owned copy in one sudo step, then execute the verified snapshot with the helper confirmation on the tty. Verified: 6 Linux setup unit tests, 7 root bootstrap tests, all-target Clippy, formatting and the source gate. The full server rerun uses the CI process-provider fixtures.
Normalize the adapter choice before preparation. An existing local Engine selection admits helper repair before the host probe; a fresh Home keeps the setup refusal before downloads. Verified: 4 actual Open consumer regressions, all-target Clippy, formatting, 1286 Browser Node tests and the source gate.
|
@irzhywau your security review is wanted here: this changes how the one-time administrator step for Browser on Linux runs (#406). The helper bytes are admitted against the signed manifest, read once before the password prompt, and handed on stdin to a fixed root step compiled into the Runtime, which writes a root-owned copy, checks its SHA-256 and runs only those bytes. Codex Root's bounded source pass (#535 comment 6683449321) and a Claude security review passed it. As with #536, it can merge into develop for the 2.0.1 build, and your review is a gate before 2.0.1 is signed (#535). |
Independent adversarial security review — PR #551 (Browser on Linux via
|
|
Merged for 2.0.1 at acd2bae. Reviews: Claude FAIL on 8e1a360, fixed, Claude PASS on 63154b3; Codex Root CHANGES REQUIRED on f1232e1 (P1 #406 root helper not bound to admitted bytes; P2 Open repair order), fixed in e7d1ded and 8f40786, Claude security review PASS, tests strengthened in b6093f8, Root bounded SOURCE PASS on bc39a93; acd2bae only adds a develop merge (Root: all 21 reviewed files byte-identical). Full Linux check PASS on acd2bae; CI 15/15. Irzhy's security review stays a gate before 2.0.1 is signed (#535). |
Deepen notes
scripts/install.shprepare_browser_linux_host,setup/browser_config.rs,gateway_browser_engine.rs.elastos setup --browser; gates keyed on "Browser was enabled on this Home", not host readiness; fake Linux hosts in the installer tests.Change
elastos setup --browserturns Browser on: it asks before the one-time administrator changes, checks host access, then downloads and verifies the image with progress. Then restart Home once (the Browser bridges read their configuration at Home start).elastos setupand when Browser opens. A Home that never did downloads nothing and makes no sudo call.Part of #90. Release issue #535.