Repository navigation
Extract the React Studio Preview SDK, UI, API client and auth packages - #8931
Merged
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 293 files, which is 143 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit. ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 293
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Member
Author
Member
Author
|
@coderabbitai review |
|
Contributor
 [Medium impact] No outstanding findings block merging within the reviewed scope, subject to the editor-priority fix in PR #8954. SummaryExtracts four unpublished Preview packages for the SDK, shared UI, API client, and authentication.
No outstanding findings block merging within the reviewed scope, subject to the stated dependency on PR #8954. Reviews (7) · Last reviewed commit: "Merge branch 'codex/8859-react-studio-vi..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
Author
sfmskywalker
marked this pull request as ready for review
October 21, 2026 04:20
Member
Author
|
@greptileai Please review integrated head d685ccb after the current-main merge. |
Member
Author
|
@coderabbitai review Current integrated head: d685ccb |
|
…dio-sdk # Conflicts: # studio/react/src/modules/workflow-definitions/pages/editor-page.tsx
…dio-sdk # Conflicts: # studio/react/src/modules/workflow-definitions/pages/editor-page.tsx
Member
Author
|
@greptileai Please review final integrated head 4b64403. The latest main is incorporated and the addressed findings are verified and resolved. |
Member
Author
|
@coderabbitai review Please re-review final integrated head 4b64403; verified fixes and latest main are included. |
|
…dio-sdk # Conflicts: # studio/react/src/modules/designer/__tests__/switch-slots.test.ts
Member
Author
|
@greptileai Please review pushed head d56f194. All six latest findings have independently verified fixes and resolved threads, with208unit/28host/49browser checks passing locally. |
Member
Author
|
@coderabbitai review Please re-review pushed head d56f194; the six latest verified fixes have landed and prior threads are resolved. |
|
Member
Author
|
User-authorized self-review for #8859. APPROVE + HIGH @ d56f194 Reviewed all four Preview SDK packages, public registration slots, deterministic order/id sorting, host/SDK major-version diagnostics and separation of authentication and API contracts from the core SDK. Package consumption and shared React/context behavior are covered by the external module proof. The final adaptation source passes 221 unit, 28 hosting and 49 browser tests, lint/types, module-boundary and localization checks, and builds for net8/net9/net10. The final six findings and subsequent expression-alias/index and cached-culture findings were fixed with regression coverage before this merge. At merge time, current-head CI is green, Greptile is 5/5 on this exact head, and the exhaustive stack thread audit records zero unresolved findings. This is an author self-review under the task owner's explicit standing self-review/self-merge authority, not an independent approval. Use the standard head-matched merge into main without changing protection or using an admin bypass. |
4 tasks
20 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Studio's imported feature sources depended directly on host API, auth, editor context and UI files. This extracts four unpublished Preview workspace packages (
-sdk,-ui,-api-client,-auth) and makes the host and features consume their public exports.The SDK defines
register(api), typed contribution slots, stable ordering, host/SDK API version gates, transactional activation and cleanup diagnostics. Existing bundled modules use a temporary adapter pending #8845. A separate weather module installs four packed artifacts, compiles with NodeNext resolution and renders through the shared auth/UI context without host source aliases. TypeDoc output is generated and retained by CI. Authentication retains the five existing strategies and now rejects external callbacks with missing state.Validation: 102 Vitest cases; lint/typecheck/build; packed consumer; generated API reference; 19 ASP.NET host tests; 5 browser tests through embedded assets; dependency discovery guard (18 cases, 7,936 assertions); full npm audit with no known vulnerabilities. The build retains 114 production dependency notices. The final non-root Docker image builds and passes real Elsa Identity sign-in, flowchart creation through the actual API, designer rendering, saved-definition reload and temporary-definition cleanup.
Part of #8844 and epic #8859. This is stacked on #8925. Physical RCL manifests/assets, additional slot renderers and npm publication remain separate work; this PR does not close the epic or publish packages.