Repository navigation
Split React Studio into feature packages and add opt-in Core hosting - #8934
Merged
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 435 files, which is 285 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 435
You can disable this status message by setting the
Comment |
Member
Author
Member
Author
|
@coderabbitai review |
|
Member
Author
Member
Author
Member
Author
Contributor
 [Medium impact] No outstanding findings block merging, provided the fixes supplied by PR #8958 and PR #8947 remain part of the stack. SummarySplits React Studio into 16 feature packages and adds opt-in Core hosting.
Reviews (7) · Last reviewed commit: "Merge branch 'codex/8859-react-studio-sd..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
Author
|
@greptileai Please review the current head. Production preview now runs the ASP.NET host so it serves the import map, manifest and feature assets. Provider boundary recovery preserves its original children plus the diagnostic. Added real-command preview and throwing optional provider browser regressions: all 8 browser tests pass, along with 105 unit tests, lint/types/production asset build and host build. |
Contributor
|
This PR is set for a Plus review. TREX isn't supported with Plus or Apex reviews yet, so Greptile reviews this PR at Base while TREX is on. |
sfmskywalker
marked this pull request as ready for review
October 21, 2026 04:20
Member
Author
|
@greptileai Please review integrated head 8522f76 after the current-main merge. |
Member
Author
|
@coderabbitai review Current integrated head: 8522f76 |
|
…io-modules # Conflicts: # studio/react/dotnet/modules/Elsa.ReactStudio.WorkflowDefinitions/Client/pages/editor-page.tsx
Member
Author
|
@greptileai Please review final integrated head 907d613. The latest main is incorporated and the addressed findings are verified and resolved. |
Member
Author
|
@coderabbitai review Please re-review final integrated head 907d613; verified fixes and latest main are included. |
|
…io-modules # Conflicts: # studio/react/dotnet/modules/Elsa.ReactStudio.Designer/Client/__tests__/switch-slots.test.ts
Member
Author
|
@greptileai Please review pushed head bd9cb4c. All six latest findings have independently verified fixes and resolved threads, with208unit/28host/49browser checks passing locally. |
Member
Author
|
@coderabbitai review Please re-review pushed head bd9cb4c; the six latest verified fixes have landed and prior threads are resolved. |
|
20 of 24 tasks
Member
Author
|
User-authorized self-review for #8859. APPROVE + HIGH @ bd9cb4c Reviewed feature-delivered Razor class libraries, embedded ESM/CSS, public-package-only boundaries, feature enable/disable behavior, the aggregate and standalone host, and the off-by-default Core integration. Actual Core/RCL validation covers login, workflow creation, designer rendering, saved deep-link reload and cleanup. The final adaptation source passes 227 unit, 28 hosting and 49 browser tests, lint/types, module-boundary and localization checks, and builds for net8/net9/net10. The final six findings and subsequent expression-alias/index and cached-culture findings were fixed with regression coverage before this merge. At merge time, current-head CI is green, Greptile is 5/5 on this exact head, and the exhaustive stack thread audit records zero unresolved findings. This is an author self-review under the task owner's explicit standing self-review/self-merge authority, not an independent approval. Use the standard head-matched merge into main without changing protection or using an admin bypass. |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imported Studio registered every feature in one frontend bundle. This change moves the 16 features into Razor class libraries and lets enabled server features publish their versioned ESM/CSS entries. Shared packages and React come from one host import map; incompatible entries are rejected before import, and render failures leave the surrounding shell usable.
Core can explicitly enable Preview at
/studio-previewbeside/elsa/api; it remains off by default. Preview resolution preserves existing API scopes. The 20 production projects joinElsa.slnandElsa.ReactStudio.slnf, with exact dependency-inventory reconciliation. NUKE generates assets before compile/test/pack; CI packs and verifies all 18 libraries without publishing. Source notices record the donor's observed license status.Validation: 105 unit tests, 25 host tests, six Chromium tests, packed public-package consumer, generated API docs, lint/types, boundary guard, ten solution tests, and 18 dependency-census tests (8,395 assertions). All 18 NuGet packages contain net8/net9/net10 assemblies, embedded assets, consistent Preview versions and source notices; missing assets fail pack before a package is produced. NUKE asset target passes. Real same-origin Core sign-in, workflow creation, designer render, saved reload and cleanup pass. Default-off health/API/404 behavior passes. The updated non-root image (UID 1654) passes real cross-origin sign-in, workflow creation, designer render, saved reload and cleanup.
Part of #8859; implements the module/hosting work for #8845 and #8846, and the pack/build portion of #8847/#8848. Stacked on #8931. Full parity, the production extension template, publication and final source cutover remain separate acceptance work.