Skip to content

React Studio: verify partial parity and track confirmed gaps - #8945

Merged
sfmskywalker merged 8 commits into
mainfrom
codex/8859-react-studio-parity
Oct 21, 2026
Merged

sfmskywalker merged 8 commits into
mainfrom
codex/8859-react-studio-parity

Conversation

@sfmskywalker

@sfmskywalker sfmskywalker commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Verifies the imported editor's partial-parity areas and records confirmed gaps with reproducible follow-ups. The checklist covers every #8851 item: workflow settings, variable test values, outcomes, version viewing/deletion, Applications/API keys, undo/redo, copy/paste and activity port providers.

Adds four designer-store tests for history, deep copies, ID/edge remapping, cut/undo and nested duplication. Three production-host browser cases exercise workflow metadata/settings, variable defaults and outcome add/remove/save/reload; historical read-only viewing and version deletion; and canvas keyboard copy/paste/undo/redo with saved reload. This PR changes tests and documentation only.

Real Core API/catalog observations confirm the workflow logging field is dropped on reload and HTTP status-code ports/branches are missing. A public-store probe also reproduces duplicate names in a batch paste. Follow-ups are #8940 (workflow logging), #8941 (variable test values), #8942 (Applications/API keys), #8943 (HTTP ports/branches) and #8944 (paste names). Each links back to #8851 and #8859. The sanitized receipt records the audited source head and contains no credentials or temporary workflow IDs.

Validation: 126 unit tests, ESLint, TypeScript and all 15 ASP.NET/Chromium browser tests pass. studio/react/docs/parity.md states which evidence uses controlled browser API responses and which uses the real Core API; temporary API test data was deleted. This is a bounded parity audit, with linked gaps, rather than a claim of full Blazor parity.

Stacked on #8939; part of #8859. Closes #8851 when merged.

Summary by CodeRabbit

  • Documentation

    • Added a React Studio parity audit covering workflow settings, variables, outcomes, version management, applications, undo/redo, copy/paste, and activity ports.
    • Documented verified behaviors, known gaps, testing limitations, and audit guidance.
  • Tests

    • Added workflow editor coverage for settings, variable defaults, outcomes, version viewing and deletion, persistence, and reload behavior.
    • Added tests for clipboard actions, undo/redo, nested activity duplication, ID regeneration, and connection handling.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f86bc585-a7c4-4817-ba0b-5d104e8b4915
📥 Commits

Reviewing files that changed from the base of the PR and between 6acf726 and bd77331.

📒 Files selected for processing: 1
  • studio/react/tests/parity.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

📝 Walkthrough

This change adds React Studio parity audit records and documentation. It adds designer-store tests and Playwright tests for workflow settings, versions, clipboard operations, history, saving, and reload persistence. It records observed parity gaps.

Changes: React Studio parity verification

Layer / File(s) Summary
Parity audit evidence and guide
studio/react/docs/parity.md, studio/docs/specs/react-studio-preview/parity-observations.json, studio/docs/specs/react-studio-preview/plan.md, studio/react/README.md
Added a parity checklist, recorded observed gaps and verification coverage, updated the preview plan, and linked the audit guide from the README.
Designer history and clipboard tests
studio/react/packages/sdk/src/designer/store.test.ts
Added tests for activity updates, undo and redo, copy and paste, cut and undo, connection handling, and nested activity duplication.
Workflow editor browser tests
studio/react/tests/parity.spec.ts
Added browser tests for workflow settings, variable defaults, outcomes, version viewing and deletion, canvas copy and paste, undo and redo, saving, and reload persistence.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Possibly related issues

Merge Risk: ⚪ Minimal · up to bd773

No actionable issue remains from the supplied review; the change is mergeable after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly summarizes the primary change: verifying partial React Studio parity and tracking confirmed gaps.
Description check Passed The description clearly explains the purpose, scope, implemented tests, documented gaps, verification results, follow-up issues, and limitations. It does not use the repository template headings or in…
Linked Issues check Passed Issue #8851 requires evidence for each requested area and linked follow-ups for real gaps. studio/react/docs/parity.md lists workflow settings, variable test values, outcomes, version viewing/deleti…
Out of Scope Changes check Passed The changed documentation records the #8851 audit and its observations. The designer-store and browser tests verify the requested parity areas. The README link and sanitized observation file support a…
Full details: Description check

Explanation

The description clearly explains the purpose, scope, implemented tests, documented gaps, verification results, follow-up issues, and limitations. It does not use the repository template headings or include the checklist, but it provides the required information and is mostly complete.

Full details: Linked Issues check

Explanation

Issue #8851 requires evidence for each requested area and linked follow-ups for real gaps. studio/react/docs/parity.md lists workflow settings, variable test values, outcomes, version viewing/deletion, Applications/API keys, undo/redo, copy/paste, and activity port providers. The document records evidence, limitations, and follow-ups #8940–#8944. The added store and browser tests provide the stated verification coverage.

Full details: Out of Scope Changes check

Explanation

The changed documentation records the #8851 audit and its observations. The designer-store and browser tests verify the requested parity areas. The README link and sanitized observation file support access to the audit evidence. No unrelated production feature change appears in the supplied change summary.

✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Member Author

@greptileai @coderabbitai Please review this bounded partial-parity audit. It adds tests and evidence, with five confirmed gaps tracked separately. All 126 unit tests, lint/types, and all 15 ASP.NET/Chromium browser cases pass; the sanitized logging/HTTP observations use actual Core API/catalogs and contain no credentials or temporary IDs. Stacked on #8939.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

@sfmskywalker I’ll review this as a bounded partial-parity audit stacked on #8939. I’ll check test coverage, distinguish controlled browser responses from real Core API evidence, and verify that the five tracked gaps match the documented limits.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] No identified issue blocks merging this tests-and-documentation change. Known product gaps remain explicitly tracked as separate follow-up work.

Summary

This PR adds tests and a bounded parity checklist without changing production code.

  • The parity audit separates checked editor behavior from confirmed gaps.
  • Workflow edits and outcomes are checked through the editor save flow.
  • The version browser check covers read-only history and draft deletion.
  • Canvas history and clipboard checks follow edits from copy to reload.

No new actionable issues were found. This assessment checked the supplied evidence and current code; tests were not rerun.

Reviews (9) · Last reviewed commit: "Merge branch 'codex/8859-react-studio-ac..." · Reviewed by Greptile

Comment thread studio/react/tests/parity.spec.ts Outdated

Copy link
Copy Markdown
Member Author

@greptileai

@sfmskywalker
sfmskywalker marked this pull request as ready for review October 21, 2026 04:20

Copy link
Copy Markdown
Member Author

@greptileai Please review integrated head bd77331 after the current-main merge.

Copy link
Copy Markdown
Member Author

@coderabbitai review

Current integrated head: bd77331

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Member Author

@greptileai Please review final integrated head 0d98274. The latest main is incorporated and the addressed findings are verified and resolved.

Copy link
Copy Markdown
Member Author

@coderabbitai review

Please re-review final integrated head 0d98274; verified fixes and latest main are included.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

No files to review.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Member Author

@greptileai Please review pushed head 9b1a29c. All six latest findings have independently verified fixes and resolved threads, with208unit/28host/49browser checks passing locally.

Copy link
Copy Markdown
Member Author

@coderabbitai review

Please re-review pushed head 9b1a29c; the six latest verified fixes have landed and prior threads are resolved.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

No files to review.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Base automatically changed from codex/8859-react-studio-activity-settings to main October 21, 2026 21:27

Copy link
Copy Markdown
Member Author

User-authorized self-review for #8859.

APPROVE + HIGH @ 9b1a29c

Reviewed the evidence-backed partial-parity checklist and bounded follow-ups #8940–#8944. This deliverable audits and records remaining gaps; it does not claim complete Blazor parity.

The final adaptation source passes 227 unit, 28 hosting and 49 browser tests, lint/types, module-boundary and localization checks, and builds for net8/net9/net10. The final six findings and subsequent expression-alias/index and cached-culture findings were fixed with regression coverage before this merge.

At merge time, current-head CI is green, Greptile is 5/5 on this exact head, and the exhaustive stack thread audit records zero unresolved findings. This is an author self-review under the task owner's explicit standing self-review/self-merge authority, not an independent approval. Use the standard head-matched merge into main without changing protection or using an admin bypass.

@sfmskywalker
sfmskywalker merged commit 8d1002b into main Oct 21, 2026
6 of 8 checks passed
@sfmskywalker
sfmskywalker deleted the codex/8859-react-studio-parity branch October 21, 2026 21:28
@sfmskywalker sfmskywalker mentioned this pull request Oct 21, 2026
20 of 24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React studio: verify partial-parity areas

1 participant