Repository navigation
React Studio: verify partial parity and track confirmed gaps - #8945
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
@greptileai @coderabbitai Please review this bounded partial-parity audit. It adds tests and evidence, with five confirmed gaps tracked separately. All 126 unit tests, lint/types, and all 15 ASP.NET/Chromium browser cases pass; the sanitized logging/HTTP observations use actual Core API/catalogs and contain no credentials or temporary IDs. Stacked on #8939. |
|
✅ Action performedReview finished.
|
[Low impact] No identified issue blocks merging this tests-and-documentation change. Known product gaps remain explicitly tracked as separate follow-up work. SummaryThis PR adds tests and a bounded parity checklist without changing production code.
No new actionable issues were found. This assessment checked the supplied evidence and current code; tests were not rerun. Reviews (9) · Last reviewed commit: "Merge branch 'codex/8859-react-studio-ac..." · Reviewed by Greptile |
…859-react-studio-parity
|
@greptileai Please review integrated head bd77331 after the current-main merge. |
|
@coderabbitai review Current integrated head: bd77331 |
✅ Action performedReview finished.
|
…859-react-studio-parity
…859-react-studio-parity
…859-react-studio-parity
|
@greptileai Please review final integrated head 0d98274. The latest main is incorporated and the addressed findings are verified and resolved. |
|
@coderabbitai review Please re-review final integrated head 0d98274; verified fixes and latest main are included. |
|
…859-react-studio-parity
|
@greptileai Please review pushed head 9b1a29c. All six latest findings have independently verified fixes and resolved threads, with208unit/28host/49browser checks passing locally. |
|
@coderabbitai review Please re-review pushed head 9b1a29c; the six latest verified fixes have landed and prior threads are resolved. |
|
|
User-authorized self-review for #8859. APPROVE + HIGH @ 9b1a29c Reviewed the evidence-backed partial-parity checklist and bounded follow-ups #8940–#8944. This deliverable audits and records remaining gaps; it does not claim complete Blazor parity. The final adaptation source passes 227 unit, 28 hosting and 49 browser tests, lint/types, module-boundary and localization checks, and builds for net8/net9/net10. The final six findings and subsequent expression-alias/index and cached-culture findings were fixed with regression coverage before this merge. At merge time, current-head CI is green, Greptile is 5/5 on this exact head, and the exhaustive stack thread audit records zero unresolved findings. This is an author self-review under the task owner's explicit standing self-review/self-merge authority, not an independent approval. Use the standard head-matched merge into main without changing protection or using an admin bypass. |
Verifies the imported editor's partial-parity areas and records confirmed gaps with reproducible follow-ups. The checklist covers every #8851 item: workflow settings, variable test values, outcomes, version viewing/deletion, Applications/API keys, undo/redo, copy/paste and activity port providers.
Adds four designer-store tests for history, deep copies, ID/edge remapping, cut/undo and nested duplication. Three production-host browser cases exercise workflow metadata/settings, variable defaults and outcome add/remove/save/reload; historical read-only viewing and version deletion; and canvas keyboard copy/paste/undo/redo with saved reload. This PR changes tests and documentation only.
Real Core API/catalog observations confirm the workflow logging field is dropped on reload and HTTP status-code ports/branches are missing. A public-store probe also reproduces duplicate names in a batch paste. Follow-ups are #8940 (workflow logging), #8941 (variable test values), #8942 (Applications/API keys), #8943 (HTTP ports/branches) and #8944 (paste names). Each links back to #8851 and #8859. The sanitized receipt records the audited source head and contains no credentials or temporary workflow IDs.
Validation: 126 unit tests, ESLint, TypeScript and all 15 ASP.NET/Chromium browser tests pass.
studio/react/docs/parity.mdstates which evidence uses controlled browser API responses and which uses the real Core API; temporary API test data was deleted. This is a bounded parity audit, with linked gaps, rather than a claim of full Blazor parity.Stacked on #8939; part of #8859. Closes #8851 when merged.
Summary by CodeRabbit
Documentation
Tests