Repository navigation
ci: cache node_modules and skip the store cache in the v3 merge queue - #1201
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Risk score: Typical (2/4)Assessed at 8765954 from the changed files and the title, by
|
|
Thank you for following the naming conventions! 🙏 |
@evlog/cli
@evlog/eve
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
Ports the setup action's cache changes from
main(#1192 and #1200) tov3.v3still installs the whole workspace from the pnpm store in every job, and its merge queue saves a pnpm store cache for every queued PR under a temporarygh-readonly-queue/v3/...ref that no other run can read. Those entries are most of why the repository's caches sit at 10.7 GB against GitHub's 10 GB quota, where GitHub starts evicting the least recently used ones, includingmain'snode_modulescache.With this,
v3pull requests restore anode_modulescache that pushes tov3save (one entry per Node version in the test matrix), skipping the install when every manifest and the lockfile match, and merge queue runs no longer save the store cache. Only the setup action changes:v3'sci.ymlkeeps its own job layout (the Node 22/24 test matrix, eve compatibility), so the per-job filtered install and the test split frommainare not part of this.To check it after merge, the first push to
v3savesnode-modules-Linux-X64-…entries underrefs/heads/v3, visible with:Evidence from main
On
main, setup per job went from 40–55s to 17–20s on cache hits (#1192), and since #1200 queued runs save no store cache: the Windows smoke's cache save went from 16–31s to 0s and #1200's own queue run left no cache entries. Store cache entries at the time of writing, by ref (Linux and Windows, about 1.2 GB per queued PR):v3merge queue runs cannot read caches saved onv3: theLint & typecheckjob of queue run 44903179439 loggedpnpm cache is not foundalthoughrefs/heads/v3held a Linux store entry. So queuedv3runs keep installing as they do today, without the store cache they could not restore anyway; onlyv3pull requests gain thenode_modulesspeedup. The save condition names bothmainandv3, so the next sync ofmainintov3will conflict on that one line; keep this side. Nothing here was run outside CI; this PR's own run misses the new cache, since only pushes tov3save it.ELI5
The v3 branch now keeps a ready-made copy of its dependencies, so its pull requests no longer download and unpack everything from scratch. Its merge queue also stops saving copies that no other run can ever reuse, which were crowding out the useful ones.