Skip to content

ci: cache node_modules and skip the store cache in the v3 merge queue - #1201

Merged
HugoRCD merged 1 commit into
v3from
ci/v3-cache-port
Nov 21, 2026
Merged

HugoRCD merged 1 commit into
v3from
ci/v3-cache-port

Conversation

@HugoRCD

@HugoRCD HugoRCD commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Written by an AI agent on behalf of @HugoRCD. @HugoRCD has reviewed it.

Ports the setup action's cache changes from main (#1192 and #1200) to v3. v3 still installs the whole workspace from the pnpm store in every job, and its merge queue saves a pnpm store cache for every queued PR under a temporary gh-readonly-queue/v3/... ref that no other run can read. Those entries are most of why the repository's caches sit at 10.7 GB against GitHub's 10 GB quota, where GitHub starts evicting the least recently used ones, including main's node_modules cache.

With this, v3 pull requests restore a node_modules cache that pushes to v3 save (one entry per Node version in the test matrix), skipping the install when every manifest and the lockfile match, and merge queue runs no longer save the store cache. Only the setup action changes: v3's ci.yml keeps its own job layout (the Node 22/24 test matrix, eve compatibility), so the per-job filtered install and the test split from main are not part of this.

To check it after merge, the first push to v3 saves node-modules-Linux-X64-… entries under refs/heads/v3, visible with:

gh api "repos/evloghq/evlog/actions/caches?key=node-modules" --jq '.actions_caches[]|"\(.ref) \(.key[0:40])"'

Evidence from main

On main, setup per job went from 40–55s to 17–20s on cache hits (#1192), and since #1200 queued runs save no store cache: the Windows smoke's cache save went from 16–31s to 0s and #1200's own queue run left no cache entries. Store cache entries at the time of writing, by ref (Linux and Windows, about 1.2 GB per queued PR):

588MB refs/heads/gh-readonly-queue/v3/pr-1191-56ff897654ab12a2acbd23b85d2b4ad2c2947c4b Linux
576MB refs/heads/gh-readonly-queue/v3/pr-1191-56ff897654ab12a2acbd23b85d2b4ad2c2947c4b Windows
588MB refs/heads/gh-readonly-queue/v3/pr-1194-302f974686f934bebd3ce86232fcf6ffa2d1fae7 Linux
576MB refs/heads/gh-readonly-queue/v3/pr-1194-302f974686f934bebd3ce86232fcf6ffa2d1fae7 Windows

v3 merge queue runs cannot read caches saved on v3: the Lint & typecheck job of queue run 44903179439 logged pnpm cache is not found although refs/heads/v3 held a Linux store entry. So queued v3 runs keep installing as they do today, without the store cache they could not restore anyway; only v3 pull requests gain the node_modules speedup. The save condition names both main and v3, so the next sync of main into v3 will conflict on that one line; keep this side. Nothing here was run outside CI; this PR's own run misses the new cache, since only pushes to v3 save it.

ELI5

The v3 branch now keeps a ready-made copy of its dependencies, so its pull requests no longer download and unpack everything from scratch. Its merge queue also stops saving copies that no other run can ever reuse, which were crowding out the useful ones.

@vercel

vercel Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

5 Skipped Deployments
Project Deployment Actions Updated
evi Ignored Ignored Nov 21, 2026 1:33pm UTC
evlog-docs Ignored Ignored v0 Nov 21, 2026 1:33pm UTC
evlog-render-lab Ignored Ignored Nov 21, 2026 1:33pm UTC
evlog-telemetry Ignored Ignored Nov 21, 2026 1:33pm UTC
just-use-evlog Ignored Ignored Nov 21, 2026 1:33pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 03664177-849e-45bf-a331-cda2cd799a88

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown
Contributor

Risk score: Typical (2/4)

Assessed at 8765954 from the changed files and the title, by scripts/risk-score. A new push replaces this score.

  • On merge: changes CI workflows
  • CI and release: Release: changes CI steps: setup/action.yml
  • 1 files changed (37 lines), 0 of them tests
Area Level Why
CI and release Typical Release: changes CI steps: setup/action.yml

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@pkg-pr-new

pkg-pr-new Bot commented Nov 21, 2026

Copy link
Copy Markdown
@evlog/cli

npm i https://pkg.pr.new/@evlog/cli@1201

@evlog/eve

npm i https://pkg.pr.new/@evlog/eve@1201

evlog

npm i https://pkg.pr.new/evlog@1201

@evlog/nuxthub

npm i https://pkg.pr.new/@evlog/nuxthub@1201

@evlog/signals

npm i https://pkg.pr.new/@evlog/signals@1201

@evlog/telemetry

npm i https://pkg.pr.new/@evlog/telemetry@1201

commit: 8765954

@HugoRCD
HugoRCD added this pull request to the merge queue Nov 21, 2026
Merged via the queue into v3 with commit 4c2440c Nov 21, 2026
32 checks passed
@HugoRCD
HugoRCD deleted the ci/v3-cache-port branch November 21, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant