refactor: drop the unreachable standalone editor page and dead fields - #127
Merged
Merged
Conversation
Nothing in the UI links to /apps/exelearning/editor any more; file actions and the New menu open /view?mode=editor. Keep the route as a redirect there so old links still work, and delete the page's template, its editor-page.ts entry (which also carried an unfiltered SAVE_FILE handler that re-requested saves on every reply) and its initial state. Also remove ViewerToolbar.vue (never imported), the view page's unused editorIframeUrl initial state (the client builds it with the live webroot), and PackageShape/LoadedElpx fields nothing reads.
Contributor
Preview this PR in the Nextcloud PlaygroundA fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
erseco
added this pull request to stack #130
September 26, 2026 06:14
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/editor-ctrl-s #127 +/- ##
=======================================================
- Coverage 93.79% 93.37% -0.43%
+ Complexity 152 149 -3
=======================================================
Files 22 22
Lines 661 619 -42
Branches 54 53 -1
=======================================================
- Hits 620 578 -42
Misses 34 34
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4/5, based on #126.
What
Nothing links to
/apps/exelearning/editorany more: file actions and the New menu open/view?mode=editor./editorroute:EditorController::indexbecomes a redirect to/view?mode=editorthat keepsfileId/path, so old links still work.templates/editor.php,src/editor/editor-page.tsand its Vite entry. That page also had aSAVE_FILEhandler that ignoredrequestIdand re-requested a save on every reply.src/viewer/ViewerToolbar.vue(never imported).ViewController'seditorIframeUrlinitial state (the client builds it from the live webroot) and its now-unusedIURLGeneratorPackageShape.{hasContentXml,hasScreenshot,hintCount}LoadedElpx.contentLengthLoadElpxOptions.signalBehavior change:
/apps/exelearning/editornow returns a 303 instead of rendering its own page.Verification