Sync bob tests - #468
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| (test-equal? "shouting numbers" | ||
| (response-for "1, 2, 3 GO!") | ||
| (test-equal? "ending with whitespace" | ||
| (response-for "Okay if like my spacebar quite a bit? ") |
There was a problem hiding this comment.
Shouldn't this be "Okay if I like my spacebar quite a bit? "
There was a problem hiding this comment.
There was a problem hiding this comment.
What's the difference between the two? You can use the "Suggest a change" to suggest updates.
There was a problem hiding this comment.
https://github.com/exercism/problem-specifications/blob/8fb316e0dfd9ff8a563aac74583aec6ece9e5cb1/exercises/bob/canonical-data.json#L99 shows "Okay if like my spacebar quite a bit? ". The lack of a subject is strange, but the test is checking for the trailing whitespace so I guess it's okay.
There was a problem hiding this comment.
The difference is that one is a correct English sentence with a subject, similar to the other tests, while the other is ungrammatical and looks weird. Was this intentional?
There was a problem hiding this comment.
It looks like it was one of the original canonical test cases added back in 2015, and nobody fixed it in the intervening years.
There was a problem hiding this comment.
OK then, the dead hand of history prevails.
3 participants
Fixes #466. We reimplemented the existing multiline test but also resorted the tests.