Skip to content

Sync bob tests #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BNAndras merged 1 commit into from
Aug 3, 2026
Merged

Sync bob tests #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 46 additions & 43 deletions exercises/practice/bob/.meta/tests.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,82 +9,85 @@
# As user-added comments (using the # character) will be removed when this file
# is regenerated, comments can be added via a `comment` key.

[e162fead-606f-437a-a166-d051915cea8e]
description = "stating something"
[8a2e771d-d6f1-4e3f-b6c6-b41495556e37]
description = "asking a question"

[73a966dc-8017-47d6-bb32-cf07d1a5fcd9]
description = "shouting"

[d6c98afd-df35-4806-b55e-2c457c3ab748]
description = "shouting gibberish"
[a5193c61-4a92-4f68-93e2-f554eb385ec6]
description = "forceful question"

[8a2e771d-d6f1-4e3f-b6c6-b41495556e37]
description = "asking a question"
[bc39f7c6-f543-41be-9a43-fd1c2f753fc0]
description = "silence"

[e162fead-606f-437a-a166-d051915cea8e]
description = "stating something"

[81080c62-4e4d-4066-b30a-48d8d76920d9]
description = "asking a numeric question"

[2a02716d-685b-4e2e-a804-2adaf281c01e]
description = "asking gibberish"

[c02f9179-ab16-4aa7-a8dc-940145c385f7]
description = "talking forcefully"
[bb0011c5-cd52-4a5b-8bfb-a87b6283b0e2]
description = "question with no letters"

[153c0e25-9bb5-4ec5-966e-598463658bcd]
description = "using acronyms in regular speech"
[9bfc677d-ea3a-45f2-be44-35bc8fa3753e]
description = "non-letters with question"

[a5193c61-4a92-4f68-93e2-f554eb385ec6]
description = "forceful question"
[8608c508-f7de-4b17-985b-811878b3cf45]
description = "prattling on"

[a20e0c54-2224-4dde-8b10-bd2cdd4f61bc]
description = "shouting numbers"
[05b304d6-f83b-46e7-81e0-4cd3ca647900]
description = "ending with whitespace"

[f7bc4b92-bdff-421e-a238-ae97f230ccac]
description = "no letters"
[66953780-165b-4e7e-8ce3-4bcb80b6385a]
description = "multiple line question"
include = false

[bb0011c5-cd52-4a5b-8bfb-a87b6283b0e2]
description = "question with no letters"
[2c7278ac-f955-4eb4-bf8f-e33eb4116a15]
description = "multiple line question"
reimplements = "66953780-165b-4e7e-8ce3-4bcb80b6385a"

[d6c98afd-df35-4806-b55e-2c457c3ab748]
description = "shouting gibberish"

[3c954328-86fb-4c71-8961-e18d6a5e2517]
description = "shouting a statement containing a question mark"

[a20e0c54-2224-4dde-8b10-bd2cdd4f61bc]
description = "shouting numbers"

[496143c8-1c31-4c01-8a08-88427af85c66]
description = "shouting with special characters"

[e6793c1c-43bd-4b8d-bc11-499aea73925f]
description = "shouting with no exclamation mark"

[aa8097cc-c548-4951-8856-14a404dd236a]
description = "statement containing question mark"

[9bfc677d-ea3a-45f2-be44-35bc8fa3753e]
description = "non-letters with question"

[8608c508-f7de-4b17-985b-811878b3cf45]
description = "prattling on"

[bc39f7c6-f543-41be-9a43-fd1c2f753fc0]
description = "silence"

[d6c47565-372b-4b09-b1dd-c40552b8378b]
description = "prolonged silence"

[4428f28d-4100-4d85-a902-e5a78cb0ecd3]
description = "alternate silence"

[66953780-165b-4e7e-8ce3-4bcb80b6385a]
description = "multiple line question"
include = false
[72bd5ad3-9b2f-4931-a988-dce1f5771de2]
description = "other whitespace"

[5371ef75-d9ea-4103-bcfa-2da973ddec1b]
description = "starting with whitespace"
[c02f9179-ab16-4aa7-a8dc-940145c385f7]
description = "talking forcefully"

[05b304d6-f83b-46e7-81e0-4cd3ca647900]
description = "ending with whitespace"
[153c0e25-9bb5-4ec5-966e-598463658bcd]
description = "using acronyms in regular speech"

[72bd5ad3-9b2f-4931-a988-dce1f5771de2]
description = "other whitespace"
[f7bc4b92-bdff-421e-a238-ae97f230ccac]
description = "no letters"

[aa8097cc-c548-4951-8856-14a404dd236a]
description = "statement containing question mark"

[5371ef75-d9ea-4103-bcfa-2da973ddec1b]
description = "starting with whitespace"

[12983553-8601-46a8-92fa-fcaa3bc4a2a0]
description = "non-question ending with whitespace"

[2c7278ac-f955-4eb4-bf8f-e33eb4116a15]
description = "multiple line question"
reimplements = "66953780-165b-4e7e-8ce3-4bcb80b6385a"
110 changes: 57 additions & 53 deletions exercises/practice/bob/bob-test.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,25 @@
(test-suite
"bob tests"

(test-equal? "stating something"
(response-for "To-may-to, tom-aaaah-to.")
"Whatever.")
(test-equal? "asking a question"
(response-for "Does this cryogenic chamber make me look fat?")
"Sure.")

(test-equal? "shouting"
(response-for "WATCH OUT!")
"Whoa, chill out!")

(test-equal? "shouting gibberish"
(response-for "FCECDFCAAB")
"Whoa, chill out!")
(test-equal? "forceful question"
(response-for "WHAT'S GOING ON?")
"Calm down, I know what I'm doing!")

(test-equal? "asking a question"
(response-for "Does this cryogenic chamber make me look fat?")
"Sure.")
(test-equal? "silence"
(response-for "")
"Fine. Be that way!")

(test-equal? "stating something"
(response-for "Tom-ay-to, tom-aaaah-to.")
"Whatever.")

(test-equal? "asking a numeric question"
(response-for "You are, what, like 15?")
Expand All @@ -33,29 +37,37 @@
(response-for "fffbbcbeab?")
"Sure.")

(test-equal? "talking forcefully"
(response-for "Hi there!")
"Whatever.")
(test-equal? "question with no letters"
(response-for "4?")
"Sure.")

(test-equal? "using acronyms in regular speech"
(response-for "It's OK if you don't want to go work for NASA.")
"Whatever.")
(test-equal? "non-letters with question"
(response-for ":) ?")
"Sure.")

(test-equal? "forceful question"
(response-for "WHAT'S GOING ON?")
"Calm down, I know what I'm doing!")
(test-equal? "prattling on"
(response-for "Wait! Hang on. Are you going to be OK?")
"Sure.")

(test-equal? "shouting numbers"
(response-for "1, 2, 3 GO!")
(test-equal? "ending with whitespace"
(response-for "Okay if like my spacebar quite a bit? ")

@blakelewis blakelewis Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "Okay if I like my spacebar quite a bit? "

@IsaacG IsaacG Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/exercism/problem-specifications/blob/main/exercises/bob/canonical-data.json#L99

@IsaacG IsaacG Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between the two? You can use the "Suggest a change" to suggest updates.

@BNAndras BNAndras Aug 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/exercism/problem-specifications/blob/8fb316e0dfd9ff8a563aac74583aec6ece9e5cb1/exercises/bob/canonical-data.json#L99 shows "Okay if like my spacebar quite a bit? ". The lack of a subject is strange, but the test is checking for the trailing whitespace so I guess it's okay.

@blakelewis blakelewis Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is that one is a correct English sentence with a subject, similar to the other tests, while the other is ungrammatical and looks weird. Was this intentional?

@BNAndras BNAndras Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it was one of the original canonical test cases added back in 2015, and nobody fixed it in the intervening years.

@blakelewis blakelewis Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK then, the dead hand of history prevails.

"Sure.")

(test-equal? "multiple line question"
(response-for "\nDoes this cryogenic chamber make\n me look fat?")
"Sure.")

(test-equal? "shouting gibberish"
(response-for "FCECDFCAAB")
"Whoa, chill out!")

(test-equal? "no letters"
(response-for "1, 2, 3")
"Whatever.")
(test-equal? "shouting a statement containing a question mark"
(response-for "DO LIONS EAT PEOPLE? AHHHHH.")
"Whoa, chill out!")

(test-equal? "question with no letters"
(response-for "4?")
"Sure.")
(test-equal? "shouting numbers"
(response-for "1, 2, 3 GO!")
"Whoa, chill out!")

(test-equal? "shouting with special characters"
(response-for "ZOMG THE %^*@#$(*^ ZOMBIES ARE COMING!!11!!1!")
Expand All @@ -65,22 +77,6 @@
(response-for "I HATE THE DENTIST")
"Whoa, chill out!")

(test-equal? "statement containing question mark"
(response-for "Ending with ? means a question.")
"Whatever.")

(test-equal? "non-letters with question"
(response-for ":) ?")
"Sure.")

(test-equal? "prattling on"
(response-for "Wait! Hang on. Are you going to be OK?")
"Sure.")

(test-equal? "silence"
(response-for "")
"Fine. Be that way!")

(test-equal? "prolonged silence"
(response-for " ")
"Fine. Be that way!")
Expand All @@ -89,22 +85,30 @@
(response-for "\t\t\t\t\t\t\t\t\t\t")
"Fine. Be that way!")

(test-equal? "multiple line question"
(response-for "\nDoes this cryogenic chamber make\n me look fat?")
"Sure.")
(test-equal? "other whitespace"
(response-for "\n\r \t")
"Fine. Be that way!")

(test-equal? "talking forcefully"
(response-for "Hi there!")
"Whatever.")

(test-equal? "using acronyms in regular speech"
(response-for "It's OK if you don't want to go work for NASA.")
"Whatever.")

(test-equal? "no letters"
(response-for "1, 2, 3")
"Whatever.")

(test-equal? "statement containing question mark"
(response-for "Ending with ? means a question.")
"Whatever.")

(test-equal? "starting with whitespace"
(response-for " hmmmmmmm...")
"Whatever.")

(test-equal? "ending with whitespace"
(response-for "Okay if like my spacebar quite a bit? ")
"Sure.")

(test-equal? "other whitespace"
(response-for "\n\r \t")
"Fine. Be that way!")

(test-equal? "non-question ending with whitespace"
(response-for "This is a statement ending with whitespace ")
"Whatever.")))
Expand Down