Repository navigation
Conversation
lenderom
added
the
technical
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
therobrob
self-requested a review
October 15, 2026 17:11
therobrob
reviewed
Oct 15, 2026
therobrob
left a comment
therobrob
left a comment
Member
There was a problem hiding this comment.
Danke @lenderom für die Umsetzung! An sich passt es. :)
Einen Aspekt möchte ich nochmal hinterfragen: in der alten Implementierung hatten wir bei reservation_possible den Wert false als default. Nun fällt das weg. Ich frage mich aber, ob nicht immer einer der fünf Werte zutrifft?
| ], | ||
| default: "false", | ||
| param: { bare: true, required: true }, | ||
| default: "", |
Member
There was a problem hiding this comment.
wieso ist der default nicht "non-possible" wie zuvor?
Member
There was a problem hiding this comment.
Eine der Optionen trifft doch immer zu, oder nicht?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1123