Skip to content

fix: add sncf connect booking - #1263

Open
lenderom wants to merge 1 commit into
mainfrom
fix/add-sncf-connect-booking
Open

lenderom wants to merge 1 commit into
mainfrom
fix/add-sncf-connect-booking

Conversation

@lenderom

@lenderom lenderom commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Closes #578

@lenderom lenderom added content Improvements or additions to the content (countries, news, operators, general content) operator::sncf labels Oct 12, 2026
@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

@netlify

netlify Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit f4a476f
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/6acd0aa86fb7b2e3bc05d798
😎 Deploy Preview https://deploy-preview-1263--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines +14 to +15
aliases:
- sncf_website

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the aliases anymore?

Comment on lines +6 to +7
first: 2 € / 16 €
second: 2 € / 11 €

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we explain the two different prices somewhere? For me it is unclear, in which situation 2 € or 16 € applies. I know, we mention this in many sections of the website, but there is no explanation in my opinion 😅


{{% booking id="sncf-website-fip-sncf"
subtitle="Nur für SNCF Mitarbeitende"
fip_global_fare=nil

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not "true"?


{{% booking id="sncf-website-fip-sncf"
subtitle="Nur für SNCF Mitarbeitende und nur für grenzüberschreitende TGV Verbindungen"
reservations=false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the reservation booking section be hidden?

Image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "sncf-website-fip-sncf" and not "sncf-connect"?
Maybe in future the FIP booking is possible for more users and we have to rename it?


{{% booking id="sncf-website-fip-sncf"
subtitle="Nur für SNCF Mitarbeitende"
reservations=nil

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the reservation booking section be hidden?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Improvements or additions to the content (countries, news, operators, general content) operator::sncf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNCF Connect Booking

2 participants