Repository navigation
fix: add sncf connect booking #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| title: SNCF Connect Website | ||
| description: Buchungsinformationen für die SNCF Connect Website. | ||
| params: | ||
| classes: | ||
| first: 2 € / 16 € | ||
| second: 2 € / 11 € | ||
|
Comment on lines
+6
to
+7
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we explain the two different prices somewhere? For me it is unclear, in which situation 2 € or 16 € applies. I know, we mention this in many sections of the website, but there is no explanation in my opinion 😅
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These prices are only displayed on the SNCF site where the reservation prices are explained in the train category section. So we haven't explained it in the other SNCF booking ways or the NS booking which is also displayed on the site. So for now/this PR I would keep it as it is. But if you want to, we can think about detailed explanations about the prices in the purchase section in a different PR |
||
| fip_50: false | ||
| fip_75: false | ||
| fip_global_fare: true | ||
| reservations: true | ||
| booking_link: https://www.sncf-connect.com/de-de | ||
| type: website | ||
| aliases: | ||
| - sncf_website | ||
|
Comment on lines
+14
to
+15
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need the aliases anymore?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually no. I wasn't sure if we want to keep both writings. Whatever you like more, both is fine for me.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aliases on booking pages no longer work. If you want the alias to work, it has to be added to the SNCF operator page. The reason is that booking pages are no longer rendered as separate pages, so redirects no longer work as the target doesn't exist. |
||
| --- | ||
|
|
||
| Mitarbeitende der SNCF können online über SNCF Connect Reservierungen und Globalpreise für ausgewählte Verbindungen kaufen. | ||
|
|
||
| {{% booking-section "fip_global_fare" %}} | ||
|
|
||
| ## FIP Globalpreis | ||
|
|
||
| Für grenzüberschreitende TGV Verbindungen und Eurostar Züge können Globalpreise erworben werden. | ||
|
|
||
| {{% /booking-section %}} | ||
|
|
||
| {{% booking-section "reservations" %}} | ||
|
|
||
| ## Reservierungen | ||
|
|
||
| Für nationale TGV Verbindungen innerhalb Frankreichs können Reservierungen erworben werden. | ||
|
|
||
| {{% /booking-section %}} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| title: SNCF Connect Website | ||
| description: Booking information for the SNCF Connect Website. | ||
| params: | ||
| classes: | ||
| first: € 2 / € 16 | ||
| second: € 2 / € 11 | ||
| fip_50: false | ||
| fip_75: false | ||
| fip_global_fare: true | ||
| reservations: true | ||
| booking_link: https://www.sncf-connect.com/en-en | ||
| type: website | ||
| aliases: | ||
| - sncf_website | ||
| --- | ||
|
|
||
| SNCF employees can purchase reservations and Global Fares for selected connections online via SNCF Connect. | ||
|
|
||
| {{% booking-section "fip_global_fare" %}} | ||
|
|
||
| ## FIP Global Fare | ||
|
|
||
| Global Fares can be purchased for cross-border TGV connections and Eurostar trains. | ||
|
|
||
| {{% /booking-section %}} | ||
|
|
||
| {{% booking-section "reservations" %}} | ||
|
|
||
| ## Reservations | ||
|
|
||
| Reservations can be purchased for domestic TGV connections within France. | ||
|
|
||
| {{% /booking-section %}} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| title: Site Web SNCF Connect | ||
| description: Informations de réservation pour le site web SNCF Connect. | ||
| params: | ||
| classes: | ||
| first: 2 € / 16 € | ||
| second: 2 € / 11 € | ||
| fip_50: false | ||
| fip_75: false | ||
| fip_global_fare: true | ||
| reservations: true | ||
| booking_link: https://www.sncf-connect.com/fr-fr | ||
| type: website | ||
| aliases: | ||
| - sncf_website | ||
| --- | ||
|
|
||
| Les agents de la SNCF peuvent acheter en ligne, via SNCF Connect, des réservations et des Tarifs Globaux pour certaines liaisons. | ||
|
|
||
| {{% booking-section "fip_global_fare" %}} | ||
|
|
||
| ## Tarif Global FIP | ||
|
|
||
| Des Tarifs Globaux peuvent être achetés pour les liaisons TGV transfrontalières et les trains Eurostar. | ||
|
|
||
| {{% /booking-section %}} | ||
|
|
||
| {{% booking-section "reservations" %}} | ||
|
|
||
| ## Réservations | ||
|
|
||
| Des réservations peuvent être achetées pour les liaisons TGV nationales en France. | ||
|
|
||
| {{% /booking-section %}} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -132,6 +132,13 @@ Das Einchecken, Umbuchen, Stornieren und Upgraden von Tickets ist über die Euro | |
| fip_75=nil | ||
| /%}} | ||
|
|
||
| {{% booking id="sncf-connect" | ||
| subtitle="Nur für SNCF Mitarbeitende" | ||
| reservations=nil | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't the reservation booking section be hidden?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it was broken because of the missing sections |
||
| fip_50=nil | ||
| fip_75=nil | ||
| /%}} | ||
|
|
||
| ### Telefon | ||
|
|
||
| {{% booking id="eurostar-phone" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -231,6 +231,11 @@ FIP Vergünstigungen gelten auch in Bussen, die von der SNCF betrieben werden. A | |
|
|
||
| Nationale Verbindungen können online leider nicht erworben werden. | ||
|
|
||
| {{% booking id="sncf-connect" | ||
| subtitle="Nur für SNCF Mitarbeitende" | ||
| fip_global_fare=nil | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not "true"?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm I wasn't sure, but I thought the default way for the SNCF phone is "SNCF Voyagers" where they doesn't sell global prices for. We only enable this wenn adding this to the non default operator of the booking way -> Eurostar. Does this make sense :D If we enable it here, we have to disable it on all other pages. So I thought it would be simpler to just activate this on one page. Instead of disabling it on all others. :D |
||
| /%}} | ||
|
|
||
| {{% booking id="db-website-fip-db" | ||
| subtitle="Grenzüberschreitende FIP 50 Tickets für TGV/ICE und Regionalzüge zwischen Deutschland und Frankreich, mit Ticketanteil nur für den französischen Abschnitt. Nur für Mitarbeitende der Deutschen Bahn." | ||
| classes.first="nil" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.