Repository navigation
Allow explicit account authentication for room relays - #342
Merged
Merged
Conversation
TheCryptoDonkey
marked this pull request as ready for review
October 27, 2026 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An AUTH-only room relay could allow an account while refusing KithMoot messages signed by separate device keys. Android now offers Use signed-in account in Settings → Connections → Nostr relays, with confirmation of the exact URL and npub. The matching relay correction is deployed separately.
Permission is held in memory for the account session and foreground rooms. Sign-out, account replacement, process exit and removing/disabling the relay clear it. Stale approvals are refused. Existing consented Link authentication is preserved; anonymous rooms, discovery, account sync and background listeners gain no new permission. Includes Android 0.6.117/code 140 and main's public-VMLS network-policy fix.
Existing artwork-picker UI tests now wait for keyboard geometry before real taps, retaining their assertions. This addresses the two timing failures observed during qualification.
Validation: 594 protocol, 2,898 debug app and 2,887 release app tests; debug/release lint; debug/instrumentation and minified release builds; retained production certificate and preview lineage. Three consent tests passed in light and dark at 130% text. All ten picker, chat/share and consent tests passed together on a fresh emulator. The signed APK upgraded over 0.6.116, retained UID/first-install timestamp/synthetic data and launched. All 17 executed jobs passed on
c72c69e3in CI run 40433938974.The review pack is
docs/reviews/2026-10-26-relay-account-authentication.md. Signed build, source hashes, screenshots and upgrade evidence accompany the targeted release. No physical handset was touched; real Android/Linux peer delivery awaits the sender's trial.The targeted signed release uses exact source
c72c69e3. Camera PR #343 merged after this candidate was built and qualified; its additional changes are outside this APK.Published: signed 0.6.117 stable release. The public APK was downloaded without authentication and matched the tested SHA-256; publication and CI receipts are attached.
Shipped as stable/latest on GitHub and through both website hosts, the signed update feed and Zapstore. All public APK downloads and signatures/catalogue references were independently verified. Four fresh Chromium contexts passed, with 390px/1440px download cards reviewed. Final stable publication receipt. Sender delivery remains pending.