Repository navigation
spec(port): port specs/port/trinity/src/tri/faculty_types.t27 (Closes #10005) - #10142
Closed
dmitrii-f-t27 wants to merge 1 commit into
Closed
dmitrii-f-t27 wants to merge 1 commit into
dmitrii-f-t27 wants to merge 1 commit into
Conversation
…HashTag#10005) Port gHashTag/trinity:src/tri/faculty_types.zig (at ee512359254b, ~170 lines) as specs/port/trinity/src/tri/faculty_types.t27 - Roadmap Stage 5, goal gHashTag#4547, target t27c gen-rust. The one listed function is ported under the name the issue asks for, FacultySnapshot_activeFaculty (original line 123, activeFaculty method), and tested (3 tests, 3 pass, 0 vacuous, 6 runtime asserts, 100% function coverage): the active faculty is the count of the six seats whose status is up. Two honest notes: the original's FacultySnapshot carries agents: [6]AgentState - an array of structs this language's Verilog lowering does not implement (W469) - so the port's TrinityFacultySnapshot carries the six statuses as a scalar array of status codes (the up/down/stub/tbd enum as codes, the labels and colors are the caller's presentation); and the name FacultySnapshot is already defined by specs/tri/agent/faculty_board.t27, so the port's type is renamed TrinityFacultySnapshot - the function keeps the required name. All four generators (gen, gen-rust, gen-c, gen-verilog) emit this spec before the push. Verified: parse OK, spec-status IMPLEMENTED, typecheck 0 errors, coverage 1/1, test-report 3/3 pass, 0 BLOCKED, gen 56 lines with 0 'not yet implemented', boundary exactly this one file, dupe_scan: the function name is unique, bare scan reports zero error lines. Dmitrii Fedorov ([@dmitrii-f-t27](https://github.com/dmitrii-f-t27))
This was referenced Oct 18, 2026
Contributor
Author
|
@gHashTag Please merge this PR into master via the golden chain — rights on gHashTag/t27 are read-only for me (403), so only you can merge it. Verification of this head (7b388bb, on current master — no extra merge needed):
After the merge I will: verify the spec file live on the merge SHA, confirm #10005 auto-closed, and file the 14-step report. Dmitrii Fedorov (@dmitrii-f-t27) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port
gHashTag/trinity:src/tri/faculty_types.zig(atee512359254b, ~170 lines) asspecs/port/trinity/src/tri/faculty_types.t27— Roadmap Stage 5 (goal #4547), target t27c gen-rust. Closes #10005.The original holds the faculty board's shared types for the Trinity A2A dashboard; the one listed function is the snapshot's active-faculty count.
Per the issue's rule ("Port the decision, not the plumbing"), the one listed function is ported under the name the issue asks for —
FacultySnapshot_activeFaculty(original line 123, theactiveFacultymethod) — as a pure function with 3 tests (6 runtime asserts, 0 vacuous, 100% function coverage):up.Two honest notes, both also named in the commit and the report:
FacultySnapshotcarriesagents: [6]AgentState— an array of structs this language's Verilog lowering does not implement (W469) — so the port'sTrinityFacultySnapshotcarries the six statuses as a scalar array of status codes (the up/down/stub/tbd enum as codes; the labels, colors and emoji are the caller's presentation);FacultySnapshotis already defined byspecs/tri/agent/faculty_board.t27, so a second definition would create a conflicted type name — the port's type is renamedTrinityFacultySnapshot; the function keeps the required name.Verification (all run live from the worktree root, zig 0.16.0)
t27c parse: OK.t27c spec-status: IMPLEMENTED.t27c typecheck: 0 errors, 0 warnings.t27c coverage: 1/1 tested (100%) — no transports in this port.t27c test-report: 3 tests / 3 pass / 0 FAIL / 0 BLOCKED, 0 vacuous passes — all six up, none up (down/stub/tbd mixes), and three mixed-seat counts (3, 1, 5).gen(56 lines, 0 'not yet implemented'),gen-rust,gen-c,gen-verilog.grep -cE '^\s*(pub )?fn (FacultySnapshot_activeFaculty)\(': 1.grep -cE '^[[:space:]]*test[[:space:]]+("|[A-Za-z_])': 3 (≥ 1).git status --short— exactly this one file. The repo's lefthook pre-commit passed.dupe_scan: the function name is unique across the corpus (checked before the commit); the bare scan reports zero error lines — no new duplicate group, none grew.Dmitrii Fedorov (@dmitrii-f-t27)