Repository navigation
spec(ml): train_slice_model reuses file_io_contract byte_sum instead of a copy (Closes #10203) - #10205
Merged
Conversation
…of a copy (Closes #10203) byte_total in specs/ml/train_slice_model.t27 (added in #10186) was a line-for-line copy of byte_sum in specs/ml/file_io_contract.t27, which that spec already imports. duplicate-bodies has been red on master since. byte_sum is now pub and the copy is deleted; the two bodies were identical, so no checksum changes and no ledger bless is needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 18, 2026 04:16
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
duplicate-bodieshas been red on master since #10186.byte_totalinspecs/ml/train_slice_model.t27was a line-for-line copy ofbyte_suminspecs/ml/file_io_contract.t27, which that spec already imports (use ml::file_io_contract;).file_io_contract.t27:byte_sumis nowpub, like theput_u32/get_u32next to it.train_slice_model.t27:byte_totalis deleted and both call sites usebyte_sum.The two bodies were identical, so no checksum changes. The copy is removed rather than blessed into the ledger.
Verified on the Railway lab
python3 tools/dupe_scan.py: "ok: no new duplicate body". There are now 637 duplicates in 176 groups, down from 639 in 177.t27c check: 0 errors forfile_io_contract,train_slice_model, andhost_io_model(the other importer).t27c test-report:file_io_contract: 0 vacuous passes of 12, invariant proved.train_slice_model: 5 pass, 0 FAIL.host_io_model: 0 FAIL, 0 vacuous passes of 3.This unblocks
duplicate-bodieson every open PR, including #10201.Closes #10203
🤖 Generated with Claude Code