Skip to content

spec(ml): train_slice_model reuses file_io_contract byte_sum instead of a copy (Closes #10203) - #10205

Merged
gHashTag merged 1 commit into
masterfrom
fix/dupe-byte-sum
Oct 18, 2026
Merged

gHashTag merged 1 commit into
masterfrom
fix/dupe-byte-sum

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

What

duplicate-bodies has been red on master since #10186. byte_total in specs/ml/train_slice_model.t27 was a line-for-line copy of byte_sum in specs/ml/file_io_contract.t27, which that spec already imports (use ml::file_io_contract;).

  • file_io_contract.t27: byte_sum is now pub, like the put_u32 / get_u32 next to it.
  • train_slice_model.t27: byte_total is deleted and both call sites use byte_sum.

The two bodies were identical, so no checksum changes. The copy is removed rather than blessed into the ledger.

Verified on the Railway lab

  • python3 tools/dupe_scan.py: "ok: no new duplicate body". There are now 637 duplicates in 176 groups, down from 639 in 177.
  • t27c check: 0 errors for file_io_contract, train_slice_model, and host_io_model (the other importer).
  • t27c test-report:
    • file_io_contract: 0 vacuous passes of 12, invariant proved.
    • train_slice_model: 5 pass, 0 FAIL.
    • host_io_model: 0 FAIL, 0 vacuous passes of 3.

This unblocks duplicate-bodies on every open PR, including #10201.

Closes #10203

🤖 Generated with Claude Code

…of a copy (Closes #10203)

byte_total in specs/ml/train_slice_model.t27 (added in #10186) was a
line-for-line copy of byte_sum in specs/ml/file_io_contract.t27, which
that spec already imports. duplicate-bodies has been red on master since.
byte_sum is now pub and the copy is deleted; the two bodies were
identical, so no checksum changes and no ledger bless is needed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-18 04:20:21 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 48
PRs with All Checks Green 2
READY 0
FAILING 48
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 48 + 0 + 0 = 48, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=0f8c66b9ed0e != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

duplicate-bodies red on master: train_slice_model copies file_io_contract's byte_sum

1 participant