Repository navigation
spec(ml): train_slice_model -- reuse file_io_contract's byte_sum instead of a copy (Closes #10206) - #10207
Closed
gHashTag wants to merge 1 commit into
Closed
spec(ml): train_slice_model -- reuse file_io_contract's byte_sum instead of a copy (Closes #10206)#10207gHashTag wants to merge 1 commit into
gHashTag wants to merge 1 commit into
Conversation
…ead of a copy (Closes #10206) #10186 added byte_total to specs/ml/train_slice_model.t27, a body identical to the private byte_sum in specs/ml/file_io_contract.t27, which the spec already reaches through `use ml::file_io_contract`. The Duplicate Body Ratchet has been red on master since. byte_sum becomes pub; byte_total is deleted and its two callers call byte_sum. No ledger is blessed. Lab, master 94d2793 + this change: train_slice_model 5 tests, 0 FAIL, 0 vacuous; file_io_contract 0 of 12 vacuous; host_io_model 0 of 3 vacuous. The --backend ml binary exits 0 and writes the same 379-byte /tmp/t27_train_slice.bin, sha256 0dfdef22...cdbeb; with that path made a directory it exits 134. python3 tools/dupe_scan.py exits 0: "no new duplicate body, and none of the known groups grew". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing as a duplicate of #10205, which makes the same change (byte-identical diff) and was opened first. My lab run of this diff on master 94d2793 agrees with it: train_slice_model 5 tests, 0 FAIL, 0 vacuous; the --backend ml checkpoint is unchanged (379 bytes, sha256 0dfdef22...cdbeb); python3 tools/dupe_scan.py exits 0. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10206
Part of epic #10024 (cell 25). #10186 added
byte_totaltospecs/ml/train_slice_model.t27, and its body is the same as the privatebyte_suminspecs/ml/file_io_contract.t27. Because the spec already hasuse ml::file_io_contract, the copy is not needed, and the Duplicate Body Ratchet has been red on master since #10186 merged.Change
specs/ml/file_io_contract.t27:byte_sumis nowpub. Its body is unchanged.specs/ml/train_slice_model.t27:byte_totalis deleted, and its two callers (pack,check_image) now callbyte_sum.Evidence (Railway lab, master 94d2793 + this change)
t27c test-report specs/ml/train_slice_model.t27t27c test-report specs/ml/file_io_contract.t27t27c test-report specs/ml/host_io_model.t27(the other user of file_io_contract)--backend mlbinary/tmp/t27_train_slice.bin379 bytes, sha2560dfdef2200b3daa2930cb081f8fb4a58caf5677bae3f329ee23f0e2c328cdbeb, the same as before the changepython3 tools/dupe_scan.py🤖 Generated with Claude Code