Repository navigation
igla race: delete 290 vacuous wave-loop tests from ternary_mac and ternary_gemm, assert exact values instead (Closes #10377) - #10379
Merged
Conversation
…rnary_gemm, assert exact values instead (Closes #10377)
Contributor
gHashTag
enabled auto-merge (squash)
October 18, 2026 10:22
…res 1141, this PR lowers it by one; refs #10377) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
PR DashboardGenerated at: 2026-10-18 10:28:30 UTC
Summary
Seal Status
|
gHashTag
added a commit
that referenced
this pull request
Oct 18, 2026
…loses #10416) (#10445) * ratchet ledgers: refresh suite_expectations and t27b_expectations against master (Closes #10416) Corpus ratchet: drop the 7 pins whose specs now consume every token (bootrom_tb, low_bit_ternary, isa/registers, isa/ternary_memory, positional_enc, nn/gla, vsa/ops), cap 73 -> 66, re-pin the 4 improved discards, and re-pin igla/race/ternary_mac 1139 -> 1140 with its cause (spec rewrites #10375/#10379, parser unchanged). t27b native: add the 171 specs the reference passes that the ledger did not name (110 t27b pass, 61 blocked); max_not_pass 77 -> 138, the 61 new blocked entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * t27b ledger: re-bless at the rebased tip -- 3 now-passing, 2 moved blockers, 5 new specs; max_not_pass 138 -> 135 (Refs #10416) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10377
Follow-up to #10375. Deletes the wave-loop placeholders that cannot fail from the two RACE reference specs and replaces them with tests that assert exact values.
What changed
ternary_mac.t27: 146 placeholder tests removed (144 the ratchet counted, plus the twoassert(true)ones it does not see), with their pairedinvariant ..._depth: truelines and wave header comments. The wave tail was nothing but that boilerplate; the real tests and invariants are untouched.ternary_gemm.t27: 144 removed the same way (142 counted, plus twoassert(true)). The two real tests that sat at the end of the file (ternary_gemm_8x8_min_activations_do_not_wrap,..._4x4_...) are kept.ternary_mul_wide(127, +1) = 127;ternary_mac_wide(-50, 127, -1) = -177;ternary_mac_wide(0, -128, +1) = -128;ternary_mac_wide(128, -128, -1) = 256(two min negations leave i8).ternary_gemm_gpu.t27([5,3,7,2]against codes[2,1,1,2]gives[-2,2,-5,5]); a 2x2 case with zero weights ([-3,5,-2,7]); the 4x4 all-ones case (every element 4).tools/assertionless_spec_tests_baseline.txtre-blessed with--blessin the same commit: 20 files / 2464 declarations -> 18 files / 2178; both files are gone from it.t27c seal --saveon the lab (second commit, after the spec change).Measured on the lab
vacuous passes 0 of 199,0 of 129).t27c seal --verify: all hashes MATCH for both specs.tools/verify_igla_race.py --requireOK;tools/check_assertionless_spec_tests.pyOK.Everything ran on the Railway lab (t27c from master, t27b under qemu-aarch64); nothing was built or tested on the Mac. The change is
.t27plus tool-written data (seals, ratchet baseline).🤖 Generated with Claude Code