Repository navigation
compiler.rs: delete the tests calling the seven items #10896 removed (Closes #10957) - #10958
Merged
Merged
Conversation
…d, move the seal (Closes #10957) #10896 dropped Node::with_child, Parser::check_peek, icarus_lowerability_reason, align_address, reset_end_cycle, path_delay and worst_path_delay to keep the foreign-line budget net-negative, but eight test lines still called five of them, so the unit tests no longer compiled. Delete those tests; nothing else changes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
…_cores does not get the thread runtime appended (Closes #10957) #10896 appended the thread runtime to any Zig output that calls thread_spawn, thread_join or thread_cores, so compiler/runtime/runtime.t27 (which defines and calls its own thread_spawn) changed its gen_hash_zig and the triruntime and runtime_triruntime seals drifted (coverage red). Guard the detection with declared_fns, as the call rewrite already is. One line changed, none added. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
PR DashboardGenerated at: 2026-10-19 09:11:12 UTC
Summary
Seal Status
|
This was referenced Oct 19, 2026
gHashTag
enabled auto-merge (squash)
October 19, 2026 09:21
gHashTag
pushed a commit
to dmitrii-f-t27/t27
that referenced
this pull request
Oct 19, 2026
…ged compiler.rs (Closes gHashTag#5649, Closes gHashTag#5650, Closes gHashTag#5651) master's 027a0e2 (gHashTag#10958, dead tests removed from compiler.rs) moved compiler.rs, so FROZEN_HASH conflicted again; compiler.rs merged clean and FROZEN_HASH is t27c frozen-digest of the merged file. master changed no seals in these 2 commits. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gHashTag
pushed a commit
to dmitrii-f-t27/t27
that referenced
this pull request
Oct 19, 2026
…ee more dead compiler.rs methods and their tests (Closes gHashTag#5649, Closes gHashTag#5650, Closes gHashTag#5651) own-language's budget (owner rule 2026-10-09) failed the merged branch: compiler.rs was +25/-11 because master's gHashTag#10958 had already removed align_address, the dead function this PR used as its offset. rustc reports these never used outside tests: ArcKind::from_i8, RouteEstimate::passed (with test_route_passed and test_route_failed) and CtsReport::passed (with test_cts_report_passed). Removed with the tests that only exercise them. compiler.rs is now +25/-72 against master (net -47); check_budget passes. t27c builds from this tree; FROZEN_HASH is its frozen-digest. The test target cannot be compiled in my sandbox (a dev-dependency crate is not fetchable), so CI's build-and-test is the check for the removed tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10957
Two compiler.rs fixes for what #10896 left on master. Neither is built locally (no builds on the Mac); CI compiles and checks them.
thread_spawn,thread_joinorthread_cores.compiler/runtime/runtime.t27defines and calls its ownthread_spawn, so itsgen_hash_zigchanged and thetriruntimeandruntime_triruntimeseals drifted (the coverage check passes on every base before feat(ml): thread primitive + train_hslm windows on N threads, bit-identical at any count (#10876) #10896 and fails on 356e7ce). The detection is now guarded bydeclared_fns, as the call rewrite already is. One line changed, none added. The third red seal,t27f_T27fFrontend, is another PR's.The compiler.rs seal (
bootstrap/stage0/FROZEN_HASH) moves with the edits. Rust lines only go down or stay level.🤖 Generated with Claude Code