Repository navigation
ci(dupe-ratchet): record the seven widget-logic helper copies as deliberate (Closes #11013) - #11014
Merged
Merged
Conversation
…berate (Closes #11013) Master was red on duplicate-bodies since b92f6f1 (#10965): digits_val, ws_at, ws_back, ws_before, ws_fwd, ws_len_at and ws_len_before each exist twice across the widget logic ports (lut_explain/lut_treemap, fasm_skyline/stat_card/lut_depth). The earlier hex_digit copy named in the first brief was already removed by #10296. Each widget logic spec compiles to its own wasm module with module-level state, so a cross-module use is a design change that belongs to the widget epic (#10937), not to a red-master fix. The copies are recorded with python3 tools/dupe_scan.py --bless, run on the Railway lab: exactly seven lines added, dupe_scan exits 0 after, and a new duplicate still fails. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
October 19, 2026 11:32
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11013
Master is red on
duplicate-bodies(run 39243687990) for seven groups from #10965:digits_val,ws_at,ws_back,ws_before,ws_fwd,ws_len_at,ws_len_before, each copied twice across the widget logic specs. Thehex_digitcopy inrc_filter_ax7203.t27named in the first brief is already gone (#10296).Each widget logic spec is its own wasm module with module-level state, so sharing the helpers is a design change for the widget epic (#10937). This PR only records the copies:
python3 tools/dupe_scan.py --blesson the Railway lab, 7 lines added totools/duplicate_bodies_baseline.txt, nothing else.Checked on the lab at 882fcff: before the change
dupe_scan.pyexits 1 on exactly these seven groups, after it exits 0;--self-testpasses (11 shapes).rc_filter_ax7203tests: not re-run, the spec is untouched by this PR.🤖 Generated with Claude Code