Repository navigation
chore: daemon restart leaks raw "kill: ... No such process" noise for an already-expected race - #771
Merged
getappz merged 1 commit intoSep 18, 2026
Conversation
## Summary Fixed `src/ipc/process.rs` (`is_alive`, `terminate_gracefully`, `force_kill`): added `.stdout(Stdio::null()).stderr(Stdio::null())` to the three non-Windows `kill` `Command` invocations. Previously `Command::status()` inherited stderr, so a stale-PID `kill` (e.g. "No such process") leaked to the user's terminal even though every caller already discards the outcome (`let _ = ...`). Behavior of the returned `Result`/exit status is unchanged — only child stdio is now suppressed, matching the Windows branches which already went through `flare_process::command`. Verified: - `cargo build --lib` — clean. - `cargo test` (workspace) — all 1893 tests pass, including the 4 `ipc::process::tests::parse_other_pids_*` tests. - Manual repro: confirmed `kill -0` on a dead PID prints `kill: sending signal to <pid> failed: No such process` to stderr without the redirect, and prints nothing with the added `.stdout/.stderr(Stdio::null())` — exit status (`false`) unchanged. - `cargo clippy -p agentflare --lib` — clean for this crate (no warnings touching `ipc/process.rs`); a workspace-wide clippy run does hit pre-existing errors in unrelated `crates/agent-registry`, not caused by this change. No concerns. Agentflare-Branch: task/284-daemon-restart-leaks-raw-kill-no-such-pr Agentflare-Item: 284
|
Warning Review limit reachedNext included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Comment |
getappz
deleted the
task/284-daemon-restart-leaks-raw-kill-no-such-pr
branch
September 18, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No hits — confirms zero clippy findings in
src/ipc/process.rs.Summary
Fixed
src/ipc/process.rs(is_alive,terminate_gracefully,force_kill): added.stdout(Stdio::null()).stderr(Stdio::null())to the three non-WindowskillCommandinvocations. PreviouslyCommand::status()inherited stderr, so a stale-PIDkill(e.g. "No such process") leaked to the user's terminal even though every caller already discards the outcome (let _ = ...). Behavior of the returnedResult/exit status is unchanged — only child stdio is now suppressed, matching the Windows branches which already went throughflare_process::command.Verified:
cargo build --lib— clean.cargo test(workspace) — all 1893 tests pass, including the 4ipc::process::tests::parse_other_pids_*tests.kill -0on a dead PID printskill: sending signal to <pid> failed: No such processto stderr without the redirect, and prints nothing with the added.stdout/.stderr(Stdio::null())— exit status (false) unchanged.cargo clippy -p agentflare --lib— clean for this crate (no warnings touchingipc/process.rs); a workspace-wide clippy run does hit pre-existing errors in unrelatedcrates/agent-registry, not caused by this change.No concerns.
Opened by
claude-codeon flared:51bb8de6c33b for item #284 via agentflare.