Skip to content

Clarify Overview Value claims and verify Value query parity - #20353

Merged
mnkiefer merged 4 commits into
mainfrom
fix/value-view-evidence-parity-20261107
Nov 7, 2026
Merged

mnkiefer merged 4 commits into
mainfrom
fix/value-view-evidence-parity-20261107

Conversation

@mnkiefer

@mnkiefer mnkiefer commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Label the Overview counter and heading as grader observations rather than verified repository Value; keep the existing internal station identifier for compatibility and refresh its immediate-dashboard audit fingerprint.
  • Add browser IndexedDB / local SQLite parity coverage for the authored Value inventory, collection health, report, and snapshot views, plus hosted PostgreSQL execution and clock/review-state assertions using real SQL.
  • Document how to verify publication separately for Pages and hosted PostgreSQL without conflating collection decisions with accepted evidence or enabling collector authority.

Validation

  • Dashboard unit suite: 407 files passed (3,985 tests passed, 1 skipped).
  • Focused desktop/mobile Overview and Value Playwright tests: 5 passed; additional affected canonical-data browser suite: 31 passed.
  • Hosted Value tests passed against an isolated PostgreSQL 16 instance; fixture-backed Pages build served and rendered in Chromium with the expected unavailable Value state and revised Overview labels.
  • Dashboard lint/typecheck and documentation build passed; git diff --check clean.

Limits

  • No new measurement, collector registration, or production rollout: an exact target workflow/repository and reviewed deployment authority were not supplied. Neither live Pages freshness nor production publication was verified.
  • npm run compile could not run because gh-aw is missing and its extension install is blocked by organization SAML authorization. Lighthouse could not fetch the published Pages dataset because that host did not resolve. A broader desktop browser run previously had unrelated failures outside the changed Value/Overview flows.

Screenshots of the populated local Pages fixture (desktop and mobile) are attached in a PR comment; they do not represent a production deployment.

@mnkiefer
mnkiefer requested a review from pelikhan as a code owner November 7, 2026 09:27
@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor
Dashboard dead views

Dead element views (0):
Dead dashboard pages (0):
Analyzed 8 element renderers and 74 dashboard pages across 1 dashboard.json file(s) from dashboard/site/src/components/ui-elements.js.

⚠️ This reachability report is informational and does not block the pull request.
🔎 View the workflow run and report artifact.

@mnkiefer

mnkiefer commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Fix failing checks and simulate sample data or wait for real data to load before take the snapshots.

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@copilot Fix failing checks and simulate sample data or wait for real data to load before take the snapshots.

Updated in ac655ca: the parity test now honors one bounded Retry-After for HTTP 429. Desktop/mobile Overview snapshots were recaptured from the fixture-backed E2E after its populated-data assertions passed (1440×900 and 390×929); they are synthetic, not production. The Overview E2E passed (3 tests). I couldn't rerun the PostgreSQL/Redis parity job locally because those services and the server binary aren't available here.

@mnkiefer

mnkiefer commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Fix failing checks

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@copilot Fix failing checks

Fixed in 03dab08. Workflow logs showed the catalog JSON was stale and the Dashboard Language spec exceeded the 256 KiB file-size limit by 73 bytes. Regenerated the catalog artifacts and reduced the spec below the limit. The focused catalog tests pass (36/36), and the file-size check passes. The latest PR workflow is marked action_required with no jobs, so it hasn’t run on this commit yet.

@mnkiefer
mnkiefer merged commit caf079a into main Nov 7, 2026
46 checks passed
@mnkiefer
mnkiefer deleted the fix/value-view-evidence-parity-20261107 branch November 7, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants