Skip to content

fix(google-crc32c) license formatting in pyproject.toml - #18950

Closed
APN-Pucky wants to merge 1 commit into
googleapis:mainfrom
APN-Pucky:patch-1
Closed

fix(google-crc32c) license formatting in pyproject.toml#18950
APN-Pucky wants to merge 1 commit into
googleapis:mainfrom
APN-Pucky:patch-1

Conversation

@APN-Pucky

@APN-Pucky APN-Pucky commented Nov 2, 2026

Copy link
Copy Markdown

Gentoo QA complains:

 * QA Notice: setuptools warnings detected:
 * 
 * 	`extras_require` overwritten in `pyproject.toml` (optional-dependencies)
 * 	`project.license` as a TOML table is deprecated

@APN-Pucky
APN-Pucky requested a review from a team as a code owner November 2, 2026 13:41
@google-cla

google-cla Bot commented Nov 2, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@APN-Pucky APN-Pucky changed the title Fix license formatting in pyproject.toml Fix license formatting in google-crc32c's pyproject.toml Nov 2, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 2, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the license field format in pyproject.toml from an inline table to a simple string. There are no review comments, and I have no additional feedback to provide.

@parthea

parthea commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Hi @APN-Pucky, Thanks for the fix! Please can you sign the CLA? See #18950 (comment)

@parthea
parthea marked this pull request as draft November 3, 2026 15:26
@APN-Pucky APN-Pucky changed the title Fix license formatting in google-crc32c's pyproject.toml fix(google-crc32c') license formatting in pyproject.toml Nov 3, 2026
@APN-Pucky APN-Pucky changed the title fix(google-crc32c') license formatting in pyproject.toml fix(google-crc32c) license formatting in pyproject.toml Nov 3, 2026
@APN-Pucky APN-Pucky closed this Nov 3, 2026
@APN-Pucky

APN-Pucky commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

whoops, git clone --depth 1 + git --amend squashed the whole repo...

@APN-Pucky APN-Pucky mentioned this pull request Nov 3, 2026
Open
@APN-Pucky

APN-Pucky commented Nov 3, 2026

Copy link
Copy Markdown
Author

Hi @APN-Pucky, Thanks for the fix! Please can you sign the CLA? See #18950 (comment)

I signed it and repoend this PR here #18967 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@APN-Pucky @parthea