Skip to content

fix(google-crc32c): license formatting in pyproject.toml - #18967

Open
APN-Pucky wants to merge 1 commit into
googleapis:mainfrom
APN-Pucky:patch-1
Open

fix(google-crc32c): license formatting in pyproject.toml#18967
APN-Pucky wants to merge 1 commit into
googleapis:mainfrom
APN-Pucky:patch-1

Conversation

@APN-Pucky

@APN-Pucky APN-Pucky commented Nov 3, 2026

Copy link
Copy Markdown

Gentoo QA complains:

 * QA Notice: setuptools warnings detected:
 * 
 * 	`extras_require` overwritten in `pyproject.toml` (optional-dependencies)
 * 	`project.license` as a TOML table is deprecated

Duplicate of #18950 that got automatically closed after I git cloned my patch with depth 1 and tried to amend the commit, resulting in squashing the whole repo...

@APN-Pucky
APN-Pucky requested a review from a team as a code owner November 3, 2026 16:09
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 3, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the license field format in pyproject.toml from a table to a simple string. I have no feedback to provide.

@APN-Pucky APN-Pucky mentioned this pull request Nov 3, 2026
Closed
parthea
parthea approved these changes Nov 3, 2026
View reviewed changes

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @APN-Pucky!

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2026
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2026
@parthea parthea mentioned this pull request Nov 3, 2026
Draft

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes
@ohmayr ohmayr ohmayr approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@APN-Pucky @parthea @ohmayr @yoshi-kokoro