[parthea]

This PR is needed to unblock #18967 where the windows build is failing with

ERROR: Exception:
Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\site-packages\pip\_internal\cli\base_command.py", line 110, in _run_wrapper
    status = _inner_run()
  File "C:\Program Files\Python310\lib\site-packages\pip\_internal\cli\base_command.py", line 103, in _inner_run
    return self.run(options, args)
  File "C:\Program Files\Python310\lib\site-packages\pip\_internal\cli\req_command.py", line 162, in wrapper
    return func(self, options, args)
  File "C:\Program Files\Python310\lib\site-packages\pip\_internal\commands\install.py", line 729, in run
    _eagerly_import_modules(module_names)
  File "C:\Program Files\Python310\lib\site-packages\pip\_internal\commands\install.py", line 176, in _eagerly_import_modules
    __import__(module)
  File "C:\Program Files\Python310\lib\site-packages\readline.py", line 34, in <module>
    rl = Readline()
  File "C:\Program Files\Python310\lib\site-packages\pyreadline\rlmain.py", line 422, in __init__
    BaseReadline.__init__(self)
  File "C:\Program Files\Python310\lib\site-packages\pyreadline\rlmain.py", line 62, in __init__
    mode.init_editing_mode(None)
  File "C:\Program Files\Python310\lib\site-packages\pyreadline\modes\emacs.py", line 633, in init_editing_mode
    self._bind_key('space',       self.self_insert)
  File "C:\Program Files\Python310\lib\site-packages\pyreadline\modes\basemode.py", line 162, in _bind_key
    if not callable(func):
  File "C:\Program Files\Python310\lib\site-packages\pyreadline\py3k_compat.py", line 8, in callable
    return isinstance(x, collections.Callable)
AttributeError: module 'collections' has no attribute 'Callable'

I filed #18972 for the follow up issue to audit builds that are still using Python 3.10 and upgrade them

[gemini-code-assist]

Code Review

This pull request moves the uninstallation of 'pyreadline' from the Windows test script ('test.bat') to the build script ('build.bat'). Feedback suggests that removing this step from 'test.bat' could break test execution if the build and test phases are run in separate environments or CI jobs, recommending that the uninstallation step be retained in the test script for robustness.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/google-crc32c/scripts/windows/test.bat (28-30)

Removing the 'pyreadline' uninstallation from 'test.bat' can break the test execution if 'test.bat' is run in a separate environment or CI job from 'build.bat' (which is a common pattern in CI/CD pipelines to separate build and test phases, or when testing pre-built wheels locally).\n\nTo ensure robustness and standalone usability of the test script, we should retain the 'pyreadline' uninstallation step in 'test.bat' as well.

@rem pyreadline is removed here because pytest will opportunistically use it if\n@rem available, but the installed version is too old to work.\npy -%PYTHON_VERSION%-64 -m pip uninstall -y pyreadline