Skip to content

ci(google-crc32c): fix windows build #18971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
parthea wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci(google-crc32c): fix windows build #18971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/google-crc32c/scripts/windows/build.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ FOR %%P IN (%SUPPORTED_PYTHON_VERSIONS%) DO (

echo "Listing available Python versions"
py -0

@rem pyreadline is removed here because pip>=26.3 and pytest will opportunistically
@rem use it if available, but the pre-installed version is too old to work.
py -!python_version_trimmed!-64 -m pip uninstall -y pyreadline || goto :error
py -!python_version_trimmed!-64 -m pip install --upgrade pip || goto :error

echo "Installing cmake for Python %%P"
Expand Down
3 changes: 0 additions & 3 deletions packages/google-crc32c/scripts/windows/test.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,5 @@ py -%PYTHON_VERSION%-64 -m pip install --no-index --find-links=wheels google-crc

py -%PYTHON_VERSION%-64 ./scripts/check_crc32c_extension.py

@rem pyreadline is removed here because pytest will opportunistically use it if
@rem available, but the installed version is too old to work.
py -%PYTHON_VERSION%-64 -m pip uninstall -y pyreadline
py -%PYTHON_VERSION%-64 -m pip install pytest
py -%PYTHON_VERSION%-64 -m pytest tests --junitxml=%PYTHON_VERSION%_sponge_log.xml
Loading