Repository navigation
chore: split UloopPausePointRegistry co-located types into class-per-file - #1654
Conversation
UloopPausePointRegistry.cs mixed the registry facade with 8 other top-level types (snapshot, entry, pause controller, DTOs, status constants) in one 525-line file. Move each type to its own file, byte-equal, keeping the registry's mutable static state at its original path so no test tracking needs updating.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughExtracts pause-point supporting types previously embedded in UloopPausePointRegistry.cs into separate editor-only files: IUloopPausePointPauseController, UloopPausePointEditorStateCapturedAt, UloopPausePointEditorStateSnapshot, UloopPausePointEntry, UloopPausePointSnapshot, UloopPausePointClearAllResult, UloopPausePointStatus, and UnityEditorPausePointPauseController. The registry file is stripped of these definitions. ChangesPause-point type extraction
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Refs: R3-6 in Unity CLI Loop refactor round 3 ToDo
Summary
UloopPausePointRegistry.cs(525 lines) mixed the registry facade with 8 other top-level types:UloopPausePointEditorStateCapturedAt,UloopPausePointEditorStateSnapshot,IUloopPausePointPauseController,UnityEditorPausePointPauseController,UloopPausePointSnapshot,UloopPausePointClearAllResult,UloopPausePointEntry,UloopPausePointStatus.#if UNITY_EDITOR ... #endifguard on every new file (required since this is a Runtime asmdef andUnityEditorPausePointPauseControllerreferencesUnityEditor.EditorApplication).StaticFacadeStateGuardTeststracking update is needed.Verification
usingstatement redistribution across files, no line lost or added).PausePointTests(Editor): 25/25 passed.