Repository navigation
feat: report which captured variables were truncated in pause point responses - #2052
Conversation
…esponses CapturedVariablesTruncated alone stayed sticky after name filters whenever any value was clipped, so count-cap drops were invisible. Expose per-variable Truncated plus TruncatedVariableNames/Count, and surface a Warning when a name filter matches nothing. Co-authored-by: Cursor <cursoragent@cursor.com>
First-party schema properties must not carry DescriptionAttribute; long-form guidance belongs in skill files (FirstPartyToolSchemaMetadataTests). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (20)
📝 WalkthroughWalkthroughPause-point capture now records discarded-variable names and counts, propagates per-variable truncation flags through runtime and API models, and exposes the metadata to CLI consumers. Collection continues scanning after the capture cap, while CLI filtering suppresses misleading warnings for empty snapshots. ChangesPause-point truncation metadata
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant SourcePausePointVariableCollector
participant UloopPausePointRegistry
participant UloopPausePointEntry
participant PausePointStatusResponse
participant CLI
SourcePausePointVariableCollector->>UloopPausePointRegistry: capture entries and truncation metadata
UloopPausePointRegistry->>UloopPausePointEntry: record captured variables and discarded-variable details
UloopPausePointEntry->>PausePointStatusResponse: expose snapshot metadata
PausePointStatusResponse->>CLI: serialize truncated names, count, and per-variable flags
CLI->>CLI: filter names and conditionally emit warning
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pause-point-status applies the filter without a hit gate, so an unhit marker looked like a name miss and the Warning blamed ResolvedMethod. Keep the machine-readable flags unchanged; warn only when the snapshot already had variables, and drop the ResolvedMethod reference. Co-authored-by: Cursor <cursoragent@cursor.com>
b5e8f83
into
feat/pause-point-feedback-r13-integration
Summary
Truncated, plus top-levelTruncatedVariableNames/TruncatedVariableCountfor variables dropped by the capture count cap (names capped at 20; count is exact).CapturedVariablesTruncatedmeaning is unchanged (any truncation during capture).Warning(alongside the existing machine-readable filter flags).[Description]fromCompileWaitTimeoutSecondssoFirstPartyToolSchemaMetadataTestsstays green (long-form guidance belongs in skill files).User Impact
Agents can see which captured values were clipped and which names the count cap discarded, instead of a sticky overall truncated flag after name filters. A zero-match name filter also surfaces a readable Warning so it is harder to misread as a broken capture.
Test plan
ULOOP_PROJECT_RUNNER_PATH=dist/darwin-arm64/uloop-project-runner uloop compile— 0 errors / 0 warningsscripts/check-go-cli.sh— exit 0 (includes new name-filter Warning test)Notes
Child PR targeting
feat/pause-point-feedback-r13-integration(round 13–14 feedback series, PR-3).