Skip to content

Add Helium browser support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliv5r wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Helium browser support #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ At the moment, `browser-launcher` supports following browsers on Windows, Unix a
- IE (Windows only)
- Chromium-based Edge
- Brave
- Helium
- Opera
- Safari (Mac only)
- PhantomJS
Expand Down
7 changes: 7 additions & 0 deletions src/browsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ const browserDefinitions: BrowserDefinitions = {
'brave-nightly': ['brave-browser-nightly', 'brave-nightly']
}
},
helium: {
regex: /Helium (\S+)/,
profile: true,
variants: {
'helium': ['helium', 'helium-browser']
}
},
opera: {
regex: /Opera (\S+)/,
profile: true,
Expand Down
1 change: 1 addition & 0 deletions src/darwin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const darwinBrowsers: { [name: string]: DarwinBrowser } = {
'brave-beta': browser('com.brave.Browser.beta', 'CFBundleVersion'),
'brave-dev': browser('com.brave.Browser.dev', 'CFBundleVersion'),
'brave-nightly': browser('com.brave.Browser.nightly', 'CFBundleVersion'),
helium: browser('net.imput.helium', 'CFBundleShortVersionString'),
arc: browser('company.thebrowser.Browser', 'CFBundleVersion')
};

Expand Down
3 changes: 2 additions & 1 deletion src/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,10 @@ setups.chrome = async function (browser: Browser, options: LaunchOptions): Promi
};
setups.chromium = setups.chrome;

// Brave, new MS Edge & Arc are all Chromium based, treated as identical:
// Brave, Helium, new MS Edge & Arc are all Chromium based, treated as identical:
setups.msedge = setups.chrome;
setups.brave = setups.chrome;
setups.helium = setups.chrome;
setups.arc = setups.chrome;

/**
Expand Down
2 changes: 1 addition & 1 deletion test/integration.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('Browser Launcher Integration Tests', function() {

it('should return valid browser types', async function() {
const validTypes = ['chrome', 'chromium', 'firefox', 'safari', 'ie',
'msedge', 'brave', 'opera', 'phantomjs', 'arc'];
'msedge', 'brave', 'helium', 'opera', 'phantomjs', 'arc'];

const browsers = await detectBrowsers();
browsers.forEach(function(browser) {
Expand Down
Loading