Repository navigation
Add slither job to Security Scan workflow; use latest Node LTS in CI - #462
Merged
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
OBrezhniev
force-pushed
the
ci/slither-scan
branch
from
September 29, 2026 16:44
d8762a4 to
ab8abec
Compare
Runs slither 0.11.6 with the repo slither.config.json and uploads the results to GitHub Code Scanning as SARIF. The job does not fail on findings: current High results are triaged false positives and are meant to be dismissed in Code Scanning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OBrezhniev
force-pushed
the
ci/slither-scan
branch
from
September 30, 2026 11:57
ab8abec to
c9b68b4
Compare
Replace pinned Node 24.12.0 / 24 with lts/* in all workflows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
npm 11.19 (Node 24.21, current lts/*) makes `npm ci` fail with "Missing: bufferutil@4.1.0 from lock file". bufferutil is an optional peer dependency of ws. Add only its lock entry; no other package versions change, and npm 11.6 (Node 24.12) still accepts the lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
npm audit: 47 (1 critical, 10 high, 19 moderate, 17 low) -> 22 low. - npm audit fix for transitive packages (tar, adm-zip, brace-expansion, fast-uri, form-data, ip-address, js-yaml, esbuild, ...) - overrides: - axios 1.16.1 -> 1.20.0 (kept as an exact pin) - ws ^8 -> ^8.21.0 (ethers, @ethersproject/providers) - ajv ^8 -> ^8.18.0 - jayson -> ^5.0.0 (drops vulnerable uuid 8 and stream-json 1) - @0xpolygonid/js-sdk > uuid -> ^13.0.2 - @digitalbazaar/http-client > undici -> ^6.28.1 Remaining 22 low findings are all GHSA-848j-6mx2-7j84 in elliptic (<=6.6.1, no patched release), pulled in via @ethersproject/*. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
daveroga
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
slitherjob to.github/workflows/security-ci.yml, alongside solhint and coverage.npm ci, thenslither-analyzer==0.11.6via pip.slither . --sarif results.sarif --fail-noneusing the repo's existingslither.config.json.slither). Permissions:contents: read,security-events: write.Why it doesn't fail on findings
Slither currently reports 54 High results on master (51
incorrect-returnin the snarkjs-generated Groth16 verifiers, 2arbitrary-send-ethin the payment_withdrawfunctions, 1encode-packed-collisionin VerifierLib). All of them have been triaged. Gating the job on them would make it red from the start. With SARIF upload, each false positive is dismissed once in Code Scanning and only new alerts need attention. Once that backlog is cleared, we can switch the job to fail on High findings (--fail-high).Before merging
Code Scanning must be enabled for this repo (Settings → Code security). Otherwise the upload step fails.
Testing
Ran the same command locally on master: exit 0, valid SARIF 2.1.0 with 971 results. This PR's CI run is the first time the workflow runs on GitHub.
Node version
All workflows (Tests, Security Scan, npm publish) now use
node-version: "lts/*"instead of pinning 24.12.0, so CI always runs on the latest Node LTS. Note: this includes the npm publish job, and it will move to the next LTS line automatically when one is released.package-lock.json
The current LTS (Node 24.21 / npm 11.19) makes
npm cifail withMissing: bufferutil@4.1.0 from lock file.bufferutilis an optional peer dependency ofws. This PR adds only that lock entry: no other package versions change, and npm 11.6 (Node 24.12) still accepts the lock.🤖 Generated with Claude Code