Skip to content

1089 always avail alt df - #257

Open
munoztd0 wants to merge 12 commits into
mainfrom
1089_always_avail_alt_df
Open

munoztd0 wants to merge 12 commits into
mainfrom
1089_always_avail_alt_df

Conversation

@munoztd0

Copy link
Copy Markdown
Collaborator

No description provided.

gmbecker and others added 4 commits September 23, 2026 11:57
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files  274 suites   14m 21s ⏱️
411 tests 411 ✅ 0 💤 0 ❌
687 runs  687 ✅ 0 💤 0 ❌

Results for commit 3dbaca4.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $14.33$ $-1.51$ $0$ $0$ $0$ $0$
table_aet04 💚 $13.40$ $-1.38$ $0$ $0$ $0$ $0$
table_ent 💚 $15.29$ $-1.90$ $0$ $0$ $0$ $0$
table_lbt14 💚 $35.11$ $-1.72$ $0$ $0$ $0$ $0$
tsfae02a 💚 $10.32$ $-1.33$ $0$ $0$ $0$ $0$
tsfae03a 💚 $9.00$ $-1.00$ $0$ $0$ $0$ $0$
tsfae06b 💚 $20.19$ $-1.84$ $0$ $0$ $0$ $0$
tsfae16part1 💚 $11.46$ $-1.17$ $0$ $0$ $0$ $0$
tsfae21apart1 💚 $8.87$ $-1.08$ $0$ $0$ $0$ $0$
tsfae21bpart1 💚 $11.57$ $-1.19$ $0$ $0$ $0$ $0$
tsfae21bpart2 💚 $11.75$ $-1.15$ $0$ $0$ $0$ $0$
tsfae21bpart3 💚 $11.91$ $-1.30$ $0$ $0$ $0$ $0$
tsfae21bpart4 💚 $11.97$ $-1.02$ $0$ $0$ $0$ $0$
tsfae22apart1 💚 $10.54$ $-1.11$ $0$ $0$ $0$ $0$
tsfae22apart2 💚 $10.89$ $-1.09$ $0$ $0$ $0$ $0$
tsfae22apart3 💚 $10.22$ $-1.06$ $0$ $0$ $0$ $0$
tsfae22apart4 💚 $10.41$ $-1.07$ $0$ $0$ $0$ $0$
tsfae22cpart2 💚 $9.17$ $-1.11$ $0$ $0$ $0$ $0$
tsfae24fpart1 💚 $13.22$ $-1.66$ $0$ $0$ $0$ $0$
tsfae24fpart2 💚 $12.85$ $-1.42$ $0$ $0$ $0$ $0$
tsfae24fpart3 💚 $12.99$ $-1.26$ $0$ $0$ $0$ $0$
tsflab01apart1 💚 $15.38$ $-1.66$ $0$ $0$ $0$ $0$
tsflab01apart2 💚 $15.64$ $-1.70$ $0$ $0$ $0$ $0$
tsflab01apart3 💚 $15.58$ $-1.72$ $0$ $0$ $0$ $0$
tsflab01part1 💚 $6.68$ $-1.05$ $0$ $0$ $0$ $0$
tsflab01part2 💚 $6.64$ $-1.04$ $0$ $0$ $0$ $0$
tsids02a 💚 $8.73$ $-1.13$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tsfae02a 💚 $10.32$ $-1.33$ tsfae02a
tsfae03a 💚 $9.00$ $-1.00$ tsfae03a
tsfae06b 💚 $20.19$ $-1.84$ tsfae06b
tsfae16part1 💚 $11.46$ $-1.17$ tsfae16part1of2
tsfae21apart1 💚 $8.87$ $-1.08$ tsfae21apart1of4
tsfae21bpart1 💚 $11.57$ $-1.19$ tsfae21bpart1of4
tsfae21bpart2 💚 $11.75$ $-1.15$ tsfae21bpart2of4
tsfae21bpart3 💚 $11.91$ $-1.30$ tsfae21bpart3of4
tsfae21bpart4 💚 $11.97$ $-1.02$ tsfae21bpart4of4
tsfae22apart1 💚 $10.54$ $-1.11$ tsfae22apart1of4
tsfae22apart2 💚 $10.89$ $-1.09$ tsfae22apart2of4
tsfae22apart3 💚 $10.22$ $-1.06$ tsfae22apart3of4
tsfae22apart4 💚 $10.41$ $-1.07$ tsfae22apart4of4
tsfae22cpart2 💚 $9.17$ $-1.11$ tsfae22cpart2of4
tsfae24fpart1 💚 $13.22$ $-1.66$ tsfae24fpart1of3
tsfae24fpart2 💚 $12.85$ $-1.42$ tsfae24fpart2of3
tsfae24fpart3 💚 $12.99$ $-1.26$ tsfae24fpart3of3
tsflab01apart1 💚 $15.38$ $-1.66$ tsflab01a
tsflab01apart2 💚 $15.64$ $-1.70$ tsflab01a
tsflab01apart3 💚 $15.58$ $-1.72$ tsflab01a
tsflab01part1 💚 $6.68$ $-1.05$ tsflab01
tsflab01part2 💚 $6.64$ $-1.04$ tsflab01
tsids02a 💚 $8.73$ $-1.13$ tsids02a

Results for commit df99023

♻️ This comment has been updated with latest results.

@shajoezhu

Copy link
Copy Markdown
Contributor

hi @gmbecker @munoztd0 , please check the rtable PR. thanks

@munoztd0

munoztd0 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator Author

hi @gmbecker @munoztd0 , please check the rtable PR. thanks

Need to be updated pharmaverseadamjnj in remotes main since new release of pharmaverseadamjnj 0.0.7 on CRAN is breaking the snapshot (expected), snapshot changes will be updated in the coming weeks

@munoztd0
munoztd0 force-pushed the 1089_always_avail_alt_df branch from d7d03c1 to 19e74a2 Compare September 28, 2026 15:47
@shajoezhu

Copy link
Copy Markdown
Contributor

hi @munoztd0 and @gmbecker , could you double check, the main was ok, https://github.com/insightsengineering/scda.test/pull/256/changes, can you make sure pharmaverse/rtables#1102 passes, and we can prepare for release for rtables. thanks

@munoztd0
munoztd0 force-pushed the 1089_always_avail_alt_df branch from 19e74a2 to 64e7de4 Compare September 29, 2026 13:31
@munoztd0
munoztd0 force-pushed the 1089_always_avail_alt_df branch from 64e7de4 to 65d7da0 Compare September 29, 2026 14:40
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
@munoztd0

Copy link
Copy Markdown
Collaborator Author

hi @munoztd0 and @gmbecker , could you double check, the main was ok, https://github.com/insightsengineering/scda.test/pull/256/changes, can you make sure pharmaverse/rtables#1102 passes, and we can prepare for release for rtables. thanks

OK we discussed and validated the new snapshot which is a correction of an error that should not have been accepted in the previous snapshot, now this revert back to a good test case

@gmbecker

Copy link
Copy Markdown
Collaborator

@shajoezhu as @munoztd0 says, the "breakage" is actually correct. In point of fact, it reflects the exact buggy behavior that this change is designed to protect against. Please consider this passing and merge this PR

Comment on lines -251 to -252
\pard\intbl\qc\fs18 0.0 (0.0, 0.0) \cell
\pard\intbl\qc\fs18 0.0 (0.0, 0.0) \cell

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note. this is actual results changing.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and thus we need to add it to scda.test now

Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
…lt_df

Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
@munoztd0
munoztd0 requested a review from shajoezhu September 30, 2026 15:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants