1089 always avail alt df

[gmbecker]

No description provided.

[gmbecker]

fixes #1089

[github-actions]

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               900      69  92.33%   20, 72-76, 138, 141, 472, 563-564, 567, 729, 835, 962-963, 1065, 1068, 1070-1071, 1089-1092, 1112, 1227-1230, 1328-1333, 1496, 1597-1600, 1723-1726, 1763-1766, 1772-1777, 1837, 1844, 1963, 1966, 2078, 2145, 2148-2151, 2154-2157, 2187, 2220-2221
R/as_html.R                    172      25  85.47%   5-10, 80, 152-157, 162-167, 182-186, 273
R/colby_constructors.R         564      33  94.15%   163, 179, 1034-1038, 1040-1044, 1118-1126, 1147, 1238, 1399, 1465, 1476, 1484, 1487, 1512, 1533, 1679, 1910-1913
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 156-157, 188, 193
R/custom_split_funs.R          265      40  84.91%   127, 132, 138-143, 156, 173-177, 353-358, 375-380, 456, 502, 518-521, 537, 599, 609-610, 612, 624, 668, 693
R/default_split_funs.R         287      22  92.33%   272, 335-338, 349-350, 352, 354, 551-555, 619-622, 685-688
R/format_rcell.R                17       1  94.12%   47
R/indent.R                      13       2  84.62%   40-41
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             166      30  81.93%   22-26, 36-39, 52-55, 58-61, 115, 119, 267, 270-273, 278-281, 366, 375, 377, 379, 430
R/make_subset_expr.R           137      14  89.78%   77-92, 169-177, 213, 302, 306, 315
R/nesting_impl.R               330      34  89.70%   73, 105, 118, 170-192, 210, 237, 335-339, 507-516, 561
R/summary.R                    144      38  73.61%   35, 80, 178-220, 269, 315-331, 366, 397
R/tree_accessors.R            1265     142  88.77%   110, 139-140, 210, 233, 263, 281, 300-304, 324, 346-349, 476, 503-504, 658, 795-801, 948, 967, 993, 1045, 1121-1122, 1167, 1202, 1240-1245, 1304, 1378-1382, 1400-1409, 1487, 1635, 1657-1658, 1668, 1719, 1740-1745, 1766-1771, 1907, 1948, 2047, 2154, 2167, 2181, 2197, 2206, 2216-2220, 2270-2275, 2478, 2488-2491, 2501, 2526-2529, 2536, 2538-2541, 2663, 2697-2698, 2755, 3059, 3429, 3545, 3579-3604, 3695-3703, 3868, 3942-3948, 4253, 4377, 4462-4467, 4473, 4497-4502, 4550, 4575-4599, 4628-4634
R/tt_afun_utils.R              419      33  92.12%   60, 182, 189, 198-212, 280, 288-289, 507, 515-518, 600-604, 624, 638-640
R/tt_as_df.R                   400      23  94.25%   101-104, 112, 150, 224-227, 369, 388, 458, 477-480, 489, 599, 605, 637, 655, 707
R/tt_compare_tables.R           72       4  94.44%   51, 174, 249, 253
R/tt_compatibility.R           574      70  87.80%   22, 149-150, 193, 198, 329-330, 334-337, 343, 347, 531, 585-588, 625-627, 665, 698, 718, 738-741, 751-754, 799, 816-820, 826-829, 903, 930-933, 942, 1004, 1012, 1023-1026, 1137, 1144, 1172-1186, 1217-1218
R/tt_dotabulation.R           1324     135  89.80%   56, 262, 267, 269, 318, 343, 347-350, 383-386, 409, 442-445, 473-476, 605-606, 674, 861-865, 951, 955, 983-986, 996, 1016-1020, 1027-1030, 1231-1260, 1328, 1332, 1363, 1467-1470, 1681-1689, 1962-1971, 1982-1984, 1999-2008, 2041, 2069-2072, 2083, 2088, 2093-2094, 2096, 2107, 2112, 2135, 2221-2240
R/tt_export.R                   13       1  92.31%   45
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                535      40  92.52%   74, 122-131, 242, 341-342, 494, 629-632, 653-657, 802-805, 856-863, 940, 943, 961, 968, 971
R/tt_pos_and_access.R          656      32  95.12%   76, 78-80, 105, 166, 262, 329, 512, 516, 724, 726, 734, 740, 754, 764-767, 990, 1007-1010, 1037, 1096-1097, 1110, 1346-1347, 1373-1376, 1658, 1733
R/tt_showmethods.R             213      34  84.04%   32-77, 98-120, 164-167, 171-173, 206, 306, 332, 341-346, 467-468
R/tt_sort.R                    115       6  94.78%   50, 289-292, 300
R/tt_toString.R                439      24  94.53%   125, 355, 377, 390, 400, 406, 409, 415-425, 518, 619, 826-851
R/utils.R                       34       7  79.41%   56, 169-174
R/validate_table_struct.R       84      10  88.10%   80-84, 93-94, 140, 149-150
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         9363     895  90.44%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  -------
R/tt_dotabulation.R       -5      +5  -0.41%
TOTAL                     -5      +5  -0.06%

Results for commit: 46b6044

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

    1 files     32 suites   2m 1s ⏱️
  275 tests   275 ✅ 0 💤 0 ❌
2 039 runs  2 039 ✅ 0 💤 0 ❌

Results for commit 46b6044.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
Content functions (cfun)	👶		$+0.11$	.alt_df_argument_behavior_is_correct_when_alt_counts_df_is_not_set

Results for commit 73dc89e

♻️ This comment has been updated with latest results.

[Melkiades]

any news on this @gmbecker?

[shajoezhu]

hi @gmbecker , do we drop this PR?

[gmbecker]

@shajoezhu sorry, I had commited changes that addressed most of the comments but I forgot to resolve them here. I've done so now, as well as addressing the couple that I missed, should be good to go now.

[shajoezhu]

thanks @gmbecker ! can we run an scda.test check on this before we merge it in? @munoztd0 many thanks!

[munoztd0]

thanks @gmbecker ! can we run an scda.test check on this before we merge it in? @munoztd0 many thanks!

of course here you go -> insightsengineering/scda.test#257

[shajoezhu]

unblock merging. downstream scda.test checked. thanks @gmbecker @munoztd0