Repository navigation
Fix: Ungracefull error handling of benchmark run failures - #569
Merged
Merged
Conversation
Few microbenchmarks when fails to run because of unmet machine requirements exit without running, but lkp just exits without handling it gracefully. With this patch lkp returns a non-zero exit status on such scenarios and handle gracefully with appropiate error messages. Signed-off-by: Suneeth D <Suneeth.D@amd.com>
|
Thanks for the patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few microbenchmarks when fails to run because of unmet machine requirements exit without running, but lkp just exits without handling it gracefully.
With this patch lkp returns a non-zero exit status on such scenarios and handle gracefully with appropiate error messages.
Before the patch:
$ lkp run ./autonuma-benchmark-8x-numa02SMT_numa01THREAD_ALLOC.yaml
$echo $ ?
2026-09-28 06:09:48 cd /lkp/benchmarks/autonuma-benchmark
Abort: This machine has less than 2 nodes.
Autonuma run failed, check result log
0
After the patch:
$ lkp run ./autonuma-benchmark-8x-numa02SMT_numa01THREAD_ALLOC.yaml
$echo $ ?
2026-09-28 06:12:36 cd /lkp/benchmarks/autonuma-benchmark
Abort: This machine has less than 2 nodes.
Autonuma run failed, check result log
99