Skip to content

Fix: Ungracefull error handling of benchmark run failures #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rli9 merged 1 commit into from
Sep 29, 2026
Merged

Fix: Ungracefull error handling of benchmark run failures #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions bin/run-local
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ job['rootfs'] ||= if File.exist? '/etc/os-release'
distro
end
job['nr_cpu'] ||= Etc.nprocessors
job['nr_node'] ||= Dir.glob('/sys/devices/system/node/node[0-9]*').size
job['memory'] ||= (Bash.safe_grep("grep -w '^memory:' #{LKP_SRC}/hosts/#{HOSTNAME}").split[1] || '').chomp
job['compiler'] ||= File.realpath('/usr/bin/gcc').match(/gcc.*/).to_s
job['compiler'] = 'gcc' if job['compiler'].empty?
Expand All @@ -132,9 +133,14 @@ ENV['RESULT_ROOT'] = result_root
ENV['TMP_RESULT_ROOT'] = result_root

jobx = Job2sh.new(job.to_hash)
unless jobx.expand_params
log_error 'Failed to expand params!'
exit
begin
unless jobx.expand_params
log_error 'Failed to expand params!'
exit 1
end
rescue Job::ParamError => e
log_error e.message
exit 1
end

FileUtils.rm_rf TMP
Expand All @@ -150,7 +156,11 @@ save_paths(result_root, user)

system 'killall', '-q', "#{LKP_SRC}/bin/event/wakeup"

with_thp_enabled { system job_script, 'run_job' }
run_job_status = 0
with_thp_enabled do
system job_script, 'run_job'
run_job_status = $?.exitstatus
end

system "#{LKP_SRC}/bin/run-with-job", job_script, "#{LKP_SRC}/bin/post-run"
system "#{LKP_SRC}/bin/event/wakeup", 'job-finished'
Expand All @@ -169,3 +179,5 @@ convert_mrt(_result_root)

FileUtils.rm_f(options[:result_root])
FileUtils.ln_s(result_root, options[:result_root])

exit run_job_status unless run_job_status.zero?