[katbyte]

A new rule, AZT004, that reports acceptance tests whose name does not start with TestAcc.

Why: acceptance runs select tests by that prefix. A test named TestThing_basic that drives the acceptance framework is skipped by every acceptance run, so the resource it covers is never actually tested against Azure, however complete the test looks. A survey of azurerm found 65 such functions covering 16 resources and data sources: every Oracle resource, the Cosmos PostgreSQL role, node configuration and firewall rule, the IoT security device group, and two App Service resources. tfproviderlint's AT005 misses all of them because it only recognises direct resource.Test calls, not azurerm's wrapper.

Tests that exist but never run. AZT004 reports a top-level Test function in a test file that reaches the acceptance harness, itself or through helpers, sequential maps or a TF_ACC check, without the TestAcc prefix. Lowercase helpers and methods are left alone, since no runner selects them. When Acc already sits elsewhere in the name, as in TestWebAppAccActiveSlot_basic, the report says to move it rather than suggesting a doubled-up name.

-func TestThing_basic(t *testing.T) {
+func TestAccThing_basic(t *testing.T) {
 	data := acceptance.BuildTestData(t, "azurerm_thing", "test")
 	data.ResourceTest(t, ThingResource{}, []acceptance.TestStep{{Config: "basic"}})

Shared code. The harness-reachability analysis AZT003 kept privately moves into lib/acctest as an analyzer with a result, so AZT003 and AZT004 compute it once per package. It returns early for packages with no test files.

-	runs := map[*types.Func]bool{}
-	mentions := map[*types.Func][]*types.Func{}
-	for fn, fd := range decls {
+	runs, ok := pass.ResultOf[acctest.Analyzer].(acctest.Funcs)

Things that are fine as they are. AZT003's messages, fixtures and tests are unchanged and pass on the shared code. Its TestAccountName handling, where Acc starts a word, is untouched.

The rule only reports. This is the mirror of AZT003, which reports the opposite case. The companion rule for resources missing their core tests is #68.