Repository navigation
ci: rescan the binaries once a release has published - #147
Merged
Merged
Conversation
Without this the red from a vulnerable release only clears on the next push to main or the Monday cron, not when the fixed release ships. workflow_run on the Release workflow reruns both jobs against main as soon as the assets exist, gated on the release having succeeded.
katbyte
added a commit
that referenced
this pull request
Sep 22, 2026
… a new one (#149) The workflow_run rescan from #147 attached to the same commit but as its own check runs, so the original push failure stayed and the commit kept its red X. Only a rerun replaces a check run in place. The release workflow now reruns the failed jobs of any binary scan on main's head, which needs actions: write on that one job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rerun the binary scan as soon as a release finishes publishing.
Why: the scan added in #146 only runs on a push to main and on Mondays. Ship the fixed release and the red on main stays until one of those happens, so the signal is wrong for up to a week right after you did the thing it asked for.
The release workflow finishing now triggers a rescan. Gated on the release having succeeded, so a failed release does not scan and wrongly clear anything.
schedule: - cron: '23 5 * * 1' + workflow_run: # zizmor: ignore[dangerous-triggers] + workflows: ['Release'] + types: ['completed'] workflow_dispatch:release: name: release binary runs-on: ubuntu-latest + if: github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success'The zizmor suppression.
workflow_runis flagged because it can hand repository secrets to a run kicked off by untrusted code, the usual case being a fork PR's workflow. Here it only reacts to the tag-triggered Release workflow, checks out main, and the workflow has read-only permissions, so there is nothing to leak. The reason is in a comment next to the suppression.Things that are fine as they are. Listening for the release rather than having the release workflow dispatch the scan means release.yaml keeps its current permissions and gains no
actions: write. The scan itself is unchanged, and the first run on main after #146 was red on both jobs for x/text 0.37.0, which is the expected result until it is bumped and released.