Repository navigation
fix(ci): replace stale harden-runner verify caveat and label the unlabelled pin - #10467
ankit-doclens wants to merge 1 commit into
Conversation
ed50bbe to
3ecf95e
Compare
|
Friendly ping — this is a small, single-commit CI-comment cleanup ( |
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
For the record, both of the gaps you reported are still real on current main, so the PR has not been overtaken — only its version facts have:
So the work is still wanted. On a rebase the trailer you add there becomes When you've addressed these, the pipeline will re-assess on its next cycle. |
3ecf95e to
1011498
Compare
…belled pin The four fork review lanes carried a stale "VERIFY before merge that this SHA resolves to the intended harden-runner release" caveat. That verification is done -- git/ref/tags/v2.21.1 on step-security/harden-runner resolves to e14015d583714f6e62063499dc959a02595150a1, the commit those sites pin. Replace the caveat with the verification result, matching fork-security-scope-review.yml, and add the missing # v2.21.1 trailer to fork-internal-content-scan.yml.
1011498 to
dcb6b39
Compare
|
Thank you for this cleanup, @ankit-doclens. Your commit has been carried into an in-repo replacement PR (#14435) — authorship preserved and you are credited via a Co-authored-by trailer — because the fork head branch cannot be pushed to from this repository, which is what left the workflow-change approval gate blocking here. #14435 keeps all your live hunks (the stale "VERIFY before merge" caveat replaced in the four fork review workflows plus the missing |
Problem / Motivation
Four fork review lanes —
fork-design-review.yml,fork-gpt-review.yml,fork-opus-review.yml,fork-ux-review.yml— carry a stale caveat above theirharden-runnerpin:That verification is done. A fifth lane,
fork-internal-content-scan.yml, pins the same SHA with no version trailer at all, unlike every other site.Why it matters
A standing "verify before merge" note that nobody clears is indistinguishable from one that still matters — it asks each reader to re-verify something already confirmed, and erodes trust in the pin comments on the security surface. The missing version trailer hides from a reader (and from Dependabot) which release the bare SHA corresponds to. Both are small correctness/hygiene gaps on the CI security lanes.
What changed (motivation → approach → change)
git/ref/tags/v2.21.1onstep-security/harden-runnerresolves toe14015d583714f6e62063499dc959a02595150a1, which is the commit these fork lanes pin on currentmain.fork-security-scope-review.yml, adapted to the currentv2.21.1pin, so all lanes read consistently rather than inventing new phrasing.# v2.21.1trailer tofork-internal-content-scan.yml.Note:
mainrecently bumped harden-runnerv2.20.1→v2.21.1; this PR was rebased onto that and its wording/trailer re-verified against the new pin. Task 3 from the issue (a pin-hygiene lint to prevent recurrence) is intentionally left as a separate follow-up to keep this change focused.Tests
No automated tests — the change is comment/trailer-only in workflow YAML and adds no behavior. All five files were validated to parse as YAML. No
VERIFY before mergecaveat remains in the four review lanes, and every affectedharden-runner@pin now carries the# v2.21.1trailer.Manual verification
N/A — comment-only change; verified via the GitHub tags API that
v2.21.1resolves toe14015d5…and that the wording matches the pattern infork-security-scope-review.yml.Related Issues
Closes #10105.
Pattern harvest
Not generalizable: a one-off cleanup of a stale authoring-time caveat and a single missing version trailer. The recurrence guard (a pin-hygiene check that every
uses:SHA carries a version trailer and no workflow carries an unresolved "VERIFY before merge" note) is task 3 of the issue and is tracked as a separate follow-up.Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)