Skip to content

fix(ci): replace stale harden-runner verify caveat and label the unlabelled pin - #10467

Closed
ankit-doclens wants to merge 1 commit into
kirodotdev:mainfrom
ankit-doclens:fix/harden-runner-pin-caveats
Closed

ankit-doclens wants to merge 1 commit into
kirodotdev:mainfrom
ankit-doclens:fix/harden-runner-pin-caveats

Conversation

@ankit-doclens

@ankit-doclens ankit-doclens commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Four fork review lanes — fork-design-review.yml, fork-gpt-review.yml, fork-opus-review.yml, fork-ux-review.yml — carry a stale caveat above their harden-runner pin:

# VERIFY before merge that this SHA resolves to the intended harden-runner
# release (authoring host had no network to confirm it).

That verification is done. A fifth lane, fork-internal-content-scan.yml, pins the same SHA with no version trailer at all, unlike every other site.

Why it matters

A standing "verify before merge" note that nobody clears is indistinguishable from one that still matters — it asks each reader to re-verify something already confirmed, and erodes trust in the pin comments on the security surface. The missing version trailer hides from a reader (and from Dependabot) which release the bare SHA corresponds to. Both are small correctness/hygiene gaps on the CI security lanes.

What changed (motivation → approach → change)

  • Root cause: the caveat was written when the authoring host had no network to resolve the tag. Verified against GitHub: the lightweight tag git/ref/tags/v2.21.1 on step-security/harden-runner resolves to e14015d583714f6e62063499dc959a02595150a1, which is the commit these fork lanes pin on current main.
  • Approach: reuse the verified-wording pattern already established in fork-security-scope-review.yml, adapted to the current v2.21.1 pin, so all lanes read consistently rather than inventing new phrasing.
  • Change: replace the stale caveat in the four lanes with that verification result, and add the missing # v2.21.1 trailer to fork-internal-content-scan.yml.

Note: main recently bumped harden-runner v2.20.1 → v2.21.1; this PR was rebased onto that and its wording/trailer re-verified against the new pin. Task 3 from the issue (a pin-hygiene lint to prevent recurrence) is intentionally left as a separate follow-up to keep this change focused.

Tests

No automated tests — the change is comment/trailer-only in workflow YAML and adds no behavior. All five files were validated to parse as YAML. No VERIFY before merge caveat remains in the four review lanes, and every affected harden-runner@ pin now carries the # v2.21.1 trailer.

Manual verification

N/A — comment-only change; verified via the GitHub tags API that v2.21.1 resolves to e14015d5… and that the wording matches the pattern in fork-security-scope-review.yml.

Related Issues

Closes #10105.

Pattern harvest

Not generalizable: a one-off cleanup of a stale authoring-time caveat and a single missing version trailer. The recurrence guard (a pin-hygiene check that every uses: SHA carries a version trailer and no workflow carries an unresolved "VERIFY before merge" note) is task 3 of the issue and is tracked as a separate follow-up.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality (N/A — no behavior change)
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable) (N/A)
  • No secrets, credentials, or internal references in the diff

@ankit-doclens
ankit-doclens requested review from a team and dwu96 September 13, 2026 03:31
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 13, 2026
@ankit-doclens
ankit-doclens force-pushed the fix/harden-runner-pin-caveats branch from ed50bbe to 3ecf95e Compare September 13, 2026 07:49
@ankit-doclens

Copy link
Copy Markdown
Contributor Author

Friendly ping — this is a small, single-commit CI-comment cleanup (Closes #10105) that's blocked only on the initial "Approve and run" for a first-time fork contributor. Happy to address any feedback whenever a maintainer has a moment. cc @kirodotdev/kirocrew-team

@dwu96 dwu96 added the needs-pr-triage PR scanner: awaiting automated triage label Sep 18, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 18, 2026
@NicholasRBowers NicholasRBowers added needs-author-decision PR blocked on author input and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 18, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:

  • No CI has run at all, and only a maintainer can start it. The single failing check is PR Readiness, whose reason is "4 workflow(s) awaiting maintainer approval; none has run yet" — the first-time-fork-contributor "Approve and run" gate, on a PR that edits .github/workflows/. There is no CI signal here to drive to green, and pushing would not create one: each new push from the fork re-arms the same approval requirement. This needs a maintainer to press Approve and run. Same shape as chore(deps): bump anthropics/claude-code-action from 1.0.194 to 1.0.200 #3324 and build(deps): bump step-security/harden-runner from 2.20.1 to 2.21.0 #4718, both of which were routed the same way.

  • Main has moved the pin the PR is written about, so the replacement wording is now factually wrong. The description's core claim is that v2.20.1 resolves to b09bb98e06d4d774595224525879c09bc6e98c40, "which is the commit all ten sites in .github/workflows/ pin". Current main pins step-security/harden-runner@e14015d583714f6e62063499dc959a02595150a1 # v2.21.1 instead — visible in fork-design-review.yml today. That is what the merge conflict label is about, and it means resolving the conflict is not a pure text merge: the new caveat text asserts a verified release, so whoever rebases has to re-verify that e14015d5… is genuinely v2.21.1 and re-word against it. I am not going to re-assert a verification claim on the CI security surface on your behalf.

For the record, both of the gaps you reported are still real on current main, so the PR has not been overtaken — only its version facts have:

  • the stale # VERIFY before merge that this SHA resolves to the intended harden-runner release caveat is still present in the four fork review lanes;
  • fork-internal-content-scan.yml still pins the bare SHA with no version trailer.

So the work is still wanted. On a rebase the trailer you add there becomes # v2.21.1 rather than # v2.20.1.

When you've addressed these, the pipeline will re-assess on its next cycle.

@ankit-doclens
ankit-doclens force-pushed the fix/harden-runner-pin-caveats branch from 3ecf95e to 1011498 Compare September 19, 2026 19:27
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 19, 2026
…belled pin

The four fork review lanes carried a stale "VERIFY before merge that this SHA resolves to the intended harden-runner release" caveat. That verification is done -- git/ref/tags/v2.21.1 on step-security/harden-runner resolves to e14015d583714f6e62063499dc959a02595150a1, the commit those sites pin. Replace the caveat with the verification result, matching fork-security-scope-review.yml, and add the missing # v2.21.1 trailer to fork-internal-content-scan.yml.
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 21, 2026
@ankit-doclens
ankit-doclens force-pushed the fix/harden-runner-pin-caveats branch from 1011498 to dcb6b39 Compare September 21, 2026 06:47
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 21, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Thank you for this cleanup, @ankit-doclens. Your commit has been carried into an in-repo replacement PR (#14435) — authorship preserved and you are credited via a Co-authored-by trailer — because the fork head branch cannot be pushed to from this repository, which is what left the workflow-change approval gate blocking here. #14435 keeps all your live hunks (the stale "VERIFY before merge" caveat replaced in the four fork review workflows plus the missing # v2.21.1 label on the fork-internal-content-scan.yml harden-runner pin) and is green with PR Readiness passing. Closing this one in favour of #14435; your branch is left intact.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Sep 27, 2026
@ankit-doclens
ankit-doclens deleted the fix/harden-runner-pin-caveats branch October 13, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) needs-author-decision PR blocked on author input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear the stale harden-runner 'verify before merge' caveat in four fork lanes, and label the unlabelled pin

4 participants