Repository navigation
fix(ci): replace stale harden-runner verify caveat and label the unlabelled pin - #14435
Conversation
…belled pin Replace the stale "VERIFY before merge that this SHA resolves to the intended harden-runner release" caveat in the four fork review workflows (design, gpt, opus, ux) with a recorded note that the pinned SHA e14015d583714f6e62063499dc959a02595150a1 was verified against the upstream tag v2.21.1, so the next reader need not re-open the question. Also add the missing `# v2.21.1` label to the one unlabelled harden-runner pin in fork-internal-content-scan.yml, matching its five already-labelled sibling workflows. Comments-only: no step, pin SHA, or permission is changed. Co-authored-by: ankit-doclens <199591041+ankit-doclens@users.noreply.github.com>
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Spot-check [DESIGN-REVIEWED] 524616f |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Confirm once, out-of-band, that What this change shipsInventory (2 items) — 2 justifiedIntent: stop readers re-opening an already-answered verification question on the fork workflows' harden-runner pin — a FIX (of a stale comment), per issue #10105.
Counts run: [FIRST-PRINCIPLES-REVIEWED] 524616f |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsOne advisory finding: the new pin note asserts fail-closed on the two lanes whose finalizer defaults to FINDING — .github/workflows/fork-design-review.yml:70 (same block at .github/workflows/fork-ux-review.yml:82) — the added [OPUS-REVIEWED] 524616f Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Thanks for picking this up 🙂 |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed on behalf of the maintainers (sweep 2026-09-27): readiness passed, required checks green on 524616f, no blocking review threads, security posture unchanged. Approving and merging.
Problem / Motivation
Goal: Remove a stale, now-actionable-looking "VERIFY before merge" caveat from the four fork review workflows and label the one unlabelled harden-runner pin, so the security-surface comments are accurate and consistent.
The four fork review workflows (design, gpt, opus, ux) each carry a caveat telling the next reader to "VERIFY before merge that this SHA resolves to the intended harden-runner release (authoring host had no network to confirm it)." That verification has since been done: the pinned SHA
e14015d583714f6e62063499dc959a02595150a1resolves to the upstream tagv2.21.1. The stale caveat now reads as an open action item on a security-critical step that is in fact already settled. Separately,fork-internal-content-scan.ymlpins the same harden-runner SHA with no# v2.21.1version label, unlike its five already-labelled sibling workflows.Why it matters
The caveat sits on the egress-allowlist step that fails closed and reds every fork PR on the security surface if the pin is wrong. Leaving a "VERIFY before merge" note there implies the pin is unconfirmed, so every reviewer and driver re-opens a question that is already answered, and the unlabelled scan pin makes an auditor cross-reference the SHA by hand. Recording the verification result and labelling the pin removes that repeated, avoidable work.
Not a goal
What changed (motivation → approach → change)
Stale caveat implies unverified pin → the SHA was in fact verified against the upstream tag
v2.21.1→ replace the "VERIFY before merge" comment in the four review workflows with a recorded note stating the SHA was verified againstv2.21.1and to re-verify only when the version comment moves. Infork-internal-content-scan.yml, the harden-runner pin lacked the# v2.21.1label its siblings carry → append the trailing# v2.21.1comment to match. Nouses:value, step, or permission changes.Backwards compatibility
Compatible: comment and trailing-label edits only; no runtime behaviour, contract, or field changes.
Tests
N/A — comments-only change to CI workflow files; no code path is exercised. YAML of all five files re-validated locally after the edit.
Manual verification
Confirmed the pinned SHA
e14015d583714f6e62063499dc959a02595150a1is the commit forstep-security/harden-runnertagv2.21.1(GitHubgit/ref/tags/v2.21.1→ object typecommit, shae14015d5...), matching the five sibling workflows that already label the same SHA# v2.21.1.Related Issues
Closes #10105. Replacement for #10467 (fork PR by @ankit-doclens), whose head branch cannot be pushed to from this repository.
Pattern harvest
Not generalizable: a one-off cleanup of a specific stale comment and a single missing version label on an already-correct pin.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement