Skip to content

fix(ci): replace stale harden-runner verify caveat and label the unlabelled pin - #14435

Merged
bolichen97 merged 1 commit into
mainfrom
drive/10467-harden-runner-caveat
Sep 27, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
drive/10467-harden-runner-caveat

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Remove a stale, now-actionable-looking "VERIFY before merge" caveat from the four fork review workflows and label the one unlabelled harden-runner pin, so the security-surface comments are accurate and consistent.

The four fork review workflows (design, gpt, opus, ux) each carry a caveat telling the next reader to "VERIFY before merge that this SHA resolves to the intended harden-runner release (authoring host had no network to confirm it)." That verification has since been done: the pinned SHA e14015d583714f6e62063499dc959a02595150a1 resolves to the upstream tag v2.21.1. The stale caveat now reads as an open action item on a security-critical step that is in fact already settled. Separately, fork-internal-content-scan.yml pins the same harden-runner SHA with no # v2.21.1 version label, unlike its five already-labelled sibling workflows.

Why it matters

The caveat sits on the egress-allowlist step that fails closed and reds every fork PR on the security surface if the pin is wrong. Leaving a "VERIFY before merge" note there implies the pin is unconfirmed, so every reviewer and driver re-opens a question that is already answered, and the unlabelled scan pin makes an auditor cross-reference the SHA by hand. Recording the verification result and labelling the pin removes that repeated, avoidable work.

Not a goal

  • Not changing any workflow step, the harden-runner pin SHA, or any permission — this is comments and a trailing version label only.
  • Not re-pinning or upgrading harden-runner.

What changed (motivation → approach → change)

Stale caveat implies unverified pin → the SHA was in fact verified against the upstream tag v2.21.1 → replace the "VERIFY before merge" comment in the four review workflows with a recorded note stating the SHA was verified against v2.21.1 and to re-verify only when the version comment moves. In fork-internal-content-scan.yml, the harden-runner pin lacked the # v2.21.1 label its siblings carry → append the trailing # v2.21.1 comment to match. No uses: value, step, or permission changes.

Backwards compatibility

Compatible: comment and trailing-label edits only; no runtime behaviour, contract, or field changes.

Tests

N/A — comments-only change to CI workflow files; no code path is exercised. YAML of all five files re-validated locally after the edit.

Manual verification

Confirmed the pinned SHA e14015d583714f6e62063499dc959a02595150a1 is the commit for step-security/harden-runner tag v2.21.1 (GitHub git/ref/tags/v2.21.1 → object type commit, sha e14015d5...), matching the five sibling workflows that already label the same SHA # v2.21.1.

Related Issues

Closes #10105. Replacement for #10467 (fork PR by @ankit-doclens), whose head branch cannot be pushed to from this repository.

Pattern harvest

Not generalizable: a one-off cleanup of a specific stale comment and a single missing version label on an already-correct pin.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

…belled pin

Replace the stale "VERIFY before merge that this SHA resolves to the
intended harden-runner release" caveat in the four fork review workflows
(design, gpt, opus, ux) with a recorded note that the pinned SHA
e14015d583714f6e62063499dc959a02595150a1 was verified against the
upstream tag v2.21.1, so the next reader need not re-open the question.

Also add the missing `# v2.21.1` label to the one unlabelled
harden-runner pin in fork-internal-content-scan.yml, matching its five
already-labelled sibling workflows.

Comments-only: no step, pin SHA, or permission is changed.

Co-authored-by: ankit-doclens <199591041+ankit-doclens@users.noreply.github.com>
@iamwhatever
iamwhatever requested a review from a team as a code owner September 27, 2026 09:34
@iamwhatever iamwhatever added the drive-to-green PR claimed by drive-to-green pipeline label Sep 27, 2026
@iamwhatever iamwhatever self-assigned this Sep 27, 2026
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 524616f5b1c396dc80a9da8225c3e66589ec20f8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 524616f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 524616f5b1c396dc80a9da8225c3e66589ec20f8: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 524616f5b1c396dc80a9da8225c3e66589ec20f8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Spot-check git/ref/tags/v2.21.1 → e14015d5… on step-security/harden-runner once; the diff is comments only, the pin itself is unchanged.

[DESIGN-REVIEWED] 524616f

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 524616f5b1c396dc80a9da8225c3e66589ec20f8 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Confirm once, out-of-band, that e14015d583714f6e62063499dc959a02595150a1 is harden-runner tag v2.21.1 — the new comment records that as settled fact.

What this change ships

Inventory (2 items) — 2 justified

Intent: stop readers re-opening an already-answered verification question on the fork workflows' harden-runner pin — a FIX (of a stale comment), per issue #10105.

  1. The "VERIFY before merge" caveat in the four fork review workflows now reads as a recorded, completed verification against tag v2.21.1 — justified
  2. The harden-runner pin in fork-internal-content-scan.yml now carries the # v2.21.1 version label its five sibling workflows already have — justified

Counts run: harden-runner@ in .github/workflows/ — six pins of e14015d5…, five labelled # v2.21.1 on base, this PR labels the sixth; uses: .+@[0-9a-f]{40}$ — zero unlabelled SHA pins remain, so no unfixed siblings; VERIFY before merge — zero occurrences remain.

[FIRST-PRINCIPLES-REVIEWED] 524616f

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 524616f5b1c396dc80a9da8225c3e66589ec20f8 — this comment is updated in place on each push.

Review details

One advisory finding: the new pin note asserts fail-closed on the two lanes whose finalizer defaults to neutral.

FINDING — .github/workflows/fork-design-review.yml:70 (same block at .github/workflows/fork-ux-review.yml:82) — the added a wrong pin reds every fork PR on the security surface fail-closed contradicts these two lanes' own Finalize check-run (advisory) (*) conclusion="neutral"; title="review incomplete (advisory)" at fork-design-review.yml:1489 / fork-ux-review.yml:2023, with if: always() so a dead harden-runner pin still reaches it) and the pre-existing comment nine lines below it (advisory, so it reads as neutral rather than red and the lane silently stops reviewing, neutral reads as a PASS to pr-readiness.yml), so the false premise is then used to tell the next reader to stop verifying the pin on exactly the lanes where a bad pin fails open — only fork-gpt-review.yml:2101 and fork-opus-review.yml:1405 default to conclusion="failure" → Fix: in these two files replace the reds every fork PR … fail-closed clause with the lane's real failure mode (a wrong pin publishes review incomplete (advisory) → neutral → counted as a pass, so the pin must be verified because nothing else will catch it), keeping the fail-closed wording only in the gpt/opus lanes.

[OPUS-REVIEWED] 524616f

Verdict parsed from the review's SHA-scoped output markers for commit 524616f5b1c396dc80a9da8225c3e66589ec20f8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 524616f5b1c396dc80a9da8225c3e66589ec20f8: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 27, 2026
@ankit-doclens

ankit-doclens commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Thanks for picking this up 🙂

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on behalf of the maintainers (sweep 2026-09-27): readiness passed, required checks green on 524616f, no blocking review threads, security posture unchanged. Approving and merging.

@bolichen97
bolichen97 merged commit d4bccd4 into main Sep 27, 2026
99 of 107 checks passed
@bolichen97
bolichen97 deleted the drive/10467-harden-runner-caveat branch September 27, 2026 17:04
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 27, 2026
@dwu96 dwu96 removed the drive-to-green PR claimed by drive-to-green pipeline label Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear the stale harden-runner 'verify before merge' caveat in four fork lanes, and label the unlabelled pin

4 participants