Repository navigation
Conversation
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
1 similar comment
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
UX Review (Fable 5, fork) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK Cannot evaluate: missing stills for the "Model decides" thumbless axis and the GPT "Off" notch — two new states no attachment shows. Watch
Evidence gaps
Suggestions
[UX-REVIEWED] 3ba732f |
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Two opposite clamp policies ship in one PR: the backend keeps the effort pick as made, the frontend destructively rewrites it on model switch. Watch
Suggestions
[DESIGN-REVIEWED] 3ba732f |
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed 1 of 2 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- website/src/pages/ChatPage.tsx:3793 -- Clamp write races failed model switch BLOCKING -- website/src/lib/effort.ts:96 -- Static GPT ladder overrides adapter-reported levels (origin: validation) [BLOCK-MERGE] 3ba732f Adjudication (Opus 4.8) — is blocking on each finding proportionate?I've traced the mechanism from both the diff (as data) and the on-disk base helpers. Let me record my rulings. F1 — ChatPage.tsx clamp write races a failed model switch The scenario: slot carries an explicit
F2 — fenced. Static [ADJUDICATION] 3ba732f total=1 uphold=0 downgrade=1 |
First Principles Review (Fable 5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK Product-shape change without accepted RFC: the effort picker's return-to-default capability is deleted — a declared reversal of #10244 and the base spec — with no recorded decision. Not justified as shipped
What this change shipsInventory (10 items) — 3 justifiedIntent: make the model/effort picker show exactly what the session runs, instantly — framed as a FIX; several items are redesign. More than 10 differences exist (localized credits unit, JobForm shared list, resolver-backed default effort, cache invalidations, deleted i18n keys); the 10 most noticeable are kept.
Blockersproduct-shape change without accepted RFC — the one-level redesign removes the "Use configured default" toggle and reset ("no 'Use configured default' toggle and no reset link … a deliberate reversal of the toggle #10244 introduced"); the base spec pins the removed shape ( Spec contradicted by its own diff — model-selection.md adds "the stored level is not rewritten, so it is [FIRST-PRINCIPLES-REVIEWED] 3ba732f |
Opus 4.8 Review (fork) — 🔴 changes requested (blocking)Reviewed Model-switch effect silently and permanently overwrites the user's stored effort pick with the clamped value, defeating this PR's own keep-the-pick design. [BLOCK-MERGE] 3ba732f BLOCKING — website/src/pages/ChatPage.tsx:2899
FINDING — website/src/lib/effort.ts:2497 — unanchored [OPUS-REVIEWED] 3ba732f |
bd97f9b to
6672bb5
Compare
6672bb5 to
7601c62
Compare
4a148ff to
8b7da2b
Compare
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
8b7da2b to
aa1a13c
Compare
|
👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review. When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically. |
aa1a13c to
fb06424
Compare
…, instant switch Model picker - Rows are one line: the description moves behind an info tip, `[Internal]` stays beside the name, Auto loses its "Default" subtitle, and every row names the model by the vendor's spelling (`Claude Opus 4.8`, `GPT-5.6 Sol`, `DeepSeek-V3.2`); the id stays the persisted value and is what the filter also matches. The same names are used by every other model selector (Settings ▸ Chat, crew editor, scheduled jobs, Knowledge, Auto Research, Spec Builder, Issue Radar) and by the per-turn footer and its tooltip. - The picker is a shadcn Popover; keyboard focus on a row uses the hover background like the other menus, not the outline ring. - Picking a model updates the chip and the list at once. The request still goes through the serialized switch protocol; if it fails the chip returns to the last confirmed model, and a burst that fails entirely returns to the model in force before the burst. Reasoning effort - The slider shows one level: the session's override, else the level the crew pin → role → Settings ▸ Chat chain resolves to (from the backend resolver, so it agrees with the Agents page), clamped to what the shown model accepts. No default marker, no toggle, no reset link. - Every landing on the axis — a move, a click on the notch already shown, or Enter — makes that level the session's own. When the chain resolves to nothing the axis has no thumb and reads "Model decides" until the first pick. - Notches come from a per-model table probed against kiro-cli (Sonnet 4.6 has no xhigh; GPT-5.6 adds "Off"). Switching to a model that lacks the session's level rewrites the override to the nearest lower level and says so in a 3-second notice. - The footer's credits unit is localized; a Settings save invalidates the inherited-effort cache so an open picker does not keep a stale default. Slider grows `onPick` (fires on every landing, including the shown notch); its reference-marker props go with their only consumer. Scheduled jobs read the shared model list instead of a private query.
… failure - A per-model level table probed against kiro-cli 2.21.4 (mirrors the frontend's) backs `effort_levels_for_model` / `nearest_supported_effort`. On the kiro path the level put on the wire — the live `/effort` push and the spawn overlay — is the nearest level the current model accepts, while the stored pick is kept as made. `model_supports_effort` consults the table first, so Opus 4.5 and Sonnet 4.x are not offered a control kiro refuses. - kiro-cli reports a refused level as a normal result with `success: false`; that is now a failed switch (rolled back, then the handler's reset path), not a silently applied one. `EFFORT_LEVELS` gains `none` (GPT-5.6); the config-option ladder never steps down into it.
fb06424 to
3ba732f
Compare
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
Not waiting on you: all CI is green, and the merge conflict is four files ( When you've addressed these, the pipeline will re-assess on its next cycle. |
|
Triage (automated, 2026-10-05) — DISTINCT, needs rebase.
Recommendation: rebase, settle the open product decisions, then continue. |
|
Thank you for the careful write-up of where the picker and the session disagree. We are closing this because main has moved a long way since it was opened: model display names and handling of a refused effort level have landed through other changes, effort levels now come from the model's advertised options rather than a static table, and the branch conflicts in 38 paths. Removing the 'Use configured default' toggle reverses #10244 and would need its own decision first. If you still want any piece of this, such as the optimistic model switch or the inline multi-select, a small PR per piece on current main is very welcome. The 'show what the session actually runs' goal is also being worked on in #16906. |
Problem / Motivation
The model picker says one thing and the session runs another, in four ways a user can see:
/effortresult (success: false), the gateway reads only the reply text and reports success, and the session keeps its previous level while the picker shows the new one.claude-opus-4.8,gpt-5.6-sol) and each row spends a second line on the description; Auto carries a "Default" subtitle that reads as "the configured default model".Why it matters
Effort and model are the two things a user changes mid-session most often. A picker that shows a level the model is not running, or that appears not to react to a click, teaches the user not to trust it; two visually different states for one level, plus three different meanings of "default" in one popover, are what every "why is my session slow / expensive" question comes back to.
What changed (motivation → approach → change)
One level, no default concept in the session picker. The slider shows the level in force: the session's own override if it has one, otherwise the level the crew pin → role → Settings → Chat chain resolves to, fetched from the backend resolver (
/api/agents/resolved-model) so the picker and the Agents page agree. Every landing on the axis — a move, a click on the notch already shown, or Enter — writes that level as the session's own. There is no default marker, no "Use configured default" toggle and no reset link: defaults are configured in Settings → Chat and on the crew, and the session picker shows the result rather than explaining the chain. This is a deliberate reversal of the toggle #10244 introduced. The alternative kept ("explicit High" vs "inherited High" as two UI states) was dropped because users cannot tell them apart and never need to: when the chain resolves to nothing, the axis has no thumb and reads "Model decides" until the first pick, which is the only remaining non-level state.Per-model levels, clamped on both ends. A table probed against kiro-cli 2.21.4 (Sonnet 4.6 has no
xhigh; GPT-5.6 addsnone, shown as "Off"; Opus 4.5 / Sonnet 4.x / Haiku / auto and the third-party models refuse effort) drives which notches the slider offers. The frontend and the backend share the table. On the kiro path the backend puts the nearest level the current model accepts on the wire — both the live/effortpush and the spawn-time overlay — while keeping the stored pick as made. A/effortresult carryingsuccess: falseis now a failed switch (rolled back, then the existing reset fallback), not a silently applied one. When the user switches to a model that lacks the session's level, the frontend rewrites the override to the clamped level and shows a 3-second notice ("Claude Sonnet 4.6 does not support Extra High; switched to High").Settings ▸ Chat manages the selectable models in the page. The "Selectable Models" control was a searchable multi-select behind a summary trigger, so the state it edits (which models the picker offers) was hidden until opened. It now renders as a list standing in the page — same search, bulk actions, locked Auto row and keyboard travel, with the summary as a caption — via an
inlinemode on the sharedMultiSelect; the dropdown shape is unchanged for any other consumer.Display names everywhere a model is named. A static table maps kiro-cli ids to the vendor's spelling (
Claude Opus 4.8,GPT-5.6 Sol,DeepSeek-V3.2,Qwen3-Coder-Next); ids the table does not know render verbatim (never an invented name). The name is used by the chat picker (single-chat and split-pane), the filter (matches name and id), the composer chip, the "set as default model for …" row, Settings → Chat (default / background / subagent / fallback model, the selectable-models list), the crew editor, scheduled jobs, Knowledge, Auto Research, Spec Builder and Issue Radar, and by the per-turn footer under each reply and its tooltip. The id stays the persisted value, indata-model-name/title, and in the Telemetry table where rows are grouped by id.Compact rows. Each row is one line: the description sits behind a single-ring ⓘ,
[Internal]stays beside the name, Auto's "Default" subtitle is gone (also a deliberate removal: it named a factory default while the same popover offers to set a default model). The picker is the shared shadcnPopover; keyboard focus on a row uses the hover background like the other menus rather than the outline ring, which the scrolling list clips.Instant model switch. The chip and the list update on click; the request still goes through the serialized switch protocol, which restores the last confirmed model if it fails and, for a rapid burst that fails entirely, the model in force before the burst.
performSlotSwitchgains an optionaloptimisticargument for this; the adjudication rules are unchanged.Smaller changes riding along. The footer's
creditsunit is localized (it was English in every locale); the API-cost branch uses the shared currency formatter. Scheduled jobs read the shared model list instead of a private query. A Settings → Chat effort save invalidates the picker's inherited-effort cache so an open tab does not keep the previous default.SlidergainsonPick(every landing, including the shown notch) and drops its reference-marker props with their only consumer. Dead i18n keys for the removed toggle, marker and "Customize" page are deleted;effort_helpno longer narrates the inheritance chain.Tests
Frontend (Vitest): the effort control (level in force with no marker/toggle/reset; same-notch pick writes the level; a pick the session already holds writes nothing; optimistic thumb and rollback on a rejected write; per-model notches and clamping; "Model decides" state),
Slider.onPick(every landing, Enter, inert withoutonPick),performSlotSwitchoptimistic writes (immediate write, single-failure rollback to baseline, all-failure burst rollback to the first baseline, adoption of an older landed pick, baseline cleared after a confirmed pick), the per-turn footer (display name, localized unit, tooltip),fmtTurnModel, the resolver-backedresolveDefaultEffort,MultiSelectinline mode (no trigger, summary caption, search, disabled applying to the controls) and the Settings selectable-models list against it, and display-name assertions across the Settings, crew, Knowledge and picker suites. 204 files / 3373 tests in the model, effort, settings, footer and switch-protocol areas pass.Backend (pytest): the level table (
effort_levels_for_model),nearest_supported_effort,effort_for_model,model_supports_effortconsulting the table (Opus 4.5 / Sonnet 4.x refused),change_effortclamping the wire level while keeping the pick, asuccess: falseresult rolling back and raising,clear_effortthrough the checked push, and the config-option ladder never stepping intonone. 302 tests across the effort, provider, handler and codex-pair suites pass.Gates: TypeScript build mode, ESLint on every changed file, all
i18n:checklanes, phantom-class and theme-token gates, docs lint, comment-history gate againstorigin/main, production build.Manual verification
kiro-cli 2.21.4 probed over ACP:
/effort xhighonclaude-sonnet-4.6answers{"success": false, "message": "invalid value 'xhigh' for 'output_config.effort', must be one of: low, medium, high, max"}as a normal result;/effort highanswers{"success": true, "message": "Effort set to high"}; an effort-refusing model answerssuccess: falsewith "Effort configuration is currently not available on …". The per-model table matches a 21-model probe.A real Chromium run against the built SPA with stubbed gateway responses verified: display names in rows, no marker / toggle / reset, the inherited crew level shown as the level in force, a same-notch click writing that level, the switch to Sonnet 4.6 rewriting
xhightohighwith the notice and a four-notch axis, and the footer naming the model by display name. The frontend half has been dogfooded on a private gateway for two days; the backend half (wire clamp,success: falsehandling) is covered by the unit tests and the kiro-cli probe above and has not yet run on a live gateway.Screenshots / video
Before
Raw ids, two-line rows, Auto says "Default", effort is "Default · Extra High" with a toggle and a disabled slider; the footer shows the raw id.
After
One-line rows named like the vendor does; the effort axis shows the level in force (the crew's pin) with no marker, toggle or reset link; the footer uses the same name.
Switching to a model without the session's level rewrites it and says so for three seconds; the chip and list update immediately.
Settings ▸ Chat: the selectable-models list stands in the page (Auto locked, one hidden model unchecked, search and bulk actions on top).
Before → After walkthrough with captions (same stubbed model data in both):
before-after.webm
Related Issues
Supersedes the effort-toggle interaction from #10244; replaces the model-ordering direction of #9969 with no ordering (Kiro's own catalog order is kept, hidden models remain the way to shorten the list).
Pattern harvest
Rule candidate: review-prompt
Pattern: "a slash-command reply is read as text and treated as success without checking its
successfield" — anycommand_resultconsumer should assert the structured outcome, not the presence of a message.Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement