Repository navigation
fix: bound timeouts and isolate memory errors (part 1/7) - #10744
bolichen97 wants to merge 1 commit into
Conversation
|
Intent: Supply bounded recovery policy and episode-tracking primitives, with tests and owning documentation, as Part 1 of the dependency-ordered replacement for #10521. Preserve existing runtime behavior while enforcing the already-declared workflow timeout bound and keeping memory failures and test fixtures safe. |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify no dashboard aggregator or alert relied on the cross-source Suggestions
[DESIGN-REVIEWED] 0b6a3b9 |
First Principles Review (Fable 5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The loader clamp fixes a defect that does not exist: Not justified as shipped
What this change shipsInventory (10 items) — 7 justifiedIntent: bound the workflow-run ceiling at config load and stop memory-store 503s from leaking internal exception text, with test-isolation repairs — a FIX.
Blockers
[FIRST-PRINCIPLES-REVIEWED] 0b6a3b9 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
c257255 to
0b6a3b9
Compare
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Original full-gate excerpt (ANSI formatting and machine paths omitted; values and assertion unchanged): This comment makes the previously local evidence reviewable. The main-base code paths use independently sampled kernel accounting sources; a shared SDK timestamp is not an atomic kernel snapshot. The fixed tests and unchanged production probes passed the complete 50-command local gate on the current head. |
|
|
🤖 Kiro Crew [operator: chenmingwei23#de330d0c]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
When you've addressed these, the pipeline will re-assess on its next cycle. |
|
由所有者决定关闭。分支与提交保留,后续如需可另行处理。 |
Pull request was closed
Problem / Motivation
The workflow timeout loader does not enforce its declared bounds. Shared memory-store startup/read failures can expose internal exception details. Several existing tests also depend on leaked CLI state, a particular home layout, cross-source RSS ordering, or process-global mocks, preventing reliable verification of those fixes.
Why it matters
Workflow execution must remain bounded, unavailable-memory responses must be useful without disclosing private paths or content, and tests must verify those contracts without modifying the operator's environment or mistaking unrelated process probes for termination calls.
What changed (motivation → approach → change)
src/kiro_crew/config/loader.py, with direct default, boundary, coercion and invalid-value regressions.src/kiro_crew/dashboard/handlers/memory.py, never formatting the internal exception. Preserve the separate anonymous private-PUT response and redacted logging from feat: complete memory v2 lifecycle and private workflows #10586, along with embedding generation, fsync, progress and repair-status behavior. GET/PUT preparation tests pin the actual response boundary.test/metrics/test_process_gauges.pyto verify that each real kernel probe's byte value reaches the SDK unchanged, rather than assuming an atomic cross-source peak/current ordering. Production RSS probes are unchanged.This is part 1 of the seven-part restructuring tracked by #10521. It does not activate a durable task queue, adaptive controller, new recovery settings or recovery services. Recovery APIs and their owning tests are delivered with their actual consumers in later parts, not as an unused standalone library here. The original intent comment remains an immutable record; individual review dispositions explain this scope subtraction.
Base:
mainat7c6e6720b00142dbfbcbcdf39446b7306e25add4.Candidate:
0b6a3b91c58849e3721d4df7e3e2f4fccdd006c5.Complete incremental diff: 60,570 bytes across 35 files; one feature commit.
The retained fixes restore existing declared behavior. They do not claim a new product-shape RFC approval. Later default-changing layers retain their separate RFC prerequisite.
Tests
305f123cda56fe8176ee951565efee0b898a4b0b. Both pinned local reviewers independently confirmed the current0b6a3b91c58849e3721d4df7e3e2f4fccdd006c5diff and unchanged base rules: no blocking findings. Opus reports no findings; GPT's one nonblocking import advisory is addressed below.The GPT lane retains one nonblocking
top-level-importsadvisory for the narrowMemoryStartupUnavailabletype import. The base rule explicitly hasblocking: false. This is an acknowledged style tradeoff, not a claimed circular-import exemption or literal rule compliance; it does not justify another behavioral change to an already verified error boundary. The individual disposition records the evidence and remaining site.The successful runs still report runtime/deprecation/thread warnings, report-only documentation/i18n debt, and temporary/cache observations. These are not presented as resolved or as executed cross-platform coverage; no check or threshold was relaxed.
Manual verification
Read the complete base-to-head diff, verified the private-writer and shared-preparation response paths separately, and checked that no production RSS or process-termination code was changed. Built the wheel with matching frontend assets and exercised the isolated Chromium/Electron setup.
No live gateway, real provider, production data home or machine-wide agent configuration was modified. Native Windows/macOS behavior is not inferred from Linux mocks; applicable remote platform CI remains required. Remote CI/review readiness for this new revision is pending. No new panel, layout, interaction or visual styling is introduced.
Related Issues
Part of PR #10521. This existing PR remains the first layer; no replacement PR is being opened.
Dependencies: none; this layer targets
main. The remaining six PRs will be published with their direct predecessor branches as bases and kept draft until their own readiness conditions are met. Publishing the stack is not a claim that every layer has full main-base CI or an approved product-shape RFC.Coordination: preserve the agent-home scope of PR #9714; the memory lifecycle work in PR #10586 is already in this base and is not reimplemented here. Later layers separately coordinate lifecycle and terminal/outbox interfaces.
Pattern harvest
Rule candidate: review-prompt / lint.
Pattern: a documented numeric bound omitted at its loader call; a public error response interpolating an internal exception; a test patching a shared module attribute when it needs a subject-local spy; duplicate test monkeypatches silently replacing a parameterized premise.
Test-design pattern: comparisons between independently sampled platform counters need a documented common accounting/snapshot contract. Preserve and verify actual probe values instead of fabricating an ordering with allocator churn or clamping.
No new repository rule, production guard or gate threshold is introduced by this PR.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)