Skip to content

feat(web): confirm clear-context in the page and acknowledge the result - #11157

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
rnoack1:split/channel-clear-context-409
Oct 28, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
rnoack1:split/channel-clear-context-409

Conversation

@rnoack1

@rnoack1 rnoack1 commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Carved out of #7161, which is well over the 1500 added-line cap and is being split so it can
actually be reviewed. This unit is self-contained: it compiles and tests on the current main
tip with nothing else applied.

Problem / Motivation

Goal: make a channel-context clear ask for consent in the page and then say what it did.

Clearing a channel's context asked for confirmation through the browser's native confirm(), and
the copy did not mention that a channel-wide clear also deletes the shared messages. A native
dialog cannot be translated, its OK button does not restate the act being consented to, and once
the request finished nothing in the page acknowledged it.

Why it matters

A clear is destructive and its confirm understated it: accepting a dialog that spoke only about
resetting context also deleted the channel's transcript. After the click, success looked exactly
like a no-op, so the only way to find out what happened was to look at the transcript.

Not a goal

What changed

  • The channel-wide confirm goes through the shared useConfirm hook, whose danger button
    restates the act: "Clear context and delete messages". No second dialog is added here;
    ChannelPage renders the same number of Modals as it does on main.
  • useConfirm gains a cancel() so a caller can withdraw an ask whose subject disappeared.
    The channel-wide confirm needs it: another client closing the channel mid-dialog must not
    leave a dialog asking about a channel that is gone, nor redirect the clear onto its
    successor. The target is pinned before the await and re-checked after it. cancel is a
    stable useCallback, so it is safe in an effect's dependency list.
  • The confirm copy now says the channel-wide clear deletes the messages. The per-agent confirm
    deliberately does not, because clearing one agent keeps the transcript.
  • A clean clear acknowledges itself: a role="status" line in the channel header, plus a check
    mark on the row that was clicked, scrolled into view. The mark carries no tooltip of its own,
    since the header line already names the role. The per-agent acknowledgment hides itself
    after 4s. The channel-wide one reports a deletion, so it stays until dismissed or the channel
    changes rather than taking the only proof of that deletion with it.
  • Clear buttons go busy while the request is in flight, and their icon becomes a spinner so a
    slow request does not look like a dead button. The header opener uses aria-disabled plus an
    early return rather than disabled, because the dialog's focus trap restores focus to it on
    unmount and its FOCUSABLE selector skips disabled buttons. It carries matching
    aria-disabled: styling so the busy state is visible and not only announced.
  • The clear calls api.channelClearContext directly. In-flight state lives in one place, a
    per-target count, so a per-agent clear settling while the channel-wide one is still open
    does not re-enable the destructive button.
  • A clear failure takes its own notice rather than the shared one, which offers an agent hand-off
    that would unmount this page and destroy the unsent composer and thread drafts. A 404 says what
    is gone ("This channel no longer exists. Refresh the channel list.", or the agent equivalent)
    instead of the server's bare "not found".
  • reconcileChannel now reports a failed reload instead of swallowing it. This is deliberately
    wider than the clear: every caller (post-clear, dismiss refusal, listen-mode refusal) gets it,
    and keepExisting keeps the notice that caller already raised.
  • Results are scoped to the channel on screen. A late result for a channel the user has left is
    dropped, except a genuine failure, which still takes the page notice: a destructive action that
    failed must not go unreported anywhere.

Tests

  • 120 tests pass across the 5 ChannelPage suites; 34 of those are this unit's own clear-context
    suite.
  • Reverting ChannelPage.tsx to the main tip fails 29 of those 34, so the source change is
    load-bearing rather than incidentally green.
  • tsc -p tsconfig.app.json clean.
  • eslint --max-warnings 0 clean on the changed source and test files.
  • lint:i18n clean, run with I18N_BASE_REF set to the merge base, because the per-locale and
    changed-value arms skip silently when it is unset.
  • Each guard added here was break-armed: disabling the on-screen scope check reddens exactly the
    late-success test, disabling the off-screen failure route reddens both failure tests, and
    removing the busy styling reddens exactly the header-busy test. The 404 wording, the busy
    spinner, the untitled mark and the stable cancel each have a test that fails against the
    previous revision.

Screenshots / video

Committed under temp-screenshots/channel-clear-context/, six states in both themes:

frame shows
confirm-{dark,light}.png the clear-all dialog, danger button reading "Clear context and delete messages"
done-line-{dark,light}.png "Context cleared. The channel's messages were deleted too."
row-mark-{dark,light}.png "Cleared for Researcher." with the check mark on the clicked row only
busy-{dark,light}.png the request in flight, header opener greyed with a spinner
row-busy-{dark,light}.png a per-agent clear in flight, that row's own control greyed with a spinner
error-{dark,light}.png a 404 clear, reported as "This channel no longer exists. Refresh the channel list."

Captured by website/scripts/capture-channel-clear-context.mjs against the
capture/channel-clear-context harness, which stubs the /channels and /clear-context
responses and leaves everything else real. Each shot asserts the pictured state rendered
before shooting, and the row-mark shot asserts the mark belongs to exactly one row, so a
frame cannot show the pre-change surface.

Known, and pre-existing rather than introduced here: in the row-mark frames the agents panel
is a fixed w-64, so the role names truncate. The mark reuses the cleared button's own slot,
so a marked row truncates no more than an unmarked one.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 16, 2026
@dwu96

dwu96 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! This PR is currently in draft status. Workflow runs won't be auto-approved until it's marked as ready for review.

When you're ready, click "Ready for review" and the workflows will be approved on the next cycle automatically.

@rnoack1
rnoack1 marked this pull request as ready for review September 16, 2026 10:36
@rnoack1
rnoack1 requested review from a team and buluoray September 16, 2026 10:36
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of f9ae8702e1ae925e2a9fffd44b719976364038ca via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. All twelve committed screenshots show every new state in both themes. No first-time reader has looked at them: a fork PR gets a single pass with no blind read. Pushing the branch to this repo would run one.

Notes

  • clear-context-error shows up as a full-width banner above the channel layout (error-light.png), far from the "Clear Context" button the user just clicked. Rendering it under the channel header, where clear-context-done already sits, would put the failure where the user is looking.
  • On the per-agent row, the green check (justCleared) disappears after 4s and has no visible text. The only words naming the role are "Cleared for Researcher." in the header line, which is far from the panel. Fine for now, but if the row mark is ever kept without the header line, it needs a label.

[UX-REVIEWED] f9ae870

Description read

[DESCRIPTION-READ] 5dff2e736d9ce4f5faf2d4a386c7238277af16846a26ec5f9604a79ada405f12

That sha256 names everything this verdict read: the PR description, plus the 15 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of f9ae8702e1ae925e2a9fffd44b719976364038ca via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the in-page confirm, the clearer copy and the acknowledgment fix the stated problem, the screenshots cover all six states, and the patch removes nothing (the locale keys are only reordered).

Notes

  • The clear-context state now lives inline in ChannelPage (about 230 added lines): renderedIdRef, clearBusyTargets, the scoped clearError/clearDone, pendingClearAllRef and the effects that tie them together. Moving it into a useChannelClear hook would keep the page from heading toward the 1,600-line split, and would give Channel: move the per-agent Clear context confirm onto the shared in-page dialog #25179's per-agent confirm one owner to adopt.

[DESIGN-REVIEWED] f9ae870

Description read

[DESCRIPTION-READ] e7553d529926a93987f329097d01ec24d028f207d41fa7946ee61f29101ef594

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of f9ae8702e1ae925e2a9fffd44b719976364038ca via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

No blockers. Every item answers a named harm, and the one surface added (cancel) has its consumer in the same change.

What this change ships

Inventory (9 items) — 8 justified

Intent: before a destructive channel clear, ask for consent inside the page in words that state the deletion, then confirm what happened. A FIX.

  1. The channel-wide clear asks in an in-page dialog instead of the browser's confirm(), and the danger button reads "Clear context and delete messages" — justified
  2. The confirm copy now says the channel's messages are deleted, in all 13 locales — justified
  3. A successful clear shows a role="status" line in the header; the channel-wide one stays until dismissed, the per-agent one hides after 4s — justified
  4. The row that was cleared shows a check mark in place of its clear button — justified
  5. Clear buttons show a spinner and are marked busy while the request runs — justified
  6. A clear failure has its own notice with no agent hand-off, and a 404 says what is gone — justified
  7. If the channel is closed while the dialog is open, the dialog is withdrawn (useConfirm().cancel, 1 consumer) — justified
  8. A failed channel reload after any caller (clear, dismiss, listen-mode) now raises a notice; before, /* the failure notice is already showing */ hid it — rides along, declared, and keepExisting keeps that caller's own notice
  9. Committed screenshots, plus a capture harness and script — justified

[FIRST-PRINCIPLES-REVIEWED] f9ae870

Description read

[DESCRIPTION-READ] 1a38f104a1c807205df52861148bd49c3a988840cd238b5692277672a786eb9a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed f9ae8702e1ae925e2a9fffd44b719976364038ca via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f9ae870

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings (all downgraded on adjudication)

Reviewed f9ae8702e1ae925e2a9fffd44b719976364038ca via the fork AI-review pipeline; updated in place on each push.

Opus 5.5 adjudication downgraded every blocking finding. Downgraded: the remedy each one needs is disproportionate to the harm it prevents. Adjudication downgraded all 1 blocking finding(s): the remedy each one requires is disproportionate to the harm it prevents.

Review details

BLOCKING -- website/src/pages/ChannelPage.tsx:697 -- Keep clear-related failures on a draft-safe notice (origin: validation)

fail('pages.channelPage.failed_to_clear_context', err)
Trigger: Start clearing channel A, switch to B, type an unsent message, then let A's request fail. failClearContext calls fail, exposing the shared notice's “Ask the agent” action. A failed post-clear reconcileChannel also reaches that notice.
Outcome: Clicking that action navigates to /chat and unmounts ChannelPage, discarding its unsent composer and thread drafts; this page registers no navigation-leave guard.
Anchor: errors-use-error-notice
Fix: Route clear-related failures, including reload failures, through a visible notice without agent hand-off; leave off-screen failures unscoped so they remain visible.

[BLOCK-MERGE-DOWNGRADED] f9ae870
[GPT-REVIEWED] f9ae870

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 is downgraded: harm is LOW. Unsent composer or thread text is lost only if the user clicks "Ask the agent" themselves. That needs a clear-context failure on a channel that is off screen (patch ChannelPage.tsx +1115–1117, failClearContext→fail) or a failed post-clear reload (+1198–1200), then landing in the shared notice that has askAgent on (+1282). The click navigates and unmounts the page (ErrorNotice.tsx:184). There is no recovery; the user retypes the draft. The base code already sent every clear failure to this notice, with a recorded decision that the hand-off "risks nothing" (ChannelPage.tsx:805-814), and this PR narrows that exposure. Base rule website-AUTOSDE.yaml:734-745 blocks only on a missing hand-off decision, never on its direction, and says not to overrule an author's comment.
The real fix would add a third error-scoping mechanism beside postError/clearError, which the PR's own comment (+1150–1154) declines to build. That permanent cost outweighs a rare, visible draft loss the user triggers themselves.

[ADJUDICATION] f9ae8702e1ae925e2a9fffd44b719976364038ca total=1 uphold=0 downgrade=1
DOWNGRADE F1 website/src/pages/ChannelPage.tsx:697 reason=disproportionate-remedy
[GPT-ADJUDICATED] f9ae8702e1ae925e2a9fffd44b719976364038ca

@dwu96 dwu96 added the needs-pr-triage PR scanner: awaiting automated triage label Sep 23, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: chenmingwei23#de330d0c]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:

  • First Principles BLOCK: the confirm copy and tooltips (14 locales) promise that a working agent's context and channel messages are kept on a busy refusal, but the base handlers_channel.py handler never refuses and always clears -- the busy-refusal UI and its copy front-run a backend change that has not landed. Decide whether to ship without those claims now (drop the busy-specific copy and the dead busy/409 refusal-renderer path) or hold this PR until the backend companion PR merges.
  • Design/UX BLOCK: no screenshot or recording of the new confirm modal, warn banner, success line, or per-row marks is attached, so the rendered shape can't be judged. The PR body says the capture scenes were deliberately excluded to stay under the line cap -- please attach a still or short recording of this revision, or land the capture-scenes PR first.

When you've addressed these, the pipeline will re-assess on its next cycle.

@chenmingwei23 chenmingwei23 added needs-author-decision PR blocked on author input and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 23, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 26, 2026
@rnoack1
rnoack1 force-pushed the split/channel-clear-context-409 branch from dbc2d57 to 953ec6b Compare September 26, 2026 23:50
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 26, 2026
@rnoack1
rnoack1 force-pushed the split/channel-clear-context-409 branch from 953ec6b to 2272712 Compare September 27, 2026 00:50
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Sep 27, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 19, 2026
@rnoack1
rnoack1 force-pushed the split/channel-clear-context-409 branch from 42b17c7 to 17c88f3 Compare October 21, 2026 15:33
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 21, 2026
@rnoack1
rnoack1 force-pushed the split/channel-clear-context-409 branch from 17c88f3 to 95c5a5a Compare October 21, 2026 16:04
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 21, 2026
@rnoack1
rnoack1 force-pushed the split/channel-clear-context-409 branch 2 times, most recently from bcd1f33 to 8909725 Compare October 21, 2026 16:36
@rnoack1 rnoack1 changed the title feat(web): refuse a busy clear-context in the page instead of a native dialog feat(web): confirm clear-context in the page and acknowledge the result Oct 21, 2026
@rnoack1
rnoack1 force-pushed the split/channel-clear-context-409 branch from 8909725 to bccd3c4 Compare October 21, 2026 17:21
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 21, 2026
@rnoack1
rnoack1 force-pushed the split/channel-clear-context-409 branch from bccd3c4 to a2f0acb Compare October 21, 2026 18:44
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 21, 2026
@rnoack1
rnoack1 force-pushed the split/channel-clear-context-409 branch from a2f0acb to e4b4e19 Compare October 21, 2026 19:06

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on 1e44dd7.

  1. The success mark is drawn faded. In AgentControlRow the button holding the check mark sets aria-disabled={clearing || justCleared}, and its class applies aria-disabled:opacity-30 (ChannelPage.tsx#L364-L366). So the acknowledgment this PR adds shows at 30% opacity, like a disabled control. Smallest fix: keep the early return on justCleared, but set aria-disabled={clearing} (or skip the opacity class while justCleared), and add a test that the done state carries no aria-disabled.
  2. The UX lane's items on this head have no reply (UX Review): no frame of the clear-failure notice or of a per-agent clear in flight, and the 4-second timeout on the line that says the messages were deleted (#L759). Add the frames or reply why not, and say whether that line should stay until dismissed.
  3. The comment at #L687 names cleared_shared_log "on the server", which does not exist on main; please reword it.

The rest holds up: the confirm target is pinned and re-checked, a closed channel withdraws the dialog, off-screen failures still reach the page notice, and the busy/409 path that did not match #11691 is gone. CI is green.

— crew-pr-reviewer (r128)

@rnoack1

rnoack1 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

All three fixed at 71ed9900cce563743bd9cffdc9a3692781126a5d.

1. The success mark drawn faded. Your two options were decided by a test already in this
branch: aria-disabled={clearing} reddens the "keeps the pressed row button focused" case,
which asserts the done state carries aria-disabled="true" and was added for an earlier
blocker about focus falling to <body>. So I took the parenthetical. In AgentControlRow
the opacity class is now conditional on justCleared while aria-disabled stays, so the
check renders at full text-ok strength and the control is still announced as
non-interactive. New test pins it and fails against the previous head.

The header opener keeps its unconditional fade on purpose: it has no done state, so its only
faded state is in-flight.

2. The UX lane's items. Both evidence gaps are now committed frames under
temp-screenshots/channel-clear-context/: error-{dark,light}.png, a refused clear reported
in the page's own notice, and row-busy-{dark,light}.png, one agent's clear in flight with
the panel open. Twelve frames now, and the description's table lists them.

On the 4-second timeout, that line should stay, and now does. It is the only report that the
messages were deleted, so hiding it on a timer loses the proof for anyone who looked away.
Only the per-agent acknowledgment expires; the channel-wide one stays until dismissed or the
channel changes, and it gained a dismiss control placed inside the status element, which is
where ErrorNotice puts its own.

3. The comment naming cleared_shared_log. Correct, and it existed nowhere else in the
tree. It now names ch.messages.clear() in the server's scope=all branch.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on ebf2b91.

The three r128 items are fixed: the success mark now renders at full strength (ChannelPage.tsx#L366) with a test pinning it, the error and row-busy frames are committed, the deletion receipt stays until dismissed, and the cleared_shared_log comment is reworded. The confirm target is pinned and re-checked, and CI is green.

What remains:

  1. Deferred work without an issue. ## Not a goal says moving the per-agent confirm (#L1193) onto the shared dialog "is a separate change", and that the busy-refusal UI ships with the backend unit (#11691). Please open an issue for the per-agent confirm and link it, plus #11691 or an issue for the refusal UI, in the description.
  2. Current-head lane notes have no reply. UX Review raises the raw "Failed to clear context not found" text in the error frame, the busy opener having no spinner, and the check mark's title repeating the header line. Design Review raises useMutation duplicating clearBusyTargets, and cancel changing identity every render (harmless here, since the effect is idempotent). Fix each or reply why not.

Reviewed head: ebf2b91c004e64378459cfe6d2e97593367d78ce.

— crew-pr-reviewer (r131)

@rnoack1

rnoack1 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever Both r131 items are addressed at 5ad69da7aa730b5460cac21a099f54fcd9b920fc.

1. Deferred work now has issues. ## Not a goal links #25179 (move the per-agent confirm onto the shared dialog, opened for this) and #11691 (the backend change that the busy-refusal UI ships with).

2. Every current-head lane note is fixed in code:

  • Raw "not found" text (UX). A 404 now says what is gone: "This channel no longer exists. Refresh the channel list.", or "This agent is no longer in the channel. Refresh the channel." for a per-agent clear (website/src/pages/ChannelPage.tsx:703, new keys in all 12 locales). error-*.png shows it.
  • Busy opener with no spinner (UX). The header opener and the per-agent button both swap their icon for a spinning Loader2 while their request runs (ChannelPage.tsx:1063, :372). busy-*.png and row-busy-*.png show it.
  • Check mark title repeats the header line (UX). The mark no longer has a title (ChannelPage.tsx:366). It keeps its aria-label, since it is an icon-only button.
  • useMutation duplicating clearBusyTargets (Design). Removed. runClear calls api.channelClearContext directly (ChannelPage.tsx:895-896), so clearBusyTargets is the only in-flight state, and the networkMode: 'always' workaround is gone with it.
  • cancel changing identity every render (Design). It is now a useCallback (website/src/components/ConfirmDialog.tsx:126).

Each fix has a test that fails against ebf2b91c00 and passes at the new head. Full website suite: 55424 passed. The description also states that the reconcileChannel reporting change deliberately affects every caller, not only the clear.

The clear-all confirm is now the page's own dialog restating that messages are
deleted, and a clean clear acknowledges itself in the page and in the row.

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving f9ae870.

The r131 items are settled. The per-agent confirm is tracked in #25179, whose body covers it, and #11691 is the backend change that produces the busy refusal. The UX and Design notes from the previous head are fixed in code. The channel-wide confirm is pinned to its channel and withdrawn when the channel closes (ChannelPage.tsx#L929). CI is green on this head.

AI findings judged non-blocking

  • GPT 6.1 (downgraded): an off-screen clear failure still uses the notice with the agent hand-off. On-screen failures use the hand-off-free notice, and base sent every clear failure to the hand-off one, so this narrows exposure. Losing a draft needs the user to click the hand-off (#L692-L711).
  • UX: the failure banner sits above the layout. It shares the page's existing notice position, so this is a placement preference (#L1014).
  • UX: the row check mark has no visible text. It only appears together with the header status line that names the role, and it keeps an aria-label (#L1092).
  • Design: move the clear state into a hook. This is an optional refactor with no user-visible effect (#L890).

— crew-pr-reviewer (r133)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) needs-author-decision PR blocked on author input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants