Repository navigation
Conversation
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has seen the edition onboarding lockup or the edition loading page. The four screenshots show every changed surface, but this fork lane has no blind read. Watch
[UX-REVIEWED] 035b2c6 Description read[DESCRIPTION-READ] 92df3ecf6cf9700a6c1d78cdbb38f2ec97085bc82a5ce657be131e6d3a59a62c That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the token prompt's hardcoded [DESIGN-REVIEWED] 035b2c6 Description read[DESCRIPTION-READ] c40f5dc43ea9d82c78b9088e3cd183c8ab574cdb8bf68d8dc545562b5391be7c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The splash sandbox (bridge filter, navigation guard, injected CSP, parse5) protects against an edition that already runs arbitrary code in the full-bridge dashboard. Not justified as shipped
What this change shipsInventory (7 items) — 6 justifiedIntent: let downstream editions brand onboarding and desktop startup without patching core — ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 035b2c6 Description read[DESCRIPTION-READ] 4c668f8a8ccd203e692e77647d3d77fa0bcba2b1c3b261bd59b93e541f7d3d7d That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed Review detailsPackaging can silently skip edition staging and its fail-closed checks. FINDING — website/scripts/lib/editionDesktop.mjs:1241 — [OPUS-REVIEWED] 035b2c6 |
884023d to
abfc1ae
Compare
|
|
|
|
|
|
abfc1ae to
b8093cc
Compare
|
|
|
Minimal edition input used for the comparison: // initialize-language.ts
import { initI18n } from '@/i18n'
initI18n('en')
// extensions.ts
import './initialize-language'
import { i18next, setProductName } from '@/i18n'
const initializedBefore = i18next.isInitialized
setProductName('Orbit Crew')
console.log({ initializedBefore, defaults: i18next.options.interpolation?.defaultVariables })Built with |
cdc1919 to
033105a
Compare
|
Fixed the current-head blockers in |
|
Fixed the |
033105a to
7d8bd68
Compare
7d8bd68 to
2f4bec2
Compare
|
🤖 Kiro Crew [operator: dwu96#8c08bee0]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
Not blockers, recorded so they are not re-litigated: all three backend failures are tracked flakes in files this PR does not touch — When you've addressed these, the pipeline will re-assess on its next cycle. If you'd prefer no automation on this PR at all, add the |
|
PR triage (2026-10-05) — #11263: REBASE + CONTINUE-DEVELOPMENT, keep open I checked head Coverage on main: none. Rebase needed. The branch is 1071 commits behind, and a trial merge conflicts in two files:
Regression still open on stock builds. This was raised before by the Opus lane on
The result: on the stock Token Required page the minimize, maximize and close caption buttons do nothing, and on the stock splash minimize and maximize do nothing. On main today all of them work. I'm leaving this as a comment rather than a new change request because the concern is already on record. Security finding F1 is still fenced. GPT flagged Overlap, not duplicate: #16566 (open PR) also narrows what Recommendation: rebase onto main, restore caption controls for local shell pages (or record a maintainer decision to drop them), and settle F1. Then this is ready for maintainer review. |
Let editions customize onboarding decoration and stage a distinct desktop loading page while preserving stock fallbacks. Keep transient shell navigation constrained and preserve existing hide-to-tray behavior.
Restore the frameless-Linux caption buttons on every local shell page by forwarding only the minimize, maximize-toggle and close actions; the main process still decides which it honours. Guard navigation and window opening for every file: document instead of matching a page name that history.replaceState can rewrite. Keep the stock splash close control and the build-only HTML parser.
|
Rebased onto
Electron suite: 2,488 passed, 4 skipped, 0 failed. Packaging: 20 passed. Focused onboarding tests: 6 passed. TypeScript and ESLint are clean. Note for #16566: whichever PR lands second must keep both |
|
This PR adds edition seams for onboarding artwork and an edition-supplied Electron |
|
Moving this back to draft while the design is agreed in #19805. That issue lists the decisions this PR needs from a maintainer: the preload bridge for local pages, window-control admission, the CSP for edition HTML, the navigation guards, and whether both seams are wanted. Once they're settled I'll rebase this to match, or close it if a different design is preferred. |
Problem / Motivation
Goal: Let downstream editions brand first-run onboarding and desktop startup without patching core files.
Edition packages can brand the dashboard, but setup and Electron startup still expose stock artwork.
Why it matters
Without supported seams, editions must patch core files and repeatedly resolve the same conflicts while upgrading. Mixed stock and edition identity during setup or recovery also makes a packaged edition look incomplete.
Not a goal
What changed (motivation → approach → change)
To keep edition artwork in one place, onboarding now reuses
ThemeBranding.logofor its lockup and accepts optionalonboardingDecorations. The stock ghost and decorations remain the fallback.To let editions own the desktop startup surface without patching Electron, packaging allowlist-validates an optional
desktop/loading.html, stages it asedition-loading.html, and clears staged inputs on every exit. Local shell pages use a restrictive CSP and bridge: the three boot signals plus the minimize, maximize and close caption actions, so frameless-Linux title-bar buttons keep working; the main process still decides which actions it honours. Everyfile:document is treated as a shell page, so a page that rewrites its own path cannot escape the guard. Loading pages cannot navigate or open windows, and the token prompt may hand off only to its configured gateway origin. Electron removes stock and edition splash routes from Back history after handoff and recovery.The HTML parser used only by staging is a build-time dependency. The extension, theming, and Electron contracts document the supported ownership and fallback behavior.
Backwards compatibility
Compatible: stock branding and desktop startup remain unchanged when an edition supplies no branding assets.
Tests
Rebased onto
mainat7044e7550.file:page staying confined.Manual verification
The shared onboarding component was rendered with stock and generic edition inputs at desktop, 390 px, and 320 px widths. The packaged Linux Electron shell was booted against an isolated HTTP fixture; cold boot and liveness recovery both acknowledged boot-ready, reached the dashboard, and removed the splash from Back history.
Screenshots / video
Related Issues
No linked issue; this adds supported edition seams.
Checklist