Repository navigation
Conversation
Audit note — this PR and #5738 are one branch stack, not duplicatesA duplicate-detection sweep flagged these two as near-identical because they share a large block of added lines. They are not duplicates: one branch contains the other's commits, so the shared lines are inherited, and the review diff overstates what this PR actually authored. This is the textbook stacked-branch artifact, provable by SHA rather than by reading code: What is genuinely each PR's ownIf #5738 merges, #7196 still carries all of its own work and loses nothing: 6 files #5738 never touches ( Suggested actionLand #5738 first, then rebase #7196 onto From a repository-wide duplicate/overlap audit of every pull request open against |
Open PR relationship auditThis is a consolidated, point-in-time code-level audit note. It compares complete merge-base diffs and current/merged code; it does not treat a shared topic as duplication or partial coverage as completion. Relationship findings
No PR, Issue, label, branch, or review state was changed by the relationship-note portion of this audit. |
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
When you've addressed these, the pipeline will re-assess on its next cycle. |
|
Attempted a rebase onto main They land in the parent commit (
Also pending on this PR's own commit: merged #7532 moved Suggested order: land #5738 first, then rebase this branch so its diff is just its own 22 files. |
375f708 to
0d57103
Compare
|
Rebased: this branch is now exactly two commits — #5738's current head On the audit notes: #7532 moved the host code, so the display-media handler change now lives in One change beyond the rebase: Electron's native picker exists only on macOS 15+, so macOS 14 and older now get the Local gates on this head: electron node:test green, related vitest 29/29, Still needs a human, and cannot be done from the Linux host this was rebased on: the hands-on pass on Windows (loopback) and macOS 15+ (native picker). The per-OS checklist is in the description's Manual verification section. This PR still merges only after #5738. |
0d57103 to
f658784
Compare
UX Review (Fable 5, fork) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK cannot evaluate: missing every screenshot — a new Record flow (menu items, badge, meter, icon, notices) ships with an empty image list; the description says "Not captured yet." Watch
Evidence gaps
[UX-REVIEWED] f658784 Description read[DESCRIPTION-READ] dca44a1c5c191556211055bc617a62051544b2ce9e52e51454b74a604baa5b03 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Fable 5, fork) — 🔴 BLOCK (blocking)Design-level review of Design-Verdict: BLOCK Cannot evaluate: missing screenshot or recording of the desktop recording UI — no platform branch was run and no surface was rendered. BlockersEvery behavior this PR exists to deliver is unobserved on every platform it targets. [DESIGN-REVIEWED] f658784 Description read[DESCRIPTION-READ] 27bcb8626a83863205b015e0af3ebe187a0b4b613dba0efe6b827de1d4687739 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Every tier promise (Windows loopback, macOS picker audio) is untested on any desktop build — the description admits it — and two new exports have zero consumers. Not justified as shipped
What this change shipsInventory (9 items) — 7 justifiedIntent: In the desktop app, a meeting recording captures the other participants' audio wherever Electron can provide it, and says up front where it cannot — an ADDITION (one commit atop the declared stack base #5738).
[FIRST-PRINCIPLES-REVIEWED] f658784 Description read[DESCRIPTION-READ] c201322bee7a870f6d6e7ba778220c64d53d77fc6117e6e6f15f20ba11edac00 That sha256 names the PR description this verdict read. Recompute it with |
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed 2 of 2 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- src/kiro_crew/recording/ws.py:264 -- Transcribe selection truncates recordings at five minutes BLOCKING -- website/src/apps/meetings/hooks/useMeetingSession.ts:728 -- Stop finalizes before pending PCM is drained [BLOCK-MERGE] f658784 Adjudication (Opus 5) — is blocking on each finding proportionate?F1 — F2 — [ADJUDICATION] f658784 total=0 uphold=0 downgrade=0 [ADJUDICATION-FENCED] f658784 fenced=2 flagged=0 |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNothing blocks — but the Transcribe billing cap truncates every meeting recording on a socket that sends no audio to Transcribe. FINDING — src/kiro_crew/recording/ws.py:264 — FINDING — src/kiro_crew/config/sections.py:4066 — FINDING — website/src/apps/meetings/hooks/useMeetingRecording.ts:257 — [OPUS-REVIEWED] f658784 |
Adds a recording package that owns an audio session: a state machine
per session, a WAV writer, and recovery scaffolding for a session whose
process died mid-recording. The dashboard exposes it at
/api/ws/recording, and the Meetings app resolves where a recording lands
through its own recording store.
The socket carries audio IN and emits only ready / level / error back.
It does not transcribe: the browser already streams the same PCM to
/api/ws/stt and the Meetings app persists that transcript, so the
never-reached transcript path (_emit_transcript, the live-transcript
persister and its security-posture sink row) is removed rather than
kept as a claim no request could satisfy.
Every recording of a meeting gets its own file -- audio.wav, then
audio-2.wav, ... -- and the writer creates it exclusively ("xb"). The
previous fixed name opened with "wb" truncated the earlier recording
the moment a user recorded a second time (stop then Record, a dropped
socket, the Transcribe duration cap). `ready` names the file so a client
can tell recordings apart.
The frontend captures both the microphone and the system output and
sums them inside the PCM worklet's two inputs ahead of main's polyphase
resampler, so the mix is anti-alias filtered once; a single-input node
(dashboard dictation) is unaffected. A meter shows input level so a
user can see the capture is live.
The session registry lock is a LoopBoundLock and the concurrency cap
has a single definition in session.py.
A browser tab can only offer system audio through a display-capture prompt, and on some platforms not at all. Electron can grant it directly, so the display-media handler (installed by runtime/window/session-security.js) resolves a loopback audio track where the platform supports one, and the frontend is told which capture tier it actually gets. The tier is decided in one place, display-media.js::describeAudioTier; window-lifecycle.js computes it once and passes it to the sandboxed preload through additionalArguments. A platform that cannot provide system audio (video-only tier) is never prompted: requestSystemAudio reports 'no-loopback' and the meeting degrades to microphone-only instead of starting a screen capture that can only return video. The loopback grant is gated on request.audioRequested AND win32, because the handler is shared with the chat screen-snip tool and Electron 43's electron.d.ts scopes Streams.audio 'loopback' to Windows. macOS never reaches the handler while useSystemPicker is on, so its audio is whatever the native picker offers.
f658784 to
f612bfb
Compare
Open-PR triage (2026-10-05): DISTINCT, stacked on #5738. Rebase after #5738 landsI checked head Relationships
Breaking change / P0: none found.
Still open: the Windows / macOS 15+ hands-on checks and screenshots listed in the description. The bot findings on Recommendation: REBASE onto #5738 once it merges, so this diff is only its own 24 files, then finish the manual per-OS pass. Do not close this PR. |
|
Steward review (no merge). This PR is stacked on #5738 (its history contains that PR's
Additionally, it predates two things now on The underlying questions (platforms, consent boundary, recording-others policy, retention) are a maintainer decision, unruled as of |
|
Thanks for this PR. It now conflicts with main. Could you rebase onto the latest main and resolve the conflicts? We will review it again once it is rebased and CI is green. This branch has had no activity for over 30 days. If there is no further activity in the next 14 days, we may close it. You can always reopen it or open a new PR later. |
Proposes answers to the three maintainer questions left open in kirodotdev#2814 (platform scope, capability reporting, consent boundary), backed by measurements of getDisplayMedia system audio in Chrome and in the Electron shell, and a phased plan whose first phase mixes the computer audio with the microphone ahead of the existing worklet so the STT protocol and the server stay unchanged. Records the Electron-on-macOS gap (electron/electron#47490) as out of scope and names the two open PRs (kirodotdev#5738, kirodotdev#7196) that conflict with the issue's premises.
Problem / Motivation
Goal: In the desktop app, a meeting recording captures the other participants' audio wherever Electron can provide it, and tells the user up front where it cannot.
In a browser tab, system audio (the remote side of a Zoom/Chime call) is only reachable through a display-capture prompt, and on some platforms not at all. So in the desktop app — the place most likely to be running next to a call — a meeting records only what the microphone picks up.
Why it matters
The desktop app is the surface most likely to be running beside a call, and today it records only the local microphone there: a transcript with half the conversation missing, and no hint that the other half was never captured.
Not a goal
What changed (motivation → approach → change)
The desktop app now picks the best way to get the call's audio for the machine it runs on, and says so before recording starts.
loopbacksystem-pickervideo-onlywebsite/electron/display-media.jscomputes the tier (the macOS version comes from the Darwin release, 24 = macOS 15) and grants loopback audio only when the request asked for audio and the platform can provide it, behind the existing capture identity gate.window-lifecycle.jspasses the tier to the renderer andpreload.jsexposes it;runtime/window/session-security.jsenables the native picker only where it exists. In the renderer,audio/captureTier.tschecks the track it actually received, so a platform that cannot provide system audio degrades to microphone-only instead of recording silence.systemAudio.tsgains ano-loopbackfailure,useMeetingSession.tsmaps it to one new string in every catalog underwebsite/src/i18n/locales/(for examplelocales/en.json), anddocs/system-specs/modules/meetings.mddescribes the tiers.Backwards compatibility
Compatible: the screen-snip tool keeps its video-only grants (audio is gated on
audioRequested), and the browser path is unchanged.Tests
website/electron/test/display-media.test.js— tier per platform and macOS version (Darwin 24 picker, 23 video-only), loopback only when audio was requested, an untrusted requester refused beforegetSources.website/electron/test/window-lifecycle.test.js— the tier argument reaches the renderer.website/src/test/MeetingsCaptureTier.test.ts— the renderer's tier probe and each degradation path, with source pins pointing atwindow-lifecycle.jsandsession-security.js.Manual verification
Not performed on a desktop build: this branch was prepared on Linux. A human needs to check:
window.kirocrew.audioTieris"loopback"; the chat screen-snip shows no system-audio indicator; Stop releases the capture.audioTieris"system-picker"; a surface without audio shows the no-audio notice and records the microphone; cancelling the picker records the microphone.audioTieris"video-only"; Record shows the no-loopback notice with no capture prompt.audioTieris"video-only"; Record shows the no-loopback notice with no capture prompt and no screen-sharing indicator.Screenshots / video
Not captured yet. The visible change is the
no-loopbacknotice (and the absence of a capture prompt) in the desktop app on macOS 14 and Linux; it appears only inside a packaged Electron build, which this Linux host did not run. A capture from the per-OS pass above is still owed.Related Issues
no linked issue: feature work from the Meetings stack; depends on #5738.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)