Repository navigation
feat(settings): move the search box to the top of the sidebar - #11381
Conversation
|
Intent: Move the Settings search into the top of the sidebar rail so it lives with the section list it searches, and keep it visible (pinned) while the section list scrolls. |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the open-dropdown state in the live dashboard — the second screenshot shows a blank page around it, suggesting an isolated harness render. Suggestions
[DESIGN-REVIEWED] 76a2213 |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Self-directed move with no named failing user, plus a new Not justified as shipped
What this change shipsInventory (5 items) — 2 justifiedIntent: put the Settings search where the section list it searches lives, and keep it on screen while scrolling — an ADDITION (placement change), not a fix of a reported defect.
[FIRST-PRINCIPLES-REVIEWED] 76a2213 |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Search-open state was captured on a blank page, so the dropdown overlaying the real tab list — the layout this PR creates — is unverified in pixels. Watch
Suggestions
[UX-REVIEWED] 76a2213 |
98decf4 to
bb81835
Compare
bb81835 to
c8569d3
Compare
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author. Assessment: The CI on this head ran on 2026-09-17 and is six days stale — the four red backend shards ( If you'd prefer I don't touch this PR, add the |
Move the Settings search field from the page header (top-right) to a pinned slot at the top of the sidebar rail, under the title and above the tab list. It stays put (sticky) while the tab list scrolls. - SidePanelLayout: new desktop-only navTop slot; the sidebar now pins title + navTop + footer and scrolls only the tab list. New 'nav' dock variant. The content-header only renders headerRight for the 'header' dock now. - SettingsSearch: full-width boxed input and a full-rail-width downward dropdown when docked in the sidebar (stays inside the rail, no clipping). - SettingsPage: pass the search as navTop (desktop); the mobile bottom-float capsule is unchanged.
c8569d3 to
76a2213
Compare
|
|
|
|
|
|
|
|
bolichen97
left a comment
There was a problem hiding this comment.
Approved after full readiness scan: readiness: passed, required check PR Readiness green on 76a2213, no effective CHANGES_REQUESTED, no unresolved blocking threads.
…1381) Move the Settings search field from the page header (top-right) to a pinned slot at the top of the sidebar rail, under the title and above the tab list. It stays put (sticky) while the tab list scrolls. - SidePanelLayout: new desktop-only navTop slot; the sidebar now pins title + navTop + footer and scrolls only the tab list. New 'nav' dock variant. The content-header only renders headerRight for the 'header' dock now. - SettingsSearch: full-width boxed input and a full-rail-width downward dropdown when docked in the sidebar (stays inside the rail, no clipping). - SettingsPage: pass the search as navTop (desktop); the mobile bottom-float capsule is unchanged.
Problem / Motivation
On the Settings page the search box sat in the page header, top-right — away from the sidebar list of sections it actually searches. It was easy to miss, and it scrolled off with the header.
Why it matters
Search is how you jump to a setting without hunting the tab list. Sitting in the header, detached from the sections and able to scroll away, it was in the wrong place for the job it does.
What changed (motivation → approach → change)
The search now lives at the top of the Settings sidebar, directly under the "Settings" title and above the section list — where you look to switch sections. The title, the search, and the version footer stay pinned while only the section list scrolls beneath them, so search never leaves the screen.
Because the sidebar rail is narrow, the results dropdown in
settings/SettingsSearch.tsxstays at rail width and wraps long setting names onto two lines instead of cutting them off, so every result reads in full ("Trust this machine's tailnet name", "When the agent may speak (WhatsApp)"). On phones the search is unchanged — the floating bottom capsule as before.To support the pinned slot,
SidePanelLayout.tsxgains a desktop-onlynavTopslot and anavdock value, andSettingsPage.tsxpasses the search into that slot on desktop; thebottom-floatheader control no longer renders in the desktop header (its one consumer, Settings, now supplies the control throughnavTop).Tests
N/A — layout/styling change; no behavior a unit test covers. Verified by rendering the real components (see screenshots).
Manual verification
Rendered the real
SidePanelLayout+SettingsSearchin the project build and captured the resting state, a live search showing full (wrapped) result names, and a scrolled state proving the search stays pinned.no linked issue: self-directed UX placement change