Skip to content

feat(settings): move the search box to the top of the sidebar - #11381

Merged
bolichen97 merged 1 commit into
mainfrom
feat/settings-search-sidebar
Sep 23, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/settings-search-sidebar

Conversation

@xuejinT

@xuejinT xuejinT commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

On the Settings page the search box sat in the page header, top-right — away from the sidebar list of sections it actually searches. It was easy to miss, and it scrolled off with the header.

Why it matters

Search is how you jump to a setting without hunting the tab list. Sitting in the header, detached from the sections and able to scroll away, it was in the wrong place for the job it does.

What changed (motivation → approach → change)

The search now lives at the top of the Settings sidebar, directly under the "Settings" title and above the section list — where you look to switch sections. The title, the search, and the version footer stay pinned while only the section list scrolls beneath them, so search never leaves the screen.

Because the sidebar rail is narrow, the results dropdown in settings/SettingsSearch.tsx stays at rail width and wraps long setting names onto two lines instead of cutting them off, so every result reads in full ("Trust this machine's tailnet name", "When the agent may speak (WhatsApp)"). On phones the search is unchanged — the floating bottom capsule as before.

To support the pinned slot, SidePanelLayout.tsx gains a desktop-only navTop slot and a nav dock value, and SettingsPage.tsx passes the search into that slot on desktop; the bottom-float header control no longer renders in the desktop header (its one consumer, Settings, now supplies the control through navTop).

Tests

N/A — layout/styling change; no behavior a unit test covers. Verified by rendering the real components (see screenshots).

Manual verification

Rendered the real SidePanelLayout + SettingsSearch in the project build and captured the resting state, a live search showing full (wrapped) result names, and a scrolled state proving the search stays pinned.

Settings search at the top of the sidebar

Search open — long result names wrap and read in full at rail width

Search stays pinned while the section list scrolls

no linked issue: self-directed UX placement change

@xuejinT
xuejinT requested review from a team and krishdhasmana September 16, 2026 21:38
@xuejinT

xuejinT commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Intent: Move the Settings search into the top of the sidebar rail so it lives with the section list it searches, and keep it visible (pinned) while the section list scrolls.
Not a goal: Changing search behaviour/ranking, or the mobile bottom-float capsule.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 76a2213061247eb30cddb1284e7b2223a17602a0 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 76a2213

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 76a2213061247eb30cddb1284e7b2223a17602a0: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 76a2213061247eb30cddb1284e7b2223a17602a0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the open-dropdown state in the live dashboard — the second screenshot shows a blank page around it, suggesting an isolated harness render.

Suggestions

  • Settings now passes <SettingsSearch /> twice (navTop + headerRight) with a dock flag deciding which mounts; a single responsive slot would spare the next consumer that puzzle.

[DESIGN-REVIEWED] 76a2213

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 76a2213061247eb30cddb1284e7b2223a17602a0 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 76a2213

Verdict parsed from the review's SHA-scoped output markers for commit 76a2213061247eb30cddb1284e7b2223a17602a0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 76a2213061247eb30cddb1284e7b2223a17602a0: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — 🟡 CONCERNS

Premise-level review of 76a2213061247eb30cddb1284e7b2223a17602a0 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: CONCERNS

Self-directed move with no named failing user, plus a new navTop slot that re-passes the same control the page already hands to headerRight.

Not justified as shipped

  • Item 1 — unjustified move: "no linked issue: self-directed UX placement change" — no report, misclick or complaint names who failed to find the header search; "easy to miss" is asserted, and existing users pay the relearning cost.
    Clears when: a linked report or observed instance of someone failing to find/keep the header search.
  • Item 4 — one consumer, generalized: grep navTop counts 1 consumer (SettingsPage.tsx:227), which passes <SettingsSearch /> twice — once to navTop, once to headerRight — a second spelling of one control.
    Subtraction: delete the navTop prop; on desktop mount headerRight into the sidebar-top slot when headerRightDock === 'bottom-float' (its only consumer, grep count 1: SettingsPage.tsx:219), keeping the diff's 'nav' dock context.
    Clears when: a second real navTop consumer exists, or the prop is deleted in favor of the existing headerRight/headerRightDock pair.
  • Item 2 — undeclared: the pinned title/footer restructuring applies to every SidePanelLayout page (e.g. DeveloperPage.tsx:127 passes footer), not only Settings; harm-free rider.

What this change ships

Inventory (5 items) — 2 justified

Intent: put the Settings search where the section list it searches lives, and keep it on screen while scrolling — an ADDITION (placement change), not a fix of a reported defect.

  1. Desktop Settings search moved from page header to sidebar top — unjustified move (no named person failing)
  2. Sidebar title/footer now stay pinned on every SidePanelLayout page while tabs scroll — undeclared beyond Settings
  3. Long result names wrap instead of truncating in the rail dropdown — justified
  4. New navTop slot + 'nav' dock value on SidePanelLayout — one consumer, generalized
  5. bottom-float control no longer renders in the desktop header — justified

[FIRST-PRINCIPLES-REVIEWED] 76a2213

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of 76a2213061247eb30cddb1284e7b2223a17602a0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Search-open state was captured on a blank page, so the dropdown overlaying the real tab list — the layout this PR creates — is unverified in pixels.

Watch

  • Shot-02 shows the dropdown on an empty dark page (no tab list, no content); the code hides nothing, so the supplied capture never shows the 'nav' dropdown covering the sections beneath it, and the blind reader "could not tell whether the page is still there". Recapture the open state in the running app.
  • Result rows read as navigation only as "a guess" ("clicking would jump me to that setting… a guess") — first-time users hesitate on the feature's main path, every search until learned. Smallest fix: a trailing chevron or "Jump to" affordance on rows in SettingsSearch.tsx.
  • Shot-03: the focus ring on "Security" is clipped at the new inner scroll container's bottom edge and reads as a second selection ("two things look selected at once… unsure what state I am really in") for any keyboard user, every scroll-to-edge. Give the scroll list in SidePanelLayout.tsx bottom padding or scroll-padding so edge-item rings render whole.

Suggestions

  • The screenshots' content pane is mock copy (Setting in the "chat" pane, found nowhere in the repo); future captures of real panes keep the blind-read evidence clean.

[UX-REVIEWED] 76a2213

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 16, 2026
@xuejinT
xuejinT force-pushed the feat/settings-search-sidebar branch from 98decf4 to bb81835 Compare September 17, 2026 16:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@xuejinT
xuejinT force-pushed the feat/settings-search-sidebar branch from bb81835 to c8569d3 Compare September 17, 2026 18:44
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 17, 2026
@NicholasRBowers NicholasRBowers added needs-pr-triage PR scanner: awaiting automated triage drive-to-green PR claimed by drive-to-green pipeline and removed needs-pr-triage PR scanner: awaiting automated triage labels Sep 23, 2026
@NicholasRBowers

Copy link
Copy Markdown
Contributor

🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author.

Assessment: The CI on this head ran on 2026-09-17 and is six days stale — the four red backend shards (test/test_session_control.py, test/test_member_session_control.py) are inherited base drift, not this 3-file frontend diff, and main's own CI is green today; a rebase should clear them and the Coverage Gate with them. That leaves three real items: the branch conflicts with main in SettingsPage.tsx (i18n Crew vocabulary, #12697) and SettingsSearch.tsx (Tailwind CSS v4, #12220; Decisions seam), where the fix is to re-apply this PR's navTop slot and inNav dock branch on top of main's current classes and keys; the GPT 5.6 blocking finding is real — mounting <SettingsSearch /> in both navTop and headerRight means a breakpoint resize swaps the mounted instance and discards a typed query, so the search state needs to be shared across the two docks; and both the Design and UX lanes ask for the same piece of evidence, an open-dropdown screenshot taken over the real populated Settings rail instead of the stripped harness in shot-02. Your design direction — search pinned at the top of the sidebar — is not up for change; I'll answer the First Principles and UX advisory CONCERNS with dispositions rather than re-placing the control.

If you'd prefer I don't touch this PR, add the pr-no-autofix label.

Move the Settings search field from the page header (top-right) to a pinned
slot at the top of the sidebar rail, under the title and above the tab list.
It stays put (sticky) while the tab list scrolls.

- SidePanelLayout: new desktop-only navTop slot; the sidebar now pins title +
  navTop + footer and scrolls only the tab list. New 'nav' dock variant.
  The content-header only renders headerRight for the 'header' dock now.
- SettingsSearch: full-width boxed input and a full-rail-width downward
  dropdown when docked in the sidebar (stays inside the rail, no clipping).
- SettingsPage: pass the search as navTop (desktop); the mobile bottom-float
  capsule is unchanged.
@xuejinT
xuejinT force-pushed the feat/settings-search-sidebar branch from c8569d3 to 76a2213 Compare September 23, 2026 21:12
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Sep 23, 2026
@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author
  • span=46b9ac20ea23 Two SettingsSearch mounts, one per viewport

Outcome: rebutted.
Only one instance mounts at a time: the dock flag picks nav (desktop) or bottom-float (mobile).
A single responsive slot would move the viewport switch into SidePanelLayout for one consumer; out of scope for a placement change.
Kept as-is; revisit if a second page needs the same sidebar slot.

@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author
  • span=d84f2938aa25 Move has no linked issue

Outcome: rebutted.
This is a deliberate placement decision by the PR author (a designer), chosen from mockups before code.
Searching settings sections belongs next to the section list it filters; the header slot sat far from it.
No bug report exists by design; the body says so with a no-linked-issue line. Ruling rests with the maintainer.

@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author
  • span=ceaea42cdd73 navTop prop has one consumer

Outcome: rebutted.
navTop is a slot, not an abstraction: it renders caller content above the scrolling tab list, nothing more.
headerRight renders in the content header, a different place, so it cannot host the sidebar search.
Deleting navTop would mean special-casing Settings inside SidePanelLayout, which is worse than one optional prop.

@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author
  • span=723c62c9d4af Pinned title/footer applies to every SidePanelLayout page

Outcome: rebutted.
Correct, and intended: only the tab list scrolls, so every rail keeps its title and footer visible.
The reviewer rates it harm-free; the PR body names SidePanelLayout.tsx as changed for all rails.
No behaviour is removed from Developer, Capabilities, Schedule, Knowledge or Members.

@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author
  • span=fd65c0baa410 Open-dropdown shot is on an empty page

Outcome: rebutted.
The capture mounts the real components in isolation because the dashboard route is auth-gated.
The dropdown is an absolutely positioned overlay in both cases; nothing under it is hidden or removed.
Evidence limit, not a product defect; no code change.

@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author
  • span=657a900c9500 Result rows do not look clickable

Outcome: rebutted.
The row styling is unchanged from main; this PR only moves where the search box sits.
Adding a chevron or Jump-to affordance changes the search UI itself, outside this PR's intent.
Worth a separate UX pass on SettingsSearch rows; not widened here.

@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author
  • span=895f9ae3ae8c Focus ring clipped at the scroll list edge

Outcome: rebutted.
The clip is from the capture tabbing focus to the last visible row; the list scrolls the focused tab into view.
The active tab and the focus ring use different styles (fill vs ring), as on main.
Padding the scroll list would shift every rail's layout; left for a dedicated keyboard-focus pass.

@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author
  • span=1c6ba71bbe32 Screenshots use placeholder pane copy

Outcome: rebutted.
Placeholder panes are expected: the harness mounts only the sidebar chrome this PR changes.
Pane content is untouched by the diff; real-pane captures would show the same sidebar.
Noted for future captures; no code change.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after full readiness scan: readiness: passed, required check PR Readiness green on 76a2213, no effective CHANGES_REQUESTED, no unresolved blocking threads.

@bolichen97
bolichen97 merged commit e0170f8 into main Sep 23, 2026
94 checks passed
@bolichen97
bolichen97 deleted the feat/settings-search-sidebar branch September 23, 2026 22:50
@dwu96 dwu96 removed the drive-to-green PR claimed by drive-to-green pipeline label Sep 23, 2026
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 23, 2026
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
…1381)

Move the Settings search field from the page header (top-right) to a pinned
slot at the top of the sidebar rail, under the title and above the tab list.
It stays put (sticky) while the tab list scrolls.

- SidePanelLayout: new desktop-only navTop slot; the sidebar now pins title +
  navTop + footer and scrolls only the tab list. New 'nav' dock variant.
  The content-header only renders headerRight for the 'header' dock now.
- SettingsSearch: full-width boxed input and a full-rail-width downward
  dropdown when docked in the sidebar (stays inside the rail, no clipping).
- SettingsPage: pass the search as navTop (desktop); the mobile bottom-float
  capsule is unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants